git://git.onelab.eu
/
myslice.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
use logger instead of print as often as possible
[myslice.git]
/
unfold
/
loginrequired.py
diff --git
a/unfold/loginrequired.py
b/unfold/loginrequired.py
index
2aca0d0
..
7b10be4
100644
(file)
--- a/
unfold/loginrequired.py
+++ b/
unfold/loginrequired.py
@@
-1,5
+1,3
@@
-from __future__ import print_function
-
from django.contrib.auth.decorators import login_required
from django.utils.decorators import method_decorator
from django.http import HttpResponseRedirect
from django.contrib.auth.decorators import login_required
from django.utils.decorators import method_decorator
from django.http import HttpResponseRedirect
@@
-8,6
+6,8
@@
from django.views.generic.base import TemplateView
from manifoldapi.manifoldresult import ManifoldException
from manifoldapi.manifoldresult import ManifoldException
+from myslice.settings import logger
+
###
# IMPORTANT NOTE
# the implementation of the classes in this file rely on redefining 'dispatch'
###
# IMPORTANT NOTE
# the implementation of the classes in this file rely on redefining 'dispatch'
@@
-35,7
+35,6
@@
class LoginRequiredView (TemplateView):
def logout_on_manifold_exception (fun_that_returns_httpresponse):
def wrapped (request, *args, **kwds):
def logout_on_manifold_exception (fun_that_returns_httpresponse):
def wrapped (request, *args, **kwds):
-# print 'wrapped by logout_on_manifold_exception'
try:
return fun_that_returns_httpresponse(request,*args, **kwds)
except ManifoldException, manifold_result:
try:
return fun_that_returns_httpresponse(request,*args, **kwds)
except ManifoldException, manifold_result:
@@
-47,9
+46,9
@@
def logout_on_manifold_exception (fun_that_returns_httpresponse):
return HttpResponseRedirect ('/')
except Exception, e:
# xxx we need to sugarcoat this error message in some error template...
return HttpResponseRedirect ('/')
except Exception, e:
# xxx we need to sugarcoat this error message in some error template...
-
print("Unexpected exception",e
)
+
logger.error("Unexpected exception {}".format(e)
)
import traceback
import traceback
-
traceback.print_exc(
)
+
logger.error(traceback.format_exc()
)
return HttpResponseRedirect ('/')
return wrapped
return HttpResponseRedirect ('/')
return wrapped