X-Git-Url: http://git.onelab.eu/?a=blobdiff_plain;ds=sidebyside;f=PLC%2FMethods%2FUpdatePerson.py;h=b85cc6401cde3962f96c118b1c2adf2feca8031f;hb=0fa905f9b5a075e509787a74c56f1f3ced669ec4;hp=d45a6044b503288495c0782b44fc3abe0a162899;hpb=3c00321c3c50cf2b7a1e6c927fed61e7ef3fe2c0;p=plcapi.git diff --git a/PLC/Methods/UpdatePerson.py b/PLC/Methods/UpdatePerson.py index d45a604..b85cc64 100644 --- a/PLC/Methods/UpdatePerson.py +++ b/PLC/Methods/UpdatePerson.py @@ -1,19 +1,23 @@ from PLC.Faults import * from PLC.Method import Method from PLC.Parameter import Parameter, Mixed +from PLC.Auth import Auth +from PLC.Table import Row from PLC.Persons import Person, Persons -from PLC.Auth import PasswordAuth +from PLC.sendmail import sendmail +from PLC.TagTypes import TagTypes +from PLC.PersonTags import PersonTags, PersonTag + +related_fields = Person.related_fields.keys() +can_update = ['first_name', 'last_name', 'title', 'email', + 'password', 'phone', 'url', 'bio', 'accepted_aup', + 'enabled'] + related_fields class UpdatePerson(Method): """ - Updates a person. Only the fields specified in update_fields are + Updates a person. Only the fields specified in person_fields are updated, all other fields are left untouched. - To remove a value without setting a new one in its place (for - example, to remove an address from the person), specify -1 for int - and double fields and 'null' for string fields. first_name and - last_name cannot be unset. - Users and techs can only update themselves. PIs can only update themselves and other non-PIs at their sites. @@ -22,46 +26,94 @@ class UpdatePerson(Method): roles = ['admin', 'pi', 'user', 'tech'] - can_update = lambda (field, value): field in \ - ['first_name', 'last_name', 'title', 'email', - 'password', 'phone', 'url', 'bio', 'accepted_aup', - 'enabled'] - update_fields = dict(filter(can_update, Person.fields.items())) + accepted_fields = Row.accepted_fields(can_update,Person.fields) + # xxx check the related_fields feature + accepted_fields.update(Person.related_fields) + accepted_fields.update(Person.tags) accepts = [ - PasswordAuth(), + Auth(), Mixed(Person.fields['person_id'], Person.fields['email']), - update_fields + accepted_fields ] returns = Parameter(int, '1 if successful') - def call(self, auth, person_id_or_email, update_fields): - valid_fields = self.update_fields - # Remove admin only fields - if 'admin' not in self.caller['roles']: - for key in ['enabled']: - valid_fields.remove(key) + def call(self, auth, person_id_or_email, person_fields): + # split provided fields + [native,related,tags,rejected] = Row.split_fields(person_fields,[Person.fields,Person.related_fields,Person.tags]) + + # type checking + native = Row.check_fields (native, self.accepted_fields) + if rejected: + raise PLCInvalidArgument, "Cannot update Person column(s) %r"%rejected - if filter(lambda field: field not in valid_fields, update_fields): - raise PLCInvalidArgument, "Invalid field specified" + # Authenticated function + assert self.caller is not None # Get account information persons = Persons(self.api, [person_id_or_email]) if not persons: - raise PLCInvalidArgument, "No such account" - - person = persons.values()[0] + raise PLCInvalidArgument, "No such account %s"%person_id_or_email + person = persons[0] - # Authenticated function - assert self.caller is not None + if person['peer_id'] is not None: + raise PLCInvalidArgument, "Not a local account %s"%person_id_or_email # Check if we can update this account if not self.caller.can_update(person): raise PLCPermissionDenied, "Not allowed to update specified account" - person.update(update_fields) - person.sync() + # Make requested associations + for k,v in related.iteritems(): + person.associate (auth, k, v) + + person.update(native) + person.update_last_updated(False) + person.sync(commit=True) + + # send a mail + if 'enabled' in person_fields: + To = [("%s %s" % (person['first_name'], person['last_name']), person['email'])] + Cc = [] + if person['enabled']: + Subject = "%s account enabled" % (self.api.config.PLC_NAME) + Body = "Your %s account has been enabled. Please visit %s to access your account." % (self.api.config.PLC_NAME, self.api.config.PLC_WWW_HOST) + else: + Subject = "%s account disabled" % (self.api.config.PLC_NAME) + Body = "Your %s account has been disabled. Please contact your PI or PlanetLab support for more information" % (self.api.config.PLC_NAME) + sendmail(self.api, To = To, Cc = Cc, Subject = Subject, Body = Body) + + + for (tagname,value) in tags.iteritems(): + # the tagtype instance is assumed to exist, just check that + tag_types = TagTypes(self.api,{'tagname':tagname}) + if not tag_types: + raise PLCInvalidArgument,"No such TagType %s"%tagname + tag_type = tag_types[0] + person_tags=PersonTags(self.api,{'tagname':tagname,'person_id':person['person_id']}) + if not person_tags: + person_tag = PersonTag(self.api) + person_tag['person_id'] = person['person_id'] + person_tag['tag_type_id'] = tag_type['tag_type_id'] + person_tag['tagname'] = tagname + person_tag['value'] = value + person_tag.sync() + else: + person_tag = person_tags[0] + person_tag['value'] = value + person_tag.sync() + + # Logging variables + self.event_objects = {'Person': [person['person_id']]} + + # Redact password + if 'password' in person_fields: + person_fields['password'] = "Removed by API" + self.message = 'Person %d updated: %s.' % \ + (person['person_id'], person_fields.keys()) + if 'enabled' in person_fields: + self.message += ' Person enabled' return 1