X-Git-Url: http://git.onelab.eu/?a=blobdiff_plain;f=CodingStyle;h=bae8cd65ced7caf87a5bfe21a734fea8f1dc3853;hb=0d21340a5a1e26bba46522ba4666033564f8e930;hp=c6e1a6186f0f2692e983699cd70220dc1064b31e;hpb=34582733d9aad82bba60f4bf986b62d58412502a;p=sliver-openvswitch.git diff --git a/CodingStyle b/CodingStyle index c6e1a6186..bae8cd65c 100644 --- a/CodingStyle +++ b/CodingStyle @@ -224,7 +224,7 @@ statement, that is, write "return 0;" and not "return(0);" break; default: - NOT_REACHED(); + OVS_NOT_REACHED(); } "switch" statements with very short, uniform cases may use an @@ -515,8 +515,7 @@ global variables. C DIALECT - Some C99 features are OK because they are widely implemented even in -older compilers: + Some C99 features are OK because they are widely implemented: * Flexible array members (e.g. struct { int foo[]; }). @@ -531,12 +530,12 @@ older compilers: only take on the values 0 or 1, because this behavior can't be simulated on C89 compilers. + * Designated initializers (e.g. "struct foo foo = {.a = 1};" and + "int a[] = {[2] = 5};"). + Don't use other C99 features that are not widely implemented in older compilers: - * Don't use designated initializers (e.g. don't write "struct foo - foo = {.a = 1};" or "int a[] = {[2] = 5};"). - * Don't mix declarations and code within a block. * Don't use declarations in iteration statements (e.g. don't write