X-Git-Url: http://git.onelab.eu/?a=blobdiff_plain;f=CodingStyle;h=bbb492e3247f4d500cb29ce6a63c0a5d28f28d48;hb=refs%2Fheads%2Forig-parallel;hp=69df907a2367b6034b6686ce947531521b5eaf63;hpb=1d87357a1322c2faa290452c08c7f794c0be848b;p=sliver-openvswitch.git diff --git a/CodingStyle b/CodingStyle index 69df907a2..bbb492e32 100644 --- a/CodingStyle +++ b/CodingStyle @@ -412,13 +412,8 @@ Exception 1: Put a space after (but not before) the "sizeof" keyword. Exception 2: Put a space between the () used in a cast and the expression whose type is cast: (void *) 0. - Break long lines before binary operators and the ternary operators ? -and :, rather than after them, e.g. - - if (first_long_condition() || second_long_condition() - || third_long_condition()) - -and + Break long lines before the ternary operators ? and :, rather than +after them, e.g. return (out_port != VIGP_CONTROL_PATH ? alpheus_output_port(dp, skb, out_port) @@ -430,7 +425,9 @@ and precedence makes it necessary, or unless the operands are themselves expressions that use && and ||. Thus: - if (!isdigit(s[0]) || !isdigit(s[1]) || !isdigit(s[2])) { + if (!isdigit((unsigned char)s[0]) + || !isdigit((unsigned char)s[1]) + || !isdigit((unsigned char)s[2])) { printf("string %s does not start with 3-digit code\n", s); }