X-Git-Url: http://git.onelab.eu/?a=blobdiff_plain;f=Makefile.am;h=4c58b93c6f5004cbb9994f03445aef1806d5ddb7;hb=f196cf974f8df3afdeb56ea58d34e6a9e741663d;hp=4b6156d14cb2ef0d8dee0605ff3baadeb3740ef5;hpb=853d10830faccd9a8d37780d2f957aaba40105d5;p=sliver-openvswitch.git diff --git a/Makefile.am b/Makefile.am index 4b6156d14..4c58b93c6 100644 --- a/Makefile.am +++ b/Makefile.am @@ -1,4 +1,4 @@ -# Copyright (C) 2007, 2008, 2009, 2010, 2011, 2012 Nicira, Inc. +# Copyright (C) 2007, 2008, 2009, 2010, 2011, 2012, 2013 Nicira, Inc. # # Copying and distribution of this file, with or without modification, # are permitted in any medium without royalty provided the copyright @@ -41,17 +41,23 @@ PYCOV_CLEAN_FILES = build-aux/check-structs,cover EXTRA_DIST = \ CodingStyle \ DESIGN \ + FAQ \ + INSTALL \ + INSTALL.Debian \ + INSTALL.Fedora \ INSTALL.KVM \ INSTALL.Libvirt \ - INSTALL.Linux \ INSTALL.RHEL \ INSTALL.SSL \ INSTALL.XenServer \ - INSTALL.bridge \ INSTALL.userspace \ + IntegrationGuide \ NOTICE \ + OPENFLOW-1.1+ \ PORTING \ + README-OFTest \ README-gcov \ + README-lisp \ REPORTING-BUGS \ SubmittingPatches \ WHY-OVS \ @@ -102,10 +108,12 @@ ro_shell = printf '\043 Generated automatically -- do not modify! -*- buffer- SUFFIXES += .in .in: + @mkdir -p $$(dirname $@) $(PERL) $(srcdir)/build-aux/soexpand.pl -I$(srcdir) < $< | \ sed \ -e 's,[@]PKIDIR[@],$(PKIDIR),g' \ -e 's,[@]LOGDIR[@],$(LOGDIR),g' \ + -e 's,[@]DBDIR[@],$(DBDIR),g' \ -e 's,[@]PERL[@],$(PERL),g' \ -e 's,[@]PYTHON[@],$(PYTHON),g' \ -e 's,[@]RUNDIR[@],$(RUNDIR),g' \ @@ -131,13 +139,18 @@ CLEAN_LOCAL += clean-pycov # If we're checked out from a Git repository, make sure that every # file that is in Git is distributed. +# +# We only enable this check when GNU make is in use because the +# Makefile in datapath/linux, needed to get the list of files to +# distribute, requires GNU make extensions. +if GNU_MAKE ALL_LOCAL += dist-hook-git dist-hook-git: distfiles @if test -e $(srcdir)/.git && (git --version) >/dev/null 2>&1; then \ (cd datapath && $(MAKE) distfiles); \ (cat distfiles; sed 's|^|datapath/|' datapath/distfiles) | \ sort -u > all-distfiles; \ - (cd $(srcdir) && git ls-files) | grep -v '\.gitignore$$' | \ + (cd $(srcdir) && git ls-files) | grep -vFf $(srcdir)/.non-distfiles | \ sort -u > all-gitfiles; \ comm -1 -3 all-distfiles all-gitfiles > missing-distfiles; \ if test -s missing-distfiles; then \ @@ -156,17 +169,61 @@ distfiles: Makefile sed -e "s|^$$srcdirstrip/||;t" \ -e "s|^$$topsrcdirstrip/|$(top_builddir)/|;t" | sort -u > $@ CLEANFILES += distfiles +endif +.PHONY: dist-hook-git + +# Check that every .c file includes . +ALL_LOCAL += config-h-check +config-h-check: + @cd $(srcdir); \ + if test -e .git && (git --version) >/dev/null 2>&1 && \ + git --no-pager grep -L '#include ' `git ls-files | grep '\.c$$' | \ + grep -vE '^datapath|^lib/sflow|^third-party'`; \ + then \ + echo "See above for list of violations of the rule that"; \ + echo "every C source file must #include ."; \ + exit 1; \ + fi +.PHONY: config-h-check -# Check that "struct vlog_ratelimit" is always declared "static". -ALL_LOCAL += rate-limit-check -rate-limit-check: +# Check that certain data structures are always declared "static". +ALL_LOCAL += static-check +static-check: @if test -e $(srcdir)/.git && (git --version) >/dev/null 2>&1 && \ - git --no-pager grep -n -E '^[ ]+struct vlog_rate_limit.*=' $(srcdir); \ + git --no-pager grep -n -E '^[ ]+(struct vlog_rate_limit|pthread_once_t|struct ovsthread_once).*=' $(srcdir); \ then \ echo "See above for list of violations of the rule that "; \ - echo "'struct vlog_rate_limit' must always be 'static'"; \ + echo "certain data structures must always be 'static'"; \ exit 1; \ fi +.PHONY: static-check + +# Check that assert.h is not used outside a whitelist of files. +ALL_LOCAL += check-assert-h-usage +check-assert-h-usage: + @if test -e $(srcdir)/.git && (git --version) >/dev/null 2>&1 && \ + (cd $(srcdir) && git --no-pager grep -l -E '[<]assert.h[>]') | \ + $(EGREP) -v '^lib/(sflow_receiver|vlog|worker).c$$|^tests/'; \ + then \ + echo "Files listed above unexpectedly #include <""assert.h"">."; \ + echo "Please use ovs_assert (from util.h) instead of assert."; \ + exit 1; \ + fi +.PHONY: check-assert-h-usage + +ALL_LOCAL += thread-safety-check +thread-safety-check: + @if test -e '$(srcdir)'/.git && (git --version) >/dev/null 2>&1 && \ + grep -n -f '$(srcdir)'/build-aux/thread-safety-blacklist \ + `git ls-files '$(srcdir)' | grep '\.[ch]$$' \ + | $(EGREP) -v '^datapath|^lib/sflow|^third-party'` \ + | $(EGREP) -v ':[ ]*/?\*'; \ + then \ + echo "See above for list of calls to functions that are"; \ + echo "blacklisted due to thread safety issues"; \ + exit 1; \ + fi +EXTRA_DIST += build-aux/thread-safety-blacklist if HAVE_GROFF ALL_LOCAL += manpage-check @@ -199,6 +256,11 @@ install-data-local: $(INSTALL_DATA_LOCAL) uninstall-local: $(UNINSTALL_LOCAL) .PHONY: $(DIST_HOOKS) $(CLEAN_LOCAL) $(INSTALL_DATA_LOCAL) $(UNINSTALL_LOCAL) +modules_install: +if LINUX_ENABLED + cd datapath/linux && $(MAKE) modules_install +endif + include lib/automake.mk include ofproto/automake.mk include utilities/automake.mk @@ -212,3 +274,5 @@ include rhel/automake.mk include xenserver/automake.mk include python/automake.mk include python/compat/automake.mk +include planetlab/automake.mk +include tutorial/automake.mk