X-Git-Url: http://git.onelab.eu/?a=blobdiff_plain;f=PLC%2FFilter.py;h=d3a17b4e105cdd33208a087ddedac1787fbc3a23;hb=19d4a01ccf66af9e00914351b3eacd5fc880f988;hp=5dc9f9b3df0c3ab03f7959eb3e5ee55d1a8a9920;hpb=396345c6da341555b1cfb3a2fc265687cd4a235b;p=plcapi.git

diff --git a/PLC/Filter.py b/PLC/Filter.py
index 5dc9f9b..d3a17b4 100644
--- a/PLC/Filter.py
+++ b/PLC/Filter.py
@@ -1,23 +1,19 @@
-# $Id$
-# $URL$
+#
+# Thierry Parmentelat - INRIA
+#
 from types import StringTypes
-try:
-    set
-except NameError:
-    from sets import Set
-    set = Set
-
 import time
 
 from PLC.Faults import *
 from PLC.Parameter import Parameter, Mixed, python_type
+from PLC.Logger import logger
 
 class Filter(Parameter, dict):
     """
     A type of parameter that represents a filter on one or more
     columns of a database table.
     Special features provide support for negation, upper and lower bounds,
-    as well as sorting and clipping.
+    sorting and clipping and more...
 
 
     fields should be a dictionary of field names and types.
@@ -33,26 +29,8 @@ class Filter(Parameter, dict):
     example : filter = { 'hostname' : '*.edu' , site_id : [34,54] }
 
 
-    Whether the filter represents an intersection (AND) or a union (OR)
-    of these criteria is determined as follows:
-    * if the dictionnary has the '-AND' or the '-OR' key, this is chosen
-    * otherwise, the join_with argument, as provided to the sql method below,
-      is expected to hold the 'AND' or 'OR' string
-      this argument defaults to 'AND' and in most of the code, this default applies
-      as the join_with argument is left unspecified
-
-
     Special features:
 
-    * a field starting with '&' or '|' should refer to a sequence type
-      the semantic is then that the object value (expected to be a list)
-      should contain all (&) or any (|) value specified in the corresponding
-      filter value. See other examples below.
-    example : filter = { '|role_ids' : [ 20, 40 ] }
-    example : filter = { '|roles' : ['tech', 'pi'] }
-    example : filter = { '&roles' : ['admin', 'tech'] }
-    example : filter = { '&roles' : 'tech' }
-
     * a field starting with the ~ character means negation.
     example :  filter = { '~peer_id' : None }
 
@@ -72,14 +50,29 @@ class Filter(Parameter, dict):
       SQL wildcard character.
     example :  filter = { 'hostname' : '*.jp' }
 
+    * a field starting with '&' or '|' should refer to a sequence type
+      the semantics is then that the object value (expected to be a list)
+      should contain all (&) or any (|) value specified in the corresponding
+      filter value. See other examples below.
+    example : filter = { '|role_ids' : [ 20, 40 ] }
+    example : filter = { '|roles' : ['tech', 'pi'] }
+    example : filter = { '&roles' : ['admin', 'tech'] }
+    example : filter = { '&roles' : 'tech' }
+
     * the filter's keys starting with '-' are special and relate to sorting and clipping
-    * '-SORT' : a field name, or an ordered list of field names that are used for sorting
-      these fields may start with + (default) or - for denoting increasing or decreasing order
+      * '-SORT' : a field name, or an ordered list of field names that are used for sorting
+        these fields may start with + (default) or - for denoting increasing or decreasing order
     example : filter = { '-SORT' : [ '+node_id', '-hostname' ] }
-    * '-OFFSET' : the number of first rows to be ommitted
-    * '-LIMIT' : the amount of rows to be returned
+      * '-OFFSET' : the number of first rows to be ommitted
+      * '-LIMIT' : the amount of rows to be returned
     example : filter = { '-OFFSET' : 100, '-LIMIT':25}
 
+    * similarly the two special keys below allow to change the semantics of multi-keys filters
+      * '-AND' : select rows that match ALL the criteria (default)
+      * '-OR'  : select rows that match ANY criteria
+      The value attached to these keys is ignored. 
+      Please note however that because a Filter is a dict, you cannot provide two criteria on a given key.
+      
 
     Here are a few realistic examples
 
@@ -273,5 +266,7 @@ class Filter(Parameter, dict):
             clip_part += " ORDER BY " + ",".join(sorts)
         if clips:
             clip_part += " " + " ".join(clips)
-        if Filter.debug: print 'Filter.sql: where_part=',where_part,'clip_part',clip_part
-        return (where_part,clip_part)
+        if Filter.debug:
+            logger.debug('Filter.sql: where_part={} - clip_part={}'
+                         .format(where_part, clip_part))
+        return where_part, clip_part