X-Git-Url: http://git.onelab.eu/?a=blobdiff_plain;f=PLC%2FMethods%2FUpdateNode.py;h=1e41b651ca64de2cdbb6ef586547d74bcfe29918;hb=f33f00dd690e8bcd8df9c6a542c35844a6a9aa8a;hp=28a04131f4d9b122e28dd8b9140aeb24e8e225fa;hpb=9c8afbd94fac7c0f0c185eca8a1a4f404baff6d1;p=plcapi.git diff --git a/PLC/Methods/UpdateNode.py b/PLC/Methods/UpdateNode.py index 28a0413..1e41b65 100644 --- a/PLC/Methods/UpdateNode.py +++ b/PLC/Methods/UpdateNode.py @@ -4,9 +4,11 @@ from PLC.Parameter import Parameter, Mixed from PLC.Nodes import Node, Nodes from PLC.Auth import Auth +related_fields = Node.related_fields.keys() can_update = lambda (field, value): field in \ ['hostname', 'boot_state', 'model', 'version', - 'key', 'session', 'boot_nonce'] + 'key', 'session', 'boot_nonce', 'site_id'] + \ + related_fields class UpdateNode(Method): """ @@ -21,7 +23,7 @@ class UpdateNode(Method): roles = ['admin', 'pi', 'tech'] - node_fields = dict(filter(can_update, Node.fields.items())) + node_fields = dict(filter(can_update, Node.fields.items() + Node.related_fields.items())) accepts = [ Auth(), @@ -32,14 +34,13 @@ class UpdateNode(Method): returns = Parameter(int, '1 if successful') - object_type = 'Node' - def call(self, auth, node_id_or_hostname, node_fields): - node_fields = dict(filter(can_update, node_fields.items())) + + node_fields = dict(filter(can_update, node_fields.items())) # Remove admin only fields if 'admin' not in self.caller['roles']: - for key in 'key', 'session', 'boot_nonce': + for key in 'key', 'session', 'boot_nonce', 'site_id': if node_fields.has_key(key): del node_fields[key] @@ -61,11 +62,18 @@ class UpdateNode(Method): if node['site_id'] not in self.caller['site_ids']: raise PLCPermissionDenied, "Not allowed to delete nodes from specified site" - node.update(node_fields) + # Make requested associations + for field in related_fields: + if field in node_fields: + node.associate(auth, field, node_fields[field]) + node_fields.pop(field) + + node.update(node_fields) + node.update_last_updated(False) node.sync() # Logging variables - self.object_ids = [node['node_id']] + self.event_objects = {'Node': [node['node_id']]} self.message = 'Node %d updated: %s.' % \ (node['node_id'], ", ".join(node_fields.keys())) if 'boot_state' in node_fields.keys():