X-Git-Url: http://git.onelab.eu/?a=blobdiff_plain;f=datapath%2Fdatapath.c;h=218d1080fecadedcdd5c08862722c6e8b6faa197;hb=d7bf2b001f07e63054bbc0d58fe64ce47bc3ab21;hp=f9af82998a0d8e49ffc12f69b871344605dd1993;hpb=f632c8fc817ff5597007a795b51574bddd32563a;p=sliver-openvswitch.git diff --git a/datapath/datapath.c b/datapath/datapath.c index f9af82998..218d1080f 100644 --- a/datapath/datapath.c +++ b/datapath/datapath.c @@ -223,7 +223,7 @@ static int create_dp(int dp_idx, const char __user *devnamep) goto err; } } else { - snprintf(devname, sizeof devname, "of%d", dp_idx); + snprintf(devname, sizeof(devname), "of%d", dp_idx); } rtnl_lock(); @@ -240,7 +240,7 @@ static int create_dp(int dp_idx, const char __user *devnamep) goto err_put_module; err = -ENOMEM; - dp = kzalloc(sizeof *dp, GFP_KERNEL); + dp = kzalloc(sizeof(*dp), GFP_KERNEL); if (dp == NULL) goto err_put_module; INIT_LIST_HEAD(&dp->port_list); @@ -389,7 +389,7 @@ static int attach_port(int dp_idx, struct odp_port __user *portp) int err; err = -EFAULT; - if (copy_from_user(&port, portp, sizeof port)) + if (copy_from_user(&port, portp, sizeof(port))) goto out; port.devname[IFNAMSIZ - 1] = '\0'; port.type[VPORT_TYPE_SIZE - 1] = '\0'; @@ -582,11 +582,11 @@ static int queue_control_packets(struct sk_buff *skb, struct sk_buff_head *queue nskb = skb->next; skb->next = NULL; - err = skb_cow(skb, sizeof *header); + err = skb_cow(skb, sizeof(*header)); if (err) goto err_kfree_skbs; - header = (struct odp_msg*)__skb_push(skb, sizeof *header); + header = (struct odp_msg*)__skb_push(skb, sizeof(*header)); header->type = queue_no; header->length = skb->len; header->port = port_no; @@ -676,74 +676,75 @@ static int flush_flows(struct datapath *dp) static int validate_actions(const struct nlattr *actions, u32 actions_len) { - const struct nlattr *a; - int rem; - - nla_for_each_attr(a, actions, actions_len, rem) { - static const u32 action_lens[ODPAT_MAX + 1] = { - [ODPAT_OUTPUT] = 4, - [ODPAT_CONTROLLER] = 8, - [ODPAT_SET_DL_TCI] = 2, - [ODPAT_STRIP_VLAN] = 0, - [ODPAT_SET_DL_SRC] = ETH_ALEN, - [ODPAT_SET_DL_DST] = ETH_ALEN, - [ODPAT_SET_NW_SRC] = 4, - [ODPAT_SET_NW_DST] = 4, - [ODPAT_SET_NW_TOS] = 1, - [ODPAT_SET_TP_SRC] = 2, - [ODPAT_SET_TP_DST] = 2, - [ODPAT_SET_TUNNEL] = 8, - [ODPAT_SET_PRIORITY] = 4, - [ODPAT_POP_PRIORITY] = 0, - [ODPAT_DROP_SPOOFED_ARP] = 0, - }; - int type = nla_type(a); - - if (type > ODPAT_MAX || nla_len(a) != action_lens[type]) - return -EINVAL; - - switch (type) { + const struct nlattr *a; + int rem; + + nla_for_each_attr(a, actions, actions_len, rem) { + static const u32 action_lens[ODPAT_MAX + 1] = { + [ODPAT_OUTPUT] = 4, + [ODPAT_CONTROLLER] = 8, + [ODPAT_SET_DL_TCI] = 2, + [ODPAT_STRIP_VLAN] = 0, + [ODPAT_SET_DL_SRC] = ETH_ALEN, + [ODPAT_SET_DL_DST] = ETH_ALEN, + [ODPAT_SET_NW_SRC] = 4, + [ODPAT_SET_NW_DST] = 4, + [ODPAT_SET_NW_TOS] = 1, + [ODPAT_SET_TP_SRC] = 2, + [ODPAT_SET_TP_DST] = 2, + [ODPAT_SET_TUNNEL] = 8, + [ODPAT_SET_PRIORITY] = 4, + [ODPAT_POP_PRIORITY] = 0, + [ODPAT_DROP_SPOOFED_ARP] = 0, + }; + int type = nla_type(a); + + if (type > ODPAT_MAX || nla_len(a) != action_lens[type]) + return -EINVAL; + + switch (type) { case ODPAT_UNSPEC: return -EINVAL; - case ODPAT_CONTROLLER: - case ODPAT_STRIP_VLAN: - case ODPAT_SET_DL_SRC: - case ODPAT_SET_DL_DST: - case ODPAT_SET_NW_SRC: - case ODPAT_SET_NW_DST: - case ODPAT_SET_TP_SRC: - case ODPAT_SET_TP_DST: - case ODPAT_SET_TUNNEL: - case ODPAT_SET_PRIORITY: - case ODPAT_POP_PRIORITY: - case ODPAT_DROP_SPOOFED_ARP: - /* No validation needed. */ - break; - - case ODPAT_OUTPUT: - if (nla_get_u32(a) >= DP_MAX_PORTS) - return -EINVAL; - - case ODPAT_SET_DL_TCI: + case ODPAT_CONTROLLER: + case ODPAT_STRIP_VLAN: + case ODPAT_SET_DL_SRC: + case ODPAT_SET_DL_DST: + case ODPAT_SET_NW_SRC: + case ODPAT_SET_NW_DST: + case ODPAT_SET_TP_SRC: + case ODPAT_SET_TP_DST: + case ODPAT_SET_TUNNEL: + case ODPAT_SET_PRIORITY: + case ODPAT_POP_PRIORITY: + case ODPAT_DROP_SPOOFED_ARP: + /* No validation needed. */ + break; + + case ODPAT_OUTPUT: + if (nla_get_u32(a) >= DP_MAX_PORTS) + return -EINVAL; + break; + + case ODPAT_SET_DL_TCI: if (nla_get_be16(a) & htons(VLAN_CFI_MASK)) return -EINVAL; - break; + break; - case ODPAT_SET_NW_TOS: - if (nla_get_u8(a) & INET_ECN_MASK) - return -EINVAL; - break; + case ODPAT_SET_NW_TOS: + if (nla_get_u8(a) & INET_ECN_MASK) + return -EINVAL; + break; - default: - return -EOPNOTSUPP; - } - } + default: + return -EOPNOTSUPP; + } + } - if (rem > 0) - return -EINVAL; + if (rem > 0) + return -EINVAL; - return 0; + return 0; } static struct sw_flow_actions *get_actions(const struct odp_flow *flow) @@ -1009,7 +1010,7 @@ static int del_flow(struct datapath *dp, struct odp_flow __user *ufp) struct odp_flow uf; int error; - if (copy_from_user(&uf, ufp, sizeof uf)) + if (copy_from_user(&uf, ufp, sizeof(uf))) return -EFAULT; flow = do_del_flow(dp, &uf.key); @@ -1032,7 +1033,7 @@ static int do_query_flows(struct datapath *dp, const struct odp_flowvec *flowvec struct tbl_node *flow_node; int error; - if (copy_from_user(&uf, ufp, sizeof uf)) + if (copy_from_user(&uf, ufp, sizeof(uf))) return -EFAULT; flow_node = tbl_lookup(table, &uf.key, flow_hash(&uf.key), flow_cmp); @@ -1060,7 +1061,7 @@ static int list_flow(struct tbl_node *node, void *cbdata_) struct odp_flow __user *ufp = &cbdata->uflows[cbdata->listed_flows++]; int error; - if (copy_to_user(&ufp->key, &flow->key, sizeof flow->key)) + if (copy_to_user(&ufp->key, &flow->key, sizeof(flow->key))) return -EFAULT; error = answer_query(cbdata->dp, flow, 0, ufp); if (error) @@ -1097,7 +1098,7 @@ static int do_flowvec_ioctl(struct datapath *dp, unsigned long argp, int retval; uflowvec = (struct odp_flowvec __user *)argp; - if (copy_from_user(&flowvec, uflowvec, sizeof flowvec)) + if (copy_from_user(&flowvec, uflowvec, sizeof(flowvec))) return -EFAULT; if (flowvec.n_flows > INT_MAX / sizeof(struct odp_flow)) @@ -1182,7 +1183,7 @@ static int execute_packet(struct datapath *dp, const struct odp_execute __user * { struct odp_execute execute; - if (copy_from_user(&execute, executep, sizeof execute)) + if (copy_from_user(&execute, executep, sizeof(execute))) return -EFAULT; return do_execute(dp, &execute); @@ -1219,7 +1220,7 @@ static int get_dp_stats(struct datapath *dp, struct odp_stats __user *statsp) } stats.max_miss_queue = DP_MAX_QUEUE_LEN; stats.max_action_queue = DP_MAX_QUEUE_LEN; - return copy_to_user(statsp, &stats, sizeof stats) ? -EFAULT : 0; + return copy_to_user(statsp, &stats, sizeof(stats)) ? -EFAULT : 0; } /* MTU of the dp pseudo-device: ETH_DATA_LEN or the minimum of the ports */ @@ -1267,17 +1268,17 @@ static int put_port(const struct vport *p, struct odp_port __user *uop) { struct odp_port op; - memset(&op, 0, sizeof op); + memset(&op, 0, sizeof(op)); rcu_read_lock(); - strncpy(op.devname, vport_get_name(p), sizeof op.devname); - strncpy(op.type, vport_get_type(p), sizeof op.type); + strncpy(op.devname, vport_get_name(p), sizeof(op.devname)); + strncpy(op.type, vport_get_type(p), sizeof(op.type)); vport_get_config(p, op.config); rcu_read_unlock(); op.port = p->port_no; - return copy_to_user(uop, &op, sizeof op) ? -EFAULT : 0; + return copy_to_user(uop, &op, sizeof(op)) ? -EFAULT : 0; } static int query_port(struct datapath *dp, struct odp_port __user *uport) @@ -1285,7 +1286,7 @@ static int query_port(struct datapath *dp, struct odp_port __user *uport) struct odp_port port; struct vport *vport; - if (copy_from_user(&port, uport, sizeof port)) + if (copy_from_user(&port, uport, sizeof(port))) return -EFAULT; if (port.devname[0]) { @@ -1333,7 +1334,7 @@ static int list_ports(struct datapath *dp, struct odp_portvec __user *upv) struct odp_portvec pv; int retval; - if (copy_from_user(&pv, upv, sizeof pv)) + if (copy_from_user(&pv, upv, sizeof(pv))) return -EFAULT; retval = do_list_ports(dp, (struct odp_port __user __force *)pv.ports, @@ -1519,7 +1520,7 @@ static int compat_list_ports(struct datapath *dp, struct compat_odp_portvec __us struct compat_odp_portvec pv; int retval; - if (copy_from_user(&pv, upv, sizeof pv)) + if (copy_from_user(&pv, upv, sizeof(pv))) return -EFAULT; retval = do_list_ports(dp, compat_ptr(pv.ports), pv.n_ports); @@ -1639,7 +1640,7 @@ static int compat_list_flow(struct tbl_node *node, void *cbdata_) struct compat_odp_flow __user *ufp = &cbdata->uflows[cbdata->listed_flows++]; int error; - if (copy_to_user(&ufp->key, &flow->key, sizeof flow->key)) + if (copy_to_user(&ufp->key, &flow->key, sizeof(flow->key))) return -EFAULT; error = compat_answer_query(cbdata->dp, flow, 0, ufp); if (error) @@ -1679,8 +1680,8 @@ static int compat_flowvec_ioctl(struct datapath *dp, unsigned long argp, int retval; uflowvec = compat_ptr(argp); - if (!access_ok(VERIFY_WRITE, uflowvec, sizeof *uflowvec) || - copy_from_user(&flowvec, uflowvec, sizeof flowvec)) + if (!access_ok(VERIFY_WRITE, uflowvec, sizeof(*uflowvec)) || + copy_from_user(&flowvec, uflowvec, sizeof(flowvec))) return -EFAULT; if (flowvec.n_flows > INT_MAX / sizeof(struct compat_odp_flow))