X-Git-Url: http://git.onelab.eu/?a=blobdiff_plain;f=datapath%2Fflow.c;h=8a6ee23d3e833ce0a5761a321f291c670df116be;hb=cdee00fd635d1e0f1eeb5d9c009daeb59abd4777;hp=a3ed9e83310d3d92ea9f0b6a09d34c1b03cc5d09;hpb=7f8ca6459c37ede8faf13f730bcd4d9f05dfd13b;p=sliver-openvswitch.git diff --git a/datapath/flow.c b/datapath/flow.c index a3ed9e833..8a6ee23d3 100644 --- a/datapath/flow.c +++ b/datapath/flow.c @@ -104,22 +104,24 @@ void flow_used(struct sw_flow *flow, struct sk_buff *skb) spin_unlock_bh(&flow->lock); } -struct sw_flow_actions *flow_actions_alloc(size_t n_actions) +struct sw_flow_actions *flow_actions_alloc(u32 actions_len) { struct sw_flow_actions *sfa; + if (actions_len % NLA_ALIGNTO) + return ERR_PTR(-EINVAL); + /* At least DP_MAX_PORTS actions are required to be able to flood a * packet to every port. Factor of 2 allows for setting VLAN tags, * etc. */ - if (n_actions > 2 * DP_MAX_PORTS) + if (actions_len > 2 * DP_MAX_PORTS * nla_total_size(4)) return ERR_PTR(-EINVAL); - sfa = kmalloc(sizeof *sfa + n_actions * sizeof(union odp_action), - GFP_KERNEL); + sfa = kmalloc(sizeof *sfa + actions_len, GFP_KERNEL); if (!sfa) return ERR_PTR(-ENOMEM); - sfa->n_actions = n_actions; + sfa->actions_len = actions_len; return sfa; }