X-Git-Url: http://git.onelab.eu/?a=blobdiff_plain;f=drivers%2Fblock%2Fparide%2Fpg.c;fp=drivers%2Fblock%2Fparide%2Fpg.c;h=6f5df0fad70384b1eab9537740f3a8a2bb73cdfe;hb=64ba3f394c830ec48a1c31b53dcae312c56f1604;hp=13f998aa1cd3ffc19ccf402fd901b91e8b0dbf2d;hpb=be1e6109ac94a859551f8e1774eb9a8469fe055c;p=linux-2.6.git diff --git a/drivers/block/paride/pg.c b/drivers/block/paride/pg.c index 13f998aa1..6f5df0fad 100644 --- a/drivers/block/paride/pg.c +++ b/drivers/block/paride/pg.c @@ -156,6 +156,7 @@ enum {D_PRT, D_PRO, D_UNI, D_MOD, D_SLV, D_DLY}; #include #include #include +#include #include #include #include @@ -642,8 +643,7 @@ static ssize_t pg_read(struct file *filp, char __user *buf, size_t count, loff_t static int __init pg_init(void) { - int unit; - int err; + int unit, err = 0; if (disable){ err = -1; @@ -657,31 +657,40 @@ static int __init pg_init(void) goto out; } - err = register_chrdev(major, name, &pg_fops); - if (err < 0) { + if (register_chrdev(major, name, &pg_fops)) { printk("pg_init: unable to get major number %d\n", major); for (unit = 0; unit < PG_UNITS; unit++) { struct pg *dev = &devices[unit]; if (dev->present) pi_release(dev->pi); } + err = -1; goto out; } - major = err; /* In case the user specified `major=0' (dynamic) */ pg_class = class_create(THIS_MODULE, "pg"); if (IS_ERR(pg_class)) { err = PTR_ERR(pg_class); goto out_chrdev; } + devfs_mk_dir("pg"); for (unit = 0; unit < PG_UNITS; unit++) { struct pg *dev = &devices[unit]; - if (dev->present) + if (dev->present) { class_device_create(pg_class, NULL, MKDEV(major, unit), NULL, "pg%u", unit); + err = devfs_mk_cdev(MKDEV(major, unit), + S_IFCHR | S_IRUSR | S_IWUSR, "pg/%u", + unit); + if (err) + goto out_class; + } } err = 0; goto out; +out_class: + class_device_destroy(pg_class, MKDEV(major, unit)); + class_destroy(pg_class); out_chrdev: unregister_chrdev(major, "pg"); out: @@ -694,10 +703,13 @@ static void __exit pg_exit(void) for (unit = 0; unit < PG_UNITS; unit++) { struct pg *dev = &devices[unit]; - if (dev->present) + if (dev->present) { class_device_destroy(pg_class, MKDEV(major, unit)); + devfs_remove("pg/%u", unit); + } } class_destroy(pg_class); + devfs_remove("pg"); unregister_chrdev(major, name); for (unit = 0; unit < PG_UNITS; unit++) {