X-Git-Url: http://git.onelab.eu/?a=blobdiff_plain;f=findbad.py;h=e1568564033047174e02b34d9943ba8f7ce328d5;hb=32e6f3bdf4fe68b057cf070b756418333ae707d6;hp=7efa52cd0507810842851895979295b51e456334;hpb=6496f5b4a0220e4055fee76c97f92293f9559117;p=monitor.git

diff --git a/findbad.py b/findbad.py
index 7efa52c..e156856 100755
--- a/findbad.py
+++ b/findbad.py
@@ -4,6 +4,8 @@ import os
 import sys
 import string
 import time
+import config
+import util.file
 
 
 # QUERY all nodes.
@@ -29,8 +31,7 @@ import syncplcdb
 from nodequery import verify,query_to_dict,node_select
 import traceback
 import plc
-import auth
-api = plc.PLC(auth.auth, auth.plc)
+api = plc.getAuthAPI()
 
 def collectPingAndSSH(nodename, cohash):
 	### RUN PING ######################
@@ -55,6 +56,8 @@ def collectPingAndSSH(nodename, cohash):
 				echo '  "bmlog":"'`ls /tmp/bm.log`'",'
 				echo '  "bootcd":"'`cat /mnt/cdrom/bootme/ID`'",'
 				echo '  "nm":"'`ps ax | grep nm.py | grep -v grep`'",'
+				echo '  "readonlyfs":"'`touch /var/log/monitor 2>&1`'",'
+				echo '  "dns":"'`host boot.planet-lab.org 2>&1`'",'
 				echo '  "princeton_comon":"'`ls -d /vservers/princeton_comon`'",'
 
 				ID=`grep princeton_comon /etc/passwd | awk -F : '{if ( $3 > 500 ) { print $3}}'` 
@@ -69,9 +72,13 @@ EOF			""")
 				values['sshport'] = port
 				break
 			else:
-				values.update({'kernel': "", 'bmlog' : "", 'bootcd' : '', 'nm' :
-				'', 'princeton_comon' : '', 'princeton_comon_running' : '',
-				'princeton_comon_procs' : '', 'sshport' : None})
+				values.update({'kernel': "", 'bmlog' : "", 'bootcd' : '', 
+							 	'nm' : '', 
+								'readonlyfs' : '',
+								'dns' : '',
+								'princeton_comon' : '', 
+								'princeton_comon_running' : '', 
+								'princeton_comon_procs' : '', 'sshport' : None})
 	except:
 		print traceback.print_exc()
 		sys.exit(1)
@@ -341,8 +348,8 @@ def main():
 	#cohash = {}
 	cohash = cotop.coget(cotop_url)
 	l_nodes = syncplcdb.create_plcdb()
-	if config.filename:
-		f_nodes = config.getListFromFile(config.filename)
+	if config.nodelist:
+		f_nodes = util.file.getListFromFile(config.nodelist)
 		l_nodes = filter(lambda x: x['hostname'] in f_nodes, l_nodes)
 	elif config.node:
 		f_nodes = [config.node]
@@ -359,7 +366,8 @@ def main():
 	# perform this query after the above options, so that the filter above
 	# does not break.
 	if config.nodeselect:
-		l_nodes = node_select(config.nodeselect)
+		fb = database.dbLoad("findbad")
+		l_nodes = node_select(config.nodeselect, fb['nodes'].keys(), fb)
 
 	print "fetching %s hosts" % len(l_nodes)
 
@@ -369,30 +377,21 @@ def main():
 
 
 if __name__ == '__main__':
-	from config import config
-	from optparse import OptionParser
-	parser = OptionParser()
-	parser.set_defaults(filename=None, node=None, site=None, nodeselect=False, nodegroup=None, 
-						increment=False, dbname="findbadnodes", cachenodes=False)
-	parser.add_option("", "--node", dest="node", metavar="hostname", 
-						help="Provide a single node to operate on")
-	parser.add_option("-f", "--nodelist", dest="filename", metavar="FILE", 
-						help="Provide the input file for the node list")
-	parser.add_option("", "--nodeselect", dest="nodeselect", metavar="query string", 
-						help="Provide a selection string to return a node list.")
-	parser.add_option("", "--nodegroup", dest="nodegroup", metavar="FILE", 
-						help="Provide the nodegroup for the list of nodes.")
-	parser.add_option("", "--site", dest="site", metavar="site name",
-						help="Specify a site to view node status")
+	import parser as parsermodule
 
+	parser = parsermodule.getParser(['nodesets'])
+
+	parser.set_defaults( increment=False, dbname="findbad", cachenodes=False)
 	parser.add_option("", "--cachenodes", action="store_true",
 						help="Cache node lookup from PLC")
 	parser.add_option("", "--dbname", dest="dbname", metavar="FILE", 
 						help="Specify the name of the database to which the information is saved")
 	parser.add_option("-i", "--increment", action="store_true", dest="increment", 
 						help="Increment round number to force refresh or retry")
-	config = config(parser)
-	config.parse_args()
+
+	parser = parsermodule.getParser(['defaults'], parser)
+	
+	cfg = parsermodule.parse_args(parser)
 
 	try:
 		main()