X-Git-Url: http://git.onelab.eu/?a=blobdiff_plain;f=fs%2Fext2%2Fxattr_trusted.c;h=52b30ee6a25f31003fe3ad96c5ab087e3f27805d;hb=6a77f38946aaee1cd85eeec6cf4229b204c15071;hp=d9478aed723f10a8e1ce51d252ddac0c5890fb2a;hpb=87fc8d1bb10cd459024a742c6a10961fefcef18f;p=linux-2.6.git diff --git a/fs/ext2/xattr_trusted.c b/fs/ext2/xattr_trusted.c index d9478aed7..52b30ee6a 100644 --- a/fs/ext2/xattr_trusted.c +++ b/fs/ext2/xattr_trusted.c @@ -15,20 +15,21 @@ #define XATTR_TRUSTED_PREFIX "trusted." static size_t -ext2_xattr_trusted_list(char *list, struct inode *inode, - const char *name, int name_len) +ext2_xattr_trusted_list(struct inode *inode, char *list, size_t list_size, + const char *name, size_t name_len) { const int prefix_len = sizeof(XATTR_TRUSTED_PREFIX)-1; + const size_t total_len = prefix_len + name_len + 1; if (!capable(CAP_SYS_ADMIN)) return 0; - if (list) { + if (list && total_len <= list_size) { memcpy(list, XATTR_TRUSTED_PREFIX, prefix_len); memcpy(list+prefix_len, name, name_len); list[prefix_len + name_len] = '\0'; } - return prefix_len + name_len + 1; + return total_len; } static int @@ -55,7 +56,7 @@ ext2_xattr_trusted_set(struct inode *inode, const char *name, value, size, flags); } -struct ext2_xattr_handler ext2_xattr_trusted_handler = { +struct xattr_handler ext2_xattr_trusted_handler = { .prefix = XATTR_TRUSTED_PREFIX, .list = ext2_xattr_trusted_list, .get = ext2_xattr_trusted_get,