X-Git-Url: http://git.onelab.eu/?a=blobdiff_plain;f=fs%2Fnfsctl.c;fp=fs%2Fnfsctl.c;h=a5a18d4aca40a89661ac5dc219c5041e83ac75bb;hb=43bc926fffd92024b46cafaf7350d669ba9ca884;hp=0b14938b5b627ceac85590762fb50ec68f1c872f;hpb=cee37fe97739d85991964371c1f3a745c00dd236;p=linux-2.6.git diff --git a/fs/nfsctl.c b/fs/nfsctl.c index 0b14938b5..a5a18d4ac 100644 --- a/fs/nfsctl.c +++ b/fs/nfsctl.c @@ -5,6 +5,7 @@ * */ #include +#include #include #include #include @@ -97,12 +98,10 @@ asmlinkage sys_nfsservctl(int cmd, struct nfsctl_arg __user *arg, void __user *r if (copy_from_user(&version, &arg->ca_version, sizeof(int))) return -EFAULT; - if (version != NFSCTL_VERSION) { - printk(KERN_WARNING "nfsd: incompatible version in syscall.\n"); + if (version != NFSCTL_VERSION) return -EINVAL; - } - if (cmd < 0 || cmd >= sizeof(map)/sizeof(map[0]) || !map[cmd].name) + if (cmd < 0 || cmd >= ARRAY_SIZE(map) || !map[cmd].name) return -EINVAL; file = do_open(map[cmd].name, map[cmd].rsize ? O_RDWR : O_WRONLY);