X-Git-Url: http://git.onelab.eu/?a=blobdiff_plain;f=fs%2Fnfsctl.c;h=c043136a82caa862d9b72d7196047765490064a0;hb=3967a72a825e44bff5d10f516e90b6f59f59e599;hp=aaf9f5640eb33e98db6570e4b53f58dfb0153402;hpb=9bf4aaab3e101692164d49b7ca357651eb691cb6;p=linux-2.6.git diff --git a/fs/nfsctl.c b/fs/nfsctl.c index aaf9f5640..c043136a8 100644 --- a/fs/nfsctl.c +++ b/fs/nfsctl.c @@ -4,7 +4,7 @@ * This should eventually move to userland. * */ -#include +#include #include #include #include @@ -13,6 +13,7 @@ #include #include #include +#include #include /* @@ -96,12 +97,10 @@ asmlinkage sys_nfsservctl(int cmd, struct nfsctl_arg __user *arg, void __user *r if (copy_from_user(&version, &arg->ca_version, sizeof(int))) return -EFAULT; - if (version != NFSCTL_VERSION) { - printk(KERN_WARNING "nfsd: incompatible version in syscall.\n"); + if (version != NFSCTL_VERSION) return -EINVAL; - } - if (cmd < 0 || cmd >= sizeof(map)/sizeof(map[0]) || !map[cmd].name) + if (cmd < 0 || cmd >= ARRAY_SIZE(map) || !map[cmd].name) return -EINVAL; file = do_open(map[cmd].name, map[cmd].rsize ? O_RDWR : O_WRONLY);