X-Git-Url: http://git.onelab.eu/?a=blobdiff_plain;f=lbuild-initvm.sh;h=ccbb7b16c6d96ee216c9e2a182a8c735bec1df9c;hb=48f43cea02600d0f9015b192a61d16f08cf4dc66;hp=8a303f9f55dc208ecd4851a7911af50326300097;hpb=f2f9c7a7c7acce2767aa68181b38c95320b87abe;p=build.git diff --git a/lbuild-initvm.sh b/lbuild-initvm.sh index 8a303f9f..ccbb7b16 100755 --- a/lbuild-initvm.sh +++ b/lbuild-initvm.sh @@ -13,18 +13,27 @@ BUILD_DIR=$(pwd) # pkgs parsing utilities + lbuild-bridge.sh export PATH=$(dirname $0):$PATH -# old guests have e.g. mount in /bin but this is no longer part of +# old guests have e.g. mount in /bin but this is no longer part of # the standard PATH in recent hosts after usrmove, so let's keep it simple export PATH=$PATH:/bin:/sbin . build.common +# xxx fixme : we pass $lxc around in functions, +# but in fact then we use lxc_root which is a global.. +# it works, but this really is poor practice +# we should have an lxc_root function instead +function lxcroot () { + lxc=$1; shift + echo /vservers/$lxc +} + # XXX fixme : when creating a 32bits VM we need to call linux32 as appropriate...s -DEFAULT_FCDISTRO=f21 +DEFAULT_FCDISTRO=f29 DEFAULT_PLDISTRO=lxc DEFAULT_PERSONALITY=linux64 -DEFAULT_MEMORY=1024 +DEFAULT_MEMORY=3072 ########## # constant @@ -51,7 +60,7 @@ function masklen_to_netmask () { python <=1 and masklen<=32): +if not (masklen>=1 and masklen<=32): print "Wrong masklen",masklen exit(1) result=[] @@ -63,7 +72,7 @@ for i in range(4): result.append(masklen) masklen=0 print ".".join([ str(256-2**(8-i)) for i in result ]) - + EOF } @@ -72,10 +81,13 @@ EOF function package_method () { fcdistro=$1; shift case $fcdistro in - f[0-9]*|centos[0-9]*|sl[0-9]*) echo yum ;; - squeeze|wheezy|jessie|oneiric|precise|quantal|raring|saucy|trusty|utopic) echo debootstrap ;; - *) echo Unknown distro $fcdistro ;; - esac + f[0-9]*|centos[0-9]*|sl[0-9]*) + echo yum ;; + wheezy|jessie|precise|trusty|utopic|vivid|wily|xenial) + echo debootstrap ;; + *) + echo Unknown distro $fcdistro ;; + esac } # return arch from debian distro and personality @@ -93,12 +105,12 @@ function canonical_arch () { } # the new test framework creates /timestamp in /vservers/ *before* populating it -function almost_empty () { - dir="$1"; shift ; +function almost_empty () { + dir="$1"; shift ; # non existing is fine - [ ! -d $dir ] && return 0; + [ ! -d $dir ] && return 0; # need to have at most one file - count=$(cd $dir; ls | wc -l); [ $count -le 1 ]; + count=$(cd $dir; ls | wc -l); [ $count -le 1 ]; } ############################## @@ -106,9 +118,12 @@ function fedora_install() { set -x set -e - cache=/var/cache/lxc/fedora/$arch/$release + lxc=$1; shift + lxc_root=$(lxcroot $lxc) + + cache=/var/cache/lxc/fedora/$arch/${fedora_release} mkdir -p $cache - + ( flock --exclusive --timeout 60 200 || { echo "Cache repository is busy." ; return 1 ; } @@ -117,7 +132,7 @@ function fedora_install() { fedora_download $cache || { echo "Failed to download 'fedora base'"; return 1; } else echo "Updating cache $cache/rootfs ..." - if ! yum --installroot $cache/rootfs -y --nogpgcheck update ; then + if ! yum --installroot $cache/rootfs --releasever ${fedora_release} -y --nogpgcheck update ; then echo "Failed to update 'fedora base', continuing with last known good cache" else echo "Update finished" @@ -126,7 +141,7 @@ function fedora_install() { echo "Filling $lxc_root from $cache/rootfs ... " rsync -a $cache/rootfs/ $lxc_root/ - + return 0 ) 200> $cache/lock @@ -148,7 +163,7 @@ function fedora_download() { mkdir -p $INSTALL_ROOT || { echo "Failed to create '$INSTALL_ROOT' directory" ; return 1; } - mkdir -p $INSTALL_ROOT/etc/yum.repos.d + mkdir -p $INSTALL_ROOT/etc/yum.repos.d mkdir -p $INSTALL_ROOT/dev mknod -m 0444 $INSTALL_ROOT/dev/random c 1 8 mknod -m 0444 $INSTALL_ROOT/dev/urandom c 1 9 @@ -157,19 +172,19 @@ function fedora_download() { cp /etc/yum.conf $INSTALL_ROOT/etc/ cp /etc/yum.repos.d/fedora* $INSTALL_ROOT/etc/yum.repos.d/ - # append fedora repo files with desired $release and $basearch + # append fedora repo files with desired ${fedora_release} and $basearch for f in $INSTALL_ROOT/etc/yum.repos.d/* ; do - sed -i "s/\$basearch/$arch/g; s/\$releasever/$release/g;" $f - done + sed -i "s/\$basearch/$arch/g; s/\$releasever/${fedora_release}/g;" $f + done - MIRROR_URL=$FEDORA_MIRROR_BASE/releases/$release/Everything/$arch/os - RELEASE_URL1="$MIRROR_URL/Packages/fedora-release-$release-1.noarch.rpm" + MIRROR_URL=$FEDORA_MIRROR_BASE/releases/${fedora_release}/Everything/$arch/os + RELEASE_URL1="$MIRROR_URL/Packages/fedora-release-${fedora_release}-1.noarch.rpm" # with fedora18 the rpms are scattered by first name # first try the second version of fedora-release first - RELEASE_URL2="$MIRROR_URL/Packages/f/fedora-release-$release-2.noarch.rpm" - RELEASE_URL3="$MIRROR_URL/Packages/f/fedora-release-$release-1.noarch.rpm" - - RELEASE_TARGET=$INSTALL_ROOT/fedora-release-$release.noarch.rpm + RELEASE_URL2="$MIRROR_URL/Packages/f/fedora-release-${fedora_release}-2.noarch.rpm" + RELEASE_URL3="$MIRROR_URL/Packages/f/fedora-release-${fedora_release}-1.noarch.rpm" + + RELEASE_TARGET=$INSTALL_ROOT/fedora-release-${fedora_release}.noarch.rpm found="" for attempt in $RELEASE_URL1 $RELEASE_URL2 $RELEASE_URL3; do if curl -f $attempt -o $RELEASE_TARGET ; then @@ -181,22 +196,22 @@ function fedora_download() { fi done [ -n "$found" ] || { echo "Could not retrieve fedora-release rpm - exiting" ; exit 1; } - + mkdir -p $INSTALL_ROOT/var/lib/rpm rpm --root $INSTALL_ROOT --initdb # when installing f12 this apparently is already present, so ignore result - rpm --root $INSTALL_ROOT -ivh $INSTALL_ROOT/fedora-release-$release.noarch.rpm || : + rpm --root $INSTALL_ROOT -ivh $INSTALL_ROOT/fedora-release-${fedora_release}.noarch.rpm || : # however f12 root images won't get created on a f18 host # (the issue here is the same as the one we ran into when dealing with a vs-box) # in a nutshell, in f12 the glibc-common and filesystem rpms have an apparent conflict - # >>> file /usr/lib/locale from install of glibc-common-2.11.2-3.x86_64 conflicts + # >>> file /usr/lib/locale from install of glibc-common-2.11.2-3.x86_64 conflicts # with file from package filesystem-2.4.30-2.fc12.x86_64 - # in fact this was - of course - allowed by f12's rpm but later on a fix was made + # in fact this was - of course - allowed by f12's rpm but later on a fix was made # http://rpm.org/gitweb?p=rpm.git;a=commitdiff;h=cf1095648194104a81a58abead05974a5bfa3b9a # So ideally if we want to be able to build f12 images from f18 we need an rpm that has # this patch undone, like we have in place on our f14 boxes (our f14 boxes need a f18-like rpm) - YUM="yum --installroot=$INSTALL_ROOT --nogpgcheck -y" + YUM="yum --installroot=$INSTALL_ROOT --releasever=${fedora_release} --nogpgcheck -y" echo "$YUM install $FEDORA_PREINSTALLED" $YUM install $FEDORA_PREINSTALLED || { echo "Failed to download rootfs, aborting." ; return 1; } @@ -212,12 +227,15 @@ function fedora_configure() { set -x set -e + lxc=$1; shift + lxc_root=$(lxcroot $lxc) + # disable selinux in fedora mkdir -p $lxc_root/selinux echo 0 > $lxc_root/selinux/enforce # set the hostname - case "$fcdistro" in + case "$fcdistro" in f18|f2?) cat < ${lxc_root}/etc/sysconfig/network NETWORKING=yes @@ -259,9 +277,9 @@ EOF mknod -m 666 ${dev_path}/ptmx c 5 2 if [ "$(echo $fcdistro | cut -d"f" -f2)" -le "14" ]; then - fedora_configure_init + fedora_configure_init $lxc else - fedora_configure_systemd + fedora_configure_systemd $lxc fi guest_ifcfg=${lxc_root}/etc/sysconfig/network-scripts/ifcfg-$VIF_GUEST @@ -275,6 +293,9 @@ EOF function fedora_configure_init() { set -e set -x + lxc=$1; shift + lxc_root=$(lxcroot $lxc) + sed -i 's|.sbin.start_udev||' ${lxc_root}/etc/rc.sysinit sed -i 's|.sbin.start_udev||' ${lxc_root}/etc/rc.d/rc.sysinit # don't mount devpts, for pete's sake @@ -288,7 +309,10 @@ function fedora_configure_init() { function fedora_configure_systemd() { set -e set -x - # so ignore if we can't find /etc/systemd at all + lxc=$1; shift + lxc_root=$(lxcroot $lxc) + + # so ignore if we can't find /etc/systemd at all [ -d ${lxc_root}/etc/systemd ] || return 0 # otherwise let's proceed ln -sf /lib/systemd/system/multi-user.target ${lxc_root}/etc/systemd/system/default.target @@ -305,14 +329,15 @@ function fedora_configure_systemd() { # overwrite container yum config function fedora_configure_yum () { - set -x - set -e + set -x + set -e trap failure ERR INT lxc=$1; shift fcdistro=$1; shift pldistro=$1; shift + lxc_root=$(lxcroot $lxc) # rpm --rebuilddb chroot ${lxc_root} $personality rpm --rebuilddb @@ -326,7 +351,7 @@ baseurl=$FEDORA_MIRROR_BASE/releases/\$releasever/Everything/\$basearch/os/ enabled=1 metadata_expire=7d gpgcheck=1 -gpgkey=$FEDORA_MIRROR_KEYS/RPM-GPG-KEY-fedora-$release-primary +gpgkey=$FEDORA_MIRROR_KEYS/RPM-GPG-KEY-fedora-${fedora_release}-primary [updates] name=Fedora \$releasever - \$basearch - Updates @@ -334,19 +359,23 @@ baseurl=$FEDORA_MIRROR_BASE/updates/\$releasever/\$basearch/ enabled=1 metadata_expire=7d gpgcheck=1 -gpgkey=$FEDORA_MIRROR_KEYS/RPM-GPG-KEY-fedora-$release-primary +gpgkey=$FEDORA_MIRROR_KEYS/RPM-GPG-KEY-fedora-${fedora_release}-primary EOF + # import fedora key so that gpgckeck does not whine or require stdin + # required since fedora24 + rpm --root $lxc_root --import $FEDORA_MIRROR_KEYS/RPM-GPG-KEY-fedora-${fedora_release}-primary + # for using this script as a general-purpose lxc creation wrapper # just mention 'none' as the repo url if [ -n "$REPO_URL" ] ; then if [ ! -d $lxc_root/etc/yum.repos.d ] ; then echo "WARNING : cannot create myplc repo" else - # exclude kernel from fedora repos + # exclude kernel from fedora repos yumexclude=$(pl_plcyumexclude $fcdistro $pldistro $DIRNAME) for repo in $lxc_root/etc/yum.repos.d/* ; do - [ -f $repo ] && yumconf_exclude $repo "exclude=$yumexclude" + [ -f $repo ] && yumconf_exclude $repo "exclude=$yumexclude" done # the build repo is not signed at this stage cat > $lxc_root/etc/yum.repos.d/myplc.repo < ${lxc_root}/etc/hostname $GUEST_HOSTNAME EOF - + } function debian_configure () { @@ -427,15 +460,22 @@ function setup_lxc() { pldistro=$1; shift personality=$1; shift - # create lxc container - + lxc_root=$(lxcroot $lxc) + + # create lxc container + pkg_method=$(package_method $fcdistro) case $pkg_method in yum) if [ -z "$IMAGE" ]; then - fedora_install || { echo "failed to install fedora root image"; exit 1 ; } + fedora_install $lxc || { echo "failed to install fedora root image"; exit 1 ; } + # this appears to be safer; observed in Jan. 2016 on a f23 host and a f14 cached image + # we were getting this message when attempting the first chroot yum install + # rpmdb: Program version 4.8 doesn't match environment version 5.3 + chroot $(lxcroot $lxc) $personality rm -rf /var/lib/rpm/__db.00{0,1,2,3,4,5,6,7,8,9} + chroot $(lxcroot $lxc) $personality rpm --rebuilddb fi - fedora_configure || { echo "failed to configure fedora for a container"; exit 1 ; } + fedora_configure $lxc || { echo "failed to configure fedora for a container"; exit 1 ; } ;; debootstrap) if [ -z "$IMAGE" ]; then @@ -451,14 +491,14 @@ function setup_lxc() { # Enable cgroup -- xxx -- is this really useful ? [ -d $lxc_root/cgroup ] || mkdir $lxc_root/cgroup - + ### set up resolv.conf from host # ubuntu precise and on, /etc/resolv.conf is a symlink to ../run/resolvconf/resolv.conf [ -h $lxc_root/etc/resolv.conf ] && rm -f $lxc_root/etc/resolv.conf cp /etc/resolv.conf $lxc_root/etc/resolv.conf ### and /etc/hosts for at least localhost [ -f $lxc_root/etc/hosts ] || echo "127.0.0.1 localhost localhost.localdomain" > $lxc_root/etc/hosts - + # grant ssh access from host to guest mkdir -p $lxc_root/root/.ssh cat /root/.ssh/id_rsa.pub >> $lxc_root/root/.ssh/authorized_keys @@ -468,7 +508,7 @@ function setup_lxc() { # don't keep the input xml, this can be retrieved at all times with virsh dumpxml config_xml=/tmp/$lxc.xml ( [ -n "$NAT_MODE" ] && write_lxc_xml_natip $lxc || write_lxc_xml_publicip $lxc ) > $config_xml - + # define lxc container for libvirt virsh -c lxc:/// define $config_xml @@ -486,6 +526,7 @@ function setup_lxc() { function write_lxc_xml_publicip () { lxc=$1; shift + lxc_root=$(lxcroot $lxc) cat < $lxc @@ -519,8 +560,9 @@ EOF } # grant build guests the ability to do mknods -function write_lxc_xml_natip () { +function write_lxc_xml_natip () { lxc=$1; shift + lxc_root=$(lxcroot $lxc) cat < $lxc @@ -585,8 +627,8 @@ EOF function devel_or_test_tools () { - set -x - set -e + set -x + set -e trap failure ERR INT lxc=$1; shift @@ -594,13 +636,15 @@ function devel_or_test_tools () { pldistro=$1; shift personality=$1; shift + lxc_root=$(lxcroot $lxc) + pkg_method=$(package_method $fcdistro) pkgsfile=$(pl_locateDistroFile $DIRNAME $pldistro $PREINSTALLED) ### install individual packages, then groups # get target arch - use uname -i here (we want either x86_64 or i386) - + lxc_arch=$(chroot ${lxc_root} $personality uname -i) # on debian systems we get arch through the 'arch' command [ "$lxc_arch" = "unknown" ] && lxc_arch=$(chroot ${lxc_root} $personality arch) @@ -610,10 +654,23 @@ function devel_or_test_tools () { case "$pkg_method" in yum) - [ -n "$packages" ] && chroot ${lxc_root} $personality yum -y install $packages + # --allowerasing required starting with fedora24 + # + has_dnf="" + chroot ${lxc_root} $personality dnf --version && has_dnf=true + if [ -n "$has_dnf" ]; then + echo "container has dnf - invoking with --allowerasing" + pkg_installer="dnf -y install --allowerasing" + grp_installer="dnf -y groupinstall --allowerasing" + else + echo "container has only yum" + pkg_installer="yum -y install" + grp_installer="yum -y groupinstall" + fi + [ -n "$packages" ] && chroot ${lxc_root} $personality $pkg_installer $packages for group_plus in $groups; do group=$(echo $group_plus | sed -e "s,+++, ,g") - chroot ${lxc_root} $personality yum -y groupinstall "$group" + chroot ${lxc_root} $personality $grp_installer "$group" done # store current rpm list in /init-lxc.rpms in case we need to check the contents chroot ${lxc_root} $personality rpm -aq > $lxc_root/init-lxc.rpms @@ -645,10 +702,12 @@ function devel_or_test_tools () { } function post_install () { - lxc=$1; shift + lxc=$1; shift personality=$1; shift + lxc_root=$(lxcroot $lxc) # setup localtime from the host cp /etc/localtime $lxc_root/etc/localtime + sshd_disable_password_auth $lxc # post install hook [ -n "$NAT_MODE" ] && post_install_natip $lxc $personality || post_install_myplc $lxc $personality # start the VM unless specified otherwise @@ -663,35 +722,45 @@ function post_install () { fi } +# just in case, let's stay on the safe side +function sshd_disable_password_auth () { + lxc=$1; shift + lxc_root=$(lxcroot $lxc) + sed --in-place=.password -e 's,^#\?PasswordAuthentication.*,PasswordAuthentication no,' \ + $lxc_root/etc/ssh/sshd_config +} + function post_install_natip () { - set -x - set -e + set -x + set -e trap failure ERR INT lxc=$1; shift personality=$1; shift + lxc_root=$(lxcroot $lxc) ### From myplc-devel-native.spec # be careful to backslash $ in this, otherwise it's the root context that's going to do the evaluation cat << EOF | chroot ${lxc_root} $personality bash -x - + # customize root's prompt /bin/cat << PROFILE > /root/.profile export PS1="[$lxc] \\w # " PROFILE EOF - + } function post_install_myplc () { - set -x - set -e + set -x + set -e trap failure ERR INT lxc=$1; shift personality=$1; shift + lxc_root=$(lxcroot $lxc) # be careful to backslash $ in this, otherwise it's the root context that's going to do the evaluation cat << EOF | chroot ${lxc_root} $personality bash -x @@ -733,16 +802,16 @@ function wait_for_ssh () { # if run in public_ip mode, we know the IP of the guest and it is specified here [ -n "$1" ] && { guest_ip=$1; shift; } - #wait max 2 min for sshd to start + #wait max 2 min for sshd to start success="" current_time=$(date +%s) stop_time=$(($current_time + 120)) - + counter=1 while [ "$current_time" -lt "$stop_time" ] ; do echo "$counter-th attempt to reach sshd in container $lxc ..." [ -z "$guest_ip" ] && guest_ip=$(guest_ipv4 $lxc) - [ -n "$guest_ip" ] && ssh -o "StrictHostKeyChecking no" $guest_ip 'uname -i' && { + [ -n "$guest_ip" ] && ssh -o "StrictHostKeyChecking no" $guest_ip 'uname -i' && { success=true; echo "SSHD in container $lxc is UP on IP $guest_ip"; break ; } || : counter=$(($counter+1)) sleep 10 @@ -750,7 +819,7 @@ function wait_for_ssh () { done # Thierry: this is fatal, let's just exit with a failure here - [ -z $success ] && { echo "SSHD in container $lxc could not be reached (guest_ip=$guest_ip)" ; exit 1 ; } + [ -z $success ] && { echo "SSHD in container $lxc could not be reached (guest_ip=$guest_ip)" ; exit 1 ; } return 0 } @@ -761,7 +830,7 @@ function failure () { } function usage () { - set +x + set +x echo "Usage: $COMMAND [options] lxc-name (aka build mode)" echo "Usage: $COMMAND -n hostname [options] lxc-name (aka test mode)" echo "Description:" @@ -784,7 +853,7 @@ function usage () { exit 1 } -### parse args and +### parse args and function main () { #set -e @@ -811,13 +880,13 @@ function main () { *) usage ;; esac done - + shift $(($OPTIND - 1)) # parse fixed arguments [[ -z "$@" ]] && usage lxc=$1 ; shift - lxc_root=/vservers/$lxc + lxc_root=$(lxcroot $lxc) # rainchecks almost_empty $lxc_root || \ @@ -833,7 +902,6 @@ function main () { rsync -a $IMAGE/ $lxc_root/ fi - # check we've exhausted the arguments [[ -n "$@" ]] && usage @@ -845,10 +913,10 @@ function main () { [ -z "$pldistro" ] && pldistro=$DEFAULT_PLDISTRO [ -z "$personality" ] && personality=$DEFAULT_PERSONALITY [ -z "$MEMORY" ] && MEMORY=$DEFAULT_MEMORY - + # set memory in KB MEMORY=$(($MEMORY * 1024)) - + # the set of preinstalled packages - depends on mode if [ -z "$PREINSTALLED" ] ; then if [ -n "$NAT_MODE" ] ; then @@ -868,12 +936,12 @@ function main () { if [ "$REPO_URL" == "none" ] ; then REPO_URL="" elif [ -z "$REPO_URL" ] ; then - echo "WARNING -- setting up a yum repo is recommended" + echo "WARNING -- setting up a yum repo is recommended" fi fi ########## - release=$(echo $fcdistro | cut -df -f2) + fedora_release=$(echo $fcdistro | cut -df -f2) if [ "$personality" == "linux32" ]; then arch=i386 @@ -900,7 +968,7 @@ function main () { VIF_HOST="vif$(echo $GUEST_HOSTNAME | cut -d. -f1)" fi - setup_lxc $lxc $fcdistro $pldistro $personality + setup_lxc $lxc $fcdistro $pldistro $personality # historically this command is for setting up a build or a test VM # kind of patchy right now though @@ -908,7 +976,7 @@ function main () { # container gets started here post_install $lxc $personality - + echo $COMMAND Done exit 0