X-Git-Url: http://git.onelab.eu/?a=blobdiff_plain;f=lib%2Fflow.c;h=c6683a515c12342bed44f049ad292ca7bde15807;hb=4905e2dfef440a2377cec934f3cfae62a3feee83;hp=5e7d1d47dacb5f094dbc550b77825b5e9306c32b;hpb=b02475c53b3ca857c45eb5e17d12fdf233a9dac8;p=sliver-openvswitch.git diff --git a/lib/flow.c b/lib/flow.c index 5e7d1d47d..c6683a515 100644 --- a/lib/flow.c +++ b/lib/flow.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 2008, 2009, 2010, 2011, 2012 Nicira, Inc. + * Copyright (c) 2008, 2009, 2010, 2011, 2012, 2013 Nicira, Inc. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -35,14 +35,20 @@ #include "ofpbuf.h" #include "openflow/openflow.h" #include "packets.h" +#include "random.h" #include "unaligned.h" -#include "vlog.h" - -VLOG_DEFINE_THIS_MODULE(flow); COVERAGE_DEFINE(flow_extract); COVERAGE_DEFINE(miniflow_malloc); +/* U32 indices for segmented flow classification. */ +const uint8_t flow_segment_u32s[4] = { + FLOW_SEGMENT_1_ENDS_AT / 4, + FLOW_SEGMENT_2_ENDS_AT / 4, + FLOW_SEGMENT_3_ENDS_AT / 4, + FLOW_U32S +}; + static struct arp_eth_header * pull_arp(struct ofpbuf *packet) { @@ -81,6 +87,12 @@ pull_udp(struct ofpbuf *packet) return ofpbuf_try_pull(packet, UDP_HEADER_LEN); } +static struct sctp_header * +pull_sctp(struct ofpbuf *packet) +{ + return ofpbuf_try_pull(packet, SCTP_HEADER_LEN); +} + static struct icmp_header * pull_icmp(struct ofpbuf *packet) { @@ -97,9 +109,11 @@ static void parse_mpls(struct ofpbuf *b, struct flow *flow) { struct mpls_hdr *mh; + bool top = true; while ((mh = ofpbuf_try_pull(b, sizeof *mh))) { - if (flow->mpls_depth++ == 0) { + if (top) { + top = false; flow->mpls_lse = mh->mpls_lse; } if (mh->mpls_lse & htonl(MPLS_BOS_MASK)) { @@ -147,13 +161,18 @@ parse_ethertype(struct ofpbuf *b) } ofpbuf_pull(b, sizeof *llc); - return llc->snap.snap_type; + + if (ntohs(llc->snap.snap_type) >= ETH_TYPE_MIN) { + return llc->snap.snap_type; + } + + return htons(FLOW_DL_TYPE_NONE); } static int parse_ipv6(struct ofpbuf *packet, struct flow *flow) { - const struct ip6_hdr *nh; + const struct ovs_16aligned_ip6_hdr *nh; ovs_be32 tc_flow; int nexthdr; @@ -164,10 +183,10 @@ parse_ipv6(struct ofpbuf *packet, struct flow *flow) nexthdr = nh->ip6_nxt; - flow->ipv6_src = nh->ip6_src; - flow->ipv6_dst = nh->ip6_dst; + memcpy(&flow->ipv6_src, &nh->ip6_src, sizeof flow->ipv6_src); + memcpy(&flow->ipv6_dst, &nh->ip6_dst, sizeof flow->ipv6_dst); - tc_flow = get_unaligned_be32(&nh->ip6_flow); + tc_flow = get_16aligned_be32(&nh->ip6_flow); flow->nw_tos = ntohl(tc_flow) >> 20; flow->ipv6_label = tc_flow & htonl(IPV6_LABEL_MASK); flow->nw_ttl = nh->ip6_hlim; @@ -215,7 +234,7 @@ parse_ipv6(struct ofpbuf *packet, struct flow *flow) return EINVAL; } } else if (nexthdr == IPPROTO_FRAGMENT) { - const struct ip6_frag *frag_hdr = packet->data; + const struct ovs_16aligned_ip6_frag *frag_hdr = packet->data; nexthdr = frag_hdr->ip6f_nxt; if (!ofpbuf_try_pull(packet, sizeof *frag_hdr)) { @@ -224,9 +243,8 @@ parse_ipv6(struct ofpbuf *packet, struct flow *flow) /* We only process the first fragment. */ if (frag_hdr->ip6f_offlg != htons(0)) { - if ((frag_hdr->ip6f_offlg & IP6F_OFF_MASK) == htons(0)) { - flow->nw_frag = FLOW_NW_FRAG_ANY; - } else { + flow->nw_frag = FLOW_NW_FRAG_ANY; + if ((frag_hdr->ip6f_offlg & IP6F_OFF_MASK) != htons(0)) { flow->nw_frag |= FLOW_NW_FRAG_LATER; nexthdr = IPPROTO_FRAGMENT; break; @@ -246,6 +264,7 @@ parse_tcp(struct ofpbuf *packet, struct ofpbuf *b, struct flow *flow) if (tcp) { flow->tp_src = tcp->tcp_src; flow->tp_dst = tcp->tcp_dst; + flow->tcp_flags = tcp->tcp_ctl & htons(0x0fff); packet->l7 = b->data; } } @@ -261,6 +280,17 @@ parse_udp(struct ofpbuf *packet, struct ofpbuf *b, struct flow *flow) } } +static void +parse_sctp(struct ofpbuf *packet, struct ofpbuf *b, struct flow *flow) +{ + const struct sctp_header *sctp = pull_sctp(b); + if (sctp) { + flow->tp_src = sctp->sctp_src; + flow->tp_dst = sctp->sctp_dst; + packet->l7 = b->data; + } +} + static bool parse_icmpv6(struct ofpbuf *b, struct flow *flow) { @@ -333,7 +363,7 @@ invalid: } /* Initializes 'flow' members from 'packet', 'skb_priority', 'tnl', and - * 'ofp_in_port'. + * 'in_port'. * * Initializes 'packet' header pointers as follows: * @@ -348,12 +378,12 @@ invalid: * - packet->l4 to just past the IPv4 header, if one is present and has a * correct length, and otherwise NULL. * - * - packet->l7 to just past the TCP or UDP or ICMP header, if one is + * - packet->l7 to just past the TCP/UDP/SCTP/ICMP header, if one is * present and has a correct length, and otherwise NULL. */ void -flow_extract(struct ofpbuf *packet, uint32_t skb_priority, uint32_t skb_mark, - const struct flow_tnl *tnl, uint16_t ofp_in_port, +flow_extract(struct ofpbuf *packet, uint32_t skb_priority, uint32_t pkt_mark, + const struct flow_tnl *tnl, const union flow_in_port *in_port, struct flow *flow) { struct ofpbuf b = *packet; @@ -367,9 +397,11 @@ flow_extract(struct ofpbuf *packet, uint32_t skb_priority, uint32_t skb_mark, ovs_assert(tnl != &flow->tunnel); flow->tunnel = *tnl; } - flow->in_port = ofp_in_port; + if (in_port) { + flow->in_port = *in_port; + } flow->skb_priority = skb_priority; - flow->skb_mark = skb_mark; + flow->pkt_mark = pkt_mark; packet->l2 = b.data; packet->l2_5 = NULL; @@ -399,39 +431,15 @@ flow_extract(struct ofpbuf *packet, uint32_t skb_priority, uint32_t skb_mark, parse_mpls(&b, flow); } - packet->l3 = b.data; - flow_extract_l3_onwards(packet, flow, flow->dl_type); -} - -/* Initializes l3 and higher 'flow' members from 'packet' - * - * This should be called by or after flow_extract() - * - * Initializes 'packet' header pointers as follows: - * - * - packet->l4 to just past the IPv4 header, if one is present and has a - * correct length, and otherwise NULL. - * - * - packet->l7 to just past the TCP or UDP or ICMP header, if one is - * present and has a correct length, and otherwise NULL. - */ -void -flow_extract_l3_onwards(struct ofpbuf *packet, struct flow *flow, - ovs_be16 dl_type) -{ - struct ofpbuf b; - - ofpbuf_use_const(&b, packet->l3, packet->size - - (size_t)((char *)packet->l3 - (char *)packet->l2)); - /* Network layer. */ - if (dl_type == htons(ETH_TYPE_IP)) { + packet->l3 = b.data; + if (flow->dl_type == htons(ETH_TYPE_IP)) { const struct ip_header *nh = pull_ip(&b); if (nh) { packet->l4 = b.data; - flow->nw_src = get_unaligned_be32(&nh->ip_src); - flow->nw_dst = get_unaligned_be32(&nh->ip_dst); + flow->nw_src = get_16aligned_be32(&nh->ip_src); + flow->nw_dst = get_16aligned_be32(&nh->ip_dst); flow->nw_proto = nh->ip_proto; flow->nw_tos = nh->ip_tos; @@ -448,6 +456,8 @@ flow_extract_l3_onwards(struct ofpbuf *packet, struct flow *flow, parse_tcp(packet, &b, flow); } else if (flow->nw_proto == IPPROTO_UDP) { parse_udp(packet, &b, flow); + } else if (flow->nw_proto == IPPROTO_SCTP) { + parse_sctp(packet, &b, flow); } else if (flow->nw_proto == IPPROTO_ICMP) { const struct icmp_header *icmp = pull_icmp(&b); if (icmp) { @@ -458,7 +468,7 @@ flow_extract_l3_onwards(struct ofpbuf *packet, struct flow *flow, } } } - } else if (dl_type == htons(ETH_TYPE_IPV6)) { + } else if (flow->dl_type == htons(ETH_TYPE_IPV6)) { if (parse_ipv6(&b, flow)) { return; } @@ -468,13 +478,15 @@ flow_extract_l3_onwards(struct ofpbuf *packet, struct flow *flow, parse_tcp(packet, &b, flow); } else if (flow->nw_proto == IPPROTO_UDP) { parse_udp(packet, &b, flow); + } else if (flow->nw_proto == IPPROTO_SCTP) { + parse_sctp(packet, &b, flow); } else if (flow->nw_proto == IPPROTO_ICMPV6) { if (parse_icmpv6(&b, flow)) { packet->l7 = b.data; } } - } else if (dl_type == htons(ETH_TYPE_ARP) || - dl_type == htons(ETH_TYPE_RARP)) { + } else if (flow->dl_type == htons(ETH_TYPE_ARP) || + flow->dl_type == htons(ETH_TYPE_RARP)) { const struct arp_eth_header *arp = pull_arp(&b); if (arp && arp->ar_hrd == htons(1) && arp->ar_pro == htons(ETH_TYPE_IP) @@ -485,8 +497,8 @@ flow_extract_l3_onwards(struct ofpbuf *packet, struct flow *flow, flow->nw_proto = ntohs(arp->ar_op); } - flow->nw_src = arp->ar_spa; - flow->nw_dst = arp->ar_tpa; + flow->nw_src = get_16aligned_be32(&arp->ar_spa); + flow->nw_dst = get_16aligned_be32(&arp->ar_tpa); memcpy(flow->arp_sha, arp->ar_sha, ETH_ADDR_LEN); memcpy(flow->arp_tha, arp->ar_tha, ETH_ADDR_LEN); } @@ -511,12 +523,15 @@ flow_zero_wildcards(struct flow *flow, const struct flow_wildcards *wildcards) void flow_get_metadata(const struct flow *flow, struct flow_metadata *fmd) { - BUILD_ASSERT_DECL(FLOW_WC_SEQ == 19); + BUILD_ASSERT_DECL(FLOW_WC_SEQ == 23); fmd->tun_id = flow->tunnel.tun_id; + fmd->tun_src = flow->tunnel.ip_src; + fmd->tun_dst = flow->tunnel.ip_dst; fmd->metadata = flow->metadata; memcpy(fmd->regs, flow->regs, sizeof fmd->regs); - fmd->in_port = flow->in_port; + fmd->pkt_mark = flow->pkt_mark; + fmd->in_port = flow->in_port.ofp_port; } char * @@ -597,15 +612,6 @@ flow_wildcards_init_catchall(struct flow_wildcards *wc) memset(&wc->masks, 0, sizeof wc->masks); } -/* Initializes 'wc' as an exact-match set of wildcards; that is, 'wc' does not - * wildcard any bits or fields. */ -void -flow_wildcards_init_exact(struct flow_wildcards *wc) -{ - memset(&wc->masks, 0xff, sizeof wc->masks); - memset(wc->masks.zeros, 0, sizeof wc->masks.zeros); -} - /* Returns true if 'wc' matches every packet, false if 'wc' fixes any bits or * fields. */ bool @@ -622,13 +628,13 @@ flow_wildcards_is_catchall(const struct flow_wildcards *wc) return true; } -/* Initializes 'dst' as the combination of wildcards in 'src1' and 'src2'. - * That is, a bit or a field is wildcarded in 'dst' if it is wildcarded in - * 'src1' or 'src2' or both. */ +/* Sets 'dst' as the bitwise AND of wildcards in 'src1' and 'src2'. + * That is, a bit or a field is wildcarded in 'dst' if it is wildcarded + * in 'src1' or 'src2' or both. */ void -flow_wildcards_combine(struct flow_wildcards *dst, - const struct flow_wildcards *src1, - const struct flow_wildcards *src2) +flow_wildcards_and(struct flow_wildcards *dst, + const struct flow_wildcards *src1, + const struct flow_wildcards *src2) { uint32_t *dst_u32 = (uint32_t *) &dst->masks; const uint32_t *src1_u32 = (const uint32_t *) &src1->masks; @@ -640,6 +646,83 @@ flow_wildcards_combine(struct flow_wildcards *dst, } } +/* Sets 'dst' as the bitwise OR of wildcards in 'src1' and 'src2'. That + * is, a bit or a field is wildcarded in 'dst' if it is neither + * wildcarded in 'src1' nor 'src2'. */ +void +flow_wildcards_or(struct flow_wildcards *dst, + const struct flow_wildcards *src1, + const struct flow_wildcards *src2) +{ + uint32_t *dst_u32 = (uint32_t *) &dst->masks; + const uint32_t *src1_u32 = (const uint32_t *) &src1->masks; + const uint32_t *src2_u32 = (const uint32_t *) &src2->masks; + size_t i; + + for (i = 0; i < FLOW_U32S; i++) { + dst_u32[i] = src1_u32[i] | src2_u32[i]; + } +} + +/* Perform a bitwise OR of miniflow 'src' flow data with the equivalent + * fields in 'dst', storing the result in 'dst'. */ +static void +flow_union_with_miniflow(struct flow *dst, const struct miniflow *src) +{ + uint32_t *dst_u32 = (uint32_t *) dst; + const uint32_t *p = src->values; + uint64_t map; + + for (map = src->map; map; map = zero_rightmost_1bit(map)) { + dst_u32[raw_ctz(map)] |= *p++; + } +} + +/* Fold minimask 'mask''s wildcard mask into 'wc's wildcard mask. */ +void +flow_wildcards_fold_minimask(struct flow_wildcards *wc, + const struct minimask *mask) +{ + flow_union_with_miniflow(&wc->masks, &mask->masks); +} + +inline uint64_t +miniflow_get_map_in_range(const struct miniflow *miniflow, + uint8_t start, uint8_t end, const uint32_t **data) +{ + uint64_t map = miniflow->map; + uint32_t *p = miniflow->values; + + if (start > 0) { + uint64_t msk = (UINT64_C(1) << start) - 1; /* 'start' LSBs set */ + p += count_1bits(map & msk); /* Skip to start. */ + map &= ~msk; + } + if (end < FLOW_U32S) { + uint64_t msk = (UINT64_C(1) << end) - 1; /* 'end' LSBs set */ + map &= msk; + } + + *data = p; + return map; +} + +/* Fold minimask 'mask''s wildcard mask into 'wc's wildcard mask + * in range [start, end). */ +void +flow_wildcards_fold_minimask_range(struct flow_wildcards *wc, + const struct minimask *mask, + uint8_t start, uint8_t end) +{ + uint32_t *dst_u32 = (uint32_t *)&wc->masks; + const uint32_t *p; + uint64_t map = miniflow_get_map_in_range(&mask->masks, start, end, &p); + + for (; map; map = zero_rightmost_1bit(map)) { + dst_u32[raw_ctz(map)] |= *p++; + } +} + /* Returns a hash of the wildcards in 'wc'. */ uint32_t flow_wildcards_hash(const struct flow_wildcards *wc, uint32_t basis) @@ -731,7 +814,7 @@ flow_hash_symmetric_l4(const struct flow *flow, uint32_t basis) if (fields.eth_type == htons(ETH_TYPE_IP)) { fields.ipv4_addr = flow->nw_src ^ flow->nw_dst; fields.ip_proto = flow->nw_proto; - if (fields.ip_proto == IPPROTO_TCP) { + if (fields.ip_proto == IPPROTO_TCP || fields.ip_proto == IPPROTO_SCTP) { fields.tp_port = flow->tp_src ^ flow->tp_dst; } } else if (fields.eth_type == htons(ETH_TYPE_IPV6)) { @@ -743,13 +826,86 @@ flow_hash_symmetric_l4(const struct flow *flow, uint32_t basis) ipv6_addr[i] = a[i] ^ b[i]; } fields.ip_proto = flow->nw_proto; - if (fields.ip_proto == IPPROTO_TCP) { + if (fields.ip_proto == IPPROTO_TCP || fields.ip_proto == IPPROTO_SCTP) { fields.tp_port = flow->tp_src ^ flow->tp_dst; } } return jhash_bytes(&fields, sizeof fields, basis); } +/* Initialize a flow with random fields that matter for nx_hash_fields. */ +void +flow_random_hash_fields(struct flow *flow) +{ + uint16_t rnd = random_uint16(); + + /* Initialize to all zeros. */ + memset(flow, 0, sizeof *flow); + + eth_addr_random(flow->dl_src); + eth_addr_random(flow->dl_dst); + + flow->vlan_tci = (OVS_FORCE ovs_be16) (random_uint16() & VLAN_VID_MASK); + + /* Make most of the random flows IPv4, some IPv6, and rest random. */ + flow->dl_type = rnd < 0x8000 ? htons(ETH_TYPE_IP) : + rnd < 0xc000 ? htons(ETH_TYPE_IPV6) : (OVS_FORCE ovs_be16)rnd; + + if (dl_type_is_ip_any(flow->dl_type)) { + if (flow->dl_type == htons(ETH_TYPE_IP)) { + flow->nw_src = (OVS_FORCE ovs_be32)random_uint32(); + flow->nw_dst = (OVS_FORCE ovs_be32)random_uint32(); + } else { + random_bytes(&flow->ipv6_src, sizeof flow->ipv6_src); + random_bytes(&flow->ipv6_dst, sizeof flow->ipv6_dst); + } + /* Make most of IP flows TCP, some UDP or SCTP, and rest random. */ + rnd = random_uint16(); + flow->nw_proto = rnd < 0x8000 ? IPPROTO_TCP : + rnd < 0xc000 ? IPPROTO_UDP : + rnd < 0xd000 ? IPPROTO_SCTP : (uint8_t)rnd; + if (flow->nw_proto == IPPROTO_TCP || + flow->nw_proto == IPPROTO_UDP || + flow->nw_proto == IPPROTO_SCTP) { + flow->tp_src = (OVS_FORCE ovs_be16)random_uint16(); + flow->tp_dst = (OVS_FORCE ovs_be16)random_uint16(); + } + } +} + +/* Masks the fields in 'wc' that are used by the flow hash 'fields'. */ +void +flow_mask_hash_fields(const struct flow *flow, struct flow_wildcards *wc, + enum nx_hash_fields fields) +{ + switch (fields) { + case NX_HASH_FIELDS_ETH_SRC: + memset(&wc->masks.dl_src, 0xff, sizeof wc->masks.dl_src); + break; + + case NX_HASH_FIELDS_SYMMETRIC_L4: + memset(&wc->masks.dl_src, 0xff, sizeof wc->masks.dl_src); + memset(&wc->masks.dl_dst, 0xff, sizeof wc->masks.dl_dst); + if (flow->dl_type == htons(ETH_TYPE_IP)) { + memset(&wc->masks.nw_src, 0xff, sizeof wc->masks.nw_src); + memset(&wc->masks.nw_dst, 0xff, sizeof wc->masks.nw_dst); + } else if (flow->dl_type == htons(ETH_TYPE_IPV6)) { + memset(&wc->masks.ipv6_src, 0xff, sizeof wc->masks.ipv6_src); + memset(&wc->masks.ipv6_dst, 0xff, sizeof wc->masks.ipv6_dst); + } + if (is_ip_any(flow)) { + memset(&wc->masks.nw_proto, 0xff, sizeof wc->masks.nw_proto); + memset(&wc->masks.tp_src, 0xff, sizeof wc->masks.tp_src); + memset(&wc->masks.tp_dst, 0xff, sizeof wc->masks.tp_dst); + } + wc->masks.vlan_tci |= htons(VLAN_VID_MASK | VLAN_CFI); + break; + + default: + NOT_REACHED(); + } +} + /* Hashes the portions of 'flow' designated by 'fields'. */ uint32_t flow_hash_fields(const struct flow *flow, enum nx_hash_fields fields, @@ -786,6 +942,24 @@ flow_hash_fields_valid(enum nx_hash_fields fields) || fields == NX_HASH_FIELDS_SYMMETRIC_L4; } +/* Returns a hash value for the bits of 'flow' that are active based on + * 'wc', given 'basis'. */ +uint32_t +flow_hash_in_wildcards(const struct flow *flow, + const struct flow_wildcards *wc, uint32_t basis) +{ + const uint32_t *wc_u32 = (const uint32_t *) &wc->masks; + const uint32_t *flow_u32 = (const uint32_t *) flow; + uint32_t hash; + size_t i; + + hash = basis; + for (i = 0; i < FLOW_U32S; i++) { + hash = mhash_add(hash, flow_u32[i] & wc_u32[i]); + } + return mhash_finish(hash, 4 * FLOW_U32S); +} + /* Sets the VLAN VID that 'flow' matches to 'vid', which is interpreted as an * OpenFlow 1.0 "dl_vlan" value: * @@ -843,6 +1017,14 @@ flow_set_mpls_label(struct flow *flow, ovs_be32 label) set_mpls_lse_label(&flow->mpls_lse, label); } +/* Sets the MPLS TTL that 'flow' matches to 'ttl', which should be in the + * range 0...255. */ +void +flow_set_mpls_ttl(struct flow *flow, uint8_t ttl) +{ + set_mpls_lse_ttl(&flow->mpls_lse, ttl); +} + /* Sets the MPLS TC that 'flow' matches to 'tc', which should be in the * range 0...7. */ void @@ -867,9 +1049,6 @@ flow_set_mpls_bos(struct flow *flow, uint8_t bos) void flow_compose(struct ofpbuf *b, const struct flow *flow) { - ovs_be16 inner_dl_type; - - inner_dl_type = flow_innermost_dl_type(flow); eth_compose(b, flow->dl_dst, flow->dl_src, ntohs(flow->dl_type), 0); if (flow->dl_type == htons(FLOW_DL_TYPE_NONE)) { struct eth_header *eth = b->l2; @@ -881,7 +1060,7 @@ flow_compose(struct ofpbuf *b, const struct flow *flow) eth_push_vlan(b, flow->vlan_tci); } - if (inner_dl_type == htons(ETH_TYPE_IP)) { + if (flow->dl_type == htons(ETH_TYPE_IP)) { struct ip_header *ip; b->l3 = ip = ofpbuf_put_zeros(b, sizeof *ip); @@ -889,8 +1068,8 @@ flow_compose(struct ofpbuf *b, const struct flow *flow) ip->ip_tos = flow->nw_tos; ip->ip_ttl = flow->nw_ttl; ip->ip_proto = flow->nw_proto; - ip->ip_src = flow->nw_src; - ip->ip_dst = flow->nw_dst; + put_16aligned_be32(&ip->ip_src, flow->nw_src); + put_16aligned_be32(&ip->ip_dst, flow->nw_dst); if (flow->nw_frag & FLOW_NW_FRAG_ANY) { ip->ip_frag_off |= htons(IP_MORE_FRAGMENTS); @@ -906,13 +1085,19 @@ flow_compose(struct ofpbuf *b, const struct flow *flow) b->l4 = tcp = ofpbuf_put_zeros(b, sizeof *tcp); tcp->tcp_src = flow->tp_src; tcp->tcp_dst = flow->tp_dst; - tcp->tcp_ctl = TCP_CTL(0, 5); + tcp->tcp_ctl = TCP_CTL(ntohs(flow->tcp_flags), 5); } else if (flow->nw_proto == IPPROTO_UDP) { struct udp_header *udp; b->l4 = udp = ofpbuf_put_zeros(b, sizeof *udp); udp->udp_src = flow->tp_src; udp->udp_dst = flow->tp_dst; + } else if (flow->nw_proto == IPPROTO_SCTP) { + struct sctp_header *sctp; + + b->l4 = sctp = ofpbuf_put_zeros(b, sizeof *sctp); + sctp->sctp_src = flow->tp_src; + sctp->sctp_dst = flow->tp_dst; } else if (flow->nw_proto == IPPROTO_ICMP) { struct icmp_header *icmp; @@ -921,16 +1106,17 @@ flow_compose(struct ofpbuf *b, const struct flow *flow) icmp->icmp_code = ntohs(flow->tp_dst); icmp->icmp_csum = csum(icmp, ICMP_HEADER_LEN); } + b->l7 = ofpbuf_tail(b); } ip = b->l3; ip->ip_tot_len = htons((uint8_t *) b->data + b->size - (uint8_t *) b->l3); ip->ip_csum = csum(ip, sizeof *ip); - } else if (inner_dl_type == htons(ETH_TYPE_IPV6)) { + } else if (flow->dl_type == htons(ETH_TYPE_IPV6)) { /* XXX */ - } else if (inner_dl_type == htons(ETH_TYPE_ARP) || - inner_dl_type == htons(ETH_TYPE_RARP)) { + } else if (flow->dl_type == htons(ETH_TYPE_ARP) || + flow->dl_type == htons(ETH_TYPE_RARP)) { struct arp_eth_header *arp; b->l3 = arp = ofpbuf_put_zeros(b, sizeof *arp); @@ -942,8 +1128,8 @@ flow_compose(struct ofpbuf *b, const struct flow *flow) if (flow->nw_proto == ARP_OP_REQUEST || flow->nw_proto == ARP_OP_REPLY) { - arp->ar_spa = flow->nw_src; - arp->ar_tpa = flow->nw_dst; + put_16aligned_be32(&arp->ar_spa, flow->nw_src); + put_16aligned_be32(&arp->ar_tpa, flow->nw_dst); memcpy(arp->ar_sha, flow->arp_sha, ETH_ADDR_LEN); memcpy(arp->ar_tha, flow->arp_tha, ETH_ADDR_LEN); } @@ -960,13 +1146,7 @@ flow_compose(struct ofpbuf *b, const struct flow *flow) static int miniflow_n_values(const struct miniflow *flow) { - int n, i; - - n = 0; - for (i = 0; i < MINI_N_MAPS; i++) { - n += popcount(flow->map[i]); - } - return n; + return count_1bits(flow->map); } static uint32_t * @@ -980,36 +1160,59 @@ miniflow_alloc_values(struct miniflow *flow, int n) } } +/* Completes an initialization of 'dst' as a miniflow copy of 'src' begun by + * the caller. The caller must have already initialized 'dst->map' properly + * to indicate the nonzero uint32_t elements of 'src'. 'n' must be the number + * of 1-bits in 'dst->map'. + * + * This function initializes 'dst->values' (either inline if possible or with + * malloc() otherwise) and copies the nonzero uint32_t elements of 'src' into + * it. */ +static void +miniflow_init__(struct miniflow *dst, const struct flow *src, int n) +{ + const uint32_t *src_u32 = (const uint32_t *) src; + unsigned int ofs; + uint64_t map; + + dst->values = miniflow_alloc_values(dst, n); + ofs = 0; + for (map = dst->map; map; map = zero_rightmost_1bit(map)) { + dst->values[ofs++] = src_u32[raw_ctz(map)]; + } +} + /* Initializes 'dst' as a copy of 'src'. The caller must eventually free 'dst' * with miniflow_destroy(). */ void miniflow_init(struct miniflow *dst, const struct flow *src) { const uint32_t *src_u32 = (const uint32_t *) src; - unsigned int ofs; unsigned int i; int n; /* Initialize dst->map, counting the number of nonzero elements. */ n = 0; - memset(dst->map, 0, sizeof dst->map); + dst->map = 0; + for (i = 0; i < FLOW_U32S; i++) { if (src_u32[i]) { - dst->map[i / 32] |= 1u << (i % 32); + dst->map |= UINT64_C(1) << i; n++; } } - /* Initialize dst->values. */ - dst->values = miniflow_alloc_values(dst, n); - ofs = 0; - for (i = 0; i < MINI_N_MAPS; i++) { - uint32_t map; + miniflow_init__(dst, src, n); +} - for (map = dst->map[i]; map; map = zero_rightmost_1bit(map)) { - dst->values[ofs++] = src_u32[raw_ctz(map) + i * 32]; - } - } +/* Initializes 'dst' as a copy of 'src', using 'mask->map' as 'dst''s map. The + * caller must eventually free 'dst' with miniflow_destroy(). */ +void +miniflow_init_with_minimask(struct miniflow *dst, const struct flow *src, + const struct minimask *mask) +{ + dst->map = mask->masks.map; + miniflow_init__(dst, src, miniflow_n_values(dst)); } /* Initializes 'dst' as a copy of 'src'. The caller must eventually free 'dst' @@ -1018,11 +1221,26 @@ void miniflow_clone(struct miniflow *dst, const struct miniflow *src) { int n = miniflow_n_values(src); - memcpy(dst->map, src->map, sizeof dst->map); + dst->map = src->map; dst->values = miniflow_alloc_values(dst, n); memcpy(dst->values, src->values, n * sizeof *dst->values); } +/* Initializes 'dst' with the data in 'src', destroying 'src'. + * The caller must eventually free 'dst' with miniflow_destroy(). */ +void +miniflow_move(struct miniflow *dst, struct miniflow *src) +{ + if (src->values == src->inline_values) { + dst->values = dst->inline_values; + memcpy(dst->values, src->values, + miniflow_n_values(src) * sizeof *dst->values); + } else { + dst->values = src->values; + } + dst->map = src->map; +} + /* Frees any memory owned by 'flow'. Does not free the storage in which 'flow' * itself resides; the caller is responsible for that. */ void @@ -1037,40 +1255,19 @@ miniflow_destroy(struct miniflow *flow) void miniflow_expand(const struct miniflow *src, struct flow *dst) { - uint32_t *dst_u32 = (uint32_t *) dst; - int ofs; - int i; - - memset(dst_u32, 0, sizeof *dst); - - ofs = 0; - for (i = 0; i < MINI_N_MAPS; i++) { - uint32_t map; - - for (map = src->map[i]; map; map = zero_rightmost_1bit(map)) { - dst_u32[raw_ctz(map) + i * 32] = src->values[ofs++]; - } - } + memset(dst, 0, sizeof *dst); + flow_union_with_miniflow(dst, src); } static const uint32_t * miniflow_get__(const struct miniflow *flow, unsigned int u32_ofs) { - if (!(flow->map[u32_ofs / 32] & (1u << (u32_ofs % 32)))) { + if (!(flow->map & (UINT64_C(1) << u32_ofs))) { static const uint32_t zero = 0; return &zero; - } else { - const uint32_t *p = flow->values; - - BUILD_ASSERT(MINI_N_MAPS == 2); - if (u32_ofs < 32) { - p += popcount(flow->map[0] & ((1u << u32_ofs) - 1)); - } else { - p += popcount(flow->map[0]); - p += popcount(flow->map[1] & ((1u << (u32_ofs - 32)) - 1)); - } - return p; } + return flow->values + + count_1bits(flow->map & ((UINT64_C(1) << u32_ofs) - 1)); } /* Returns the uint32_t that would be at byte offset '4 * u32_ofs' if 'flow' @@ -1104,16 +1301,31 @@ miniflow_get_vid(const struct miniflow *flow) bool miniflow_equal(const struct miniflow *a, const struct miniflow *b) { - int i; + const uint32_t *ap = a->values; + const uint32_t *bp = b->values; + const uint64_t a_map = a->map; + const uint64_t b_map = b->map; + uint64_t map; - for (i = 0; i < MINI_N_MAPS; i++) { - if (a->map[i] != b->map[i]) { - return false; + if (a_map == b_map) { + for (map = a_map; map; map = zero_rightmost_1bit(map)) { + if (*ap++ != *bp++) { + return false; + } + } + } else { + for (map = a_map | b_map; map; map = zero_rightmost_1bit(map)) { + uint64_t bit = rightmost_1bit(map); + uint64_t a_value = a_map & bit ? *ap++ : 0; + uint64_t b_value = b_map & bit ? *bp++ : 0; + + if (a_value != b_value) { + return false; + } } } - return !memcmp(a->values, b->values, - miniflow_n_values(a) * sizeof *a->values); + return true; } /* Returns true if 'a' and 'b' are equal at the places where there are 1-bits @@ -1123,20 +1335,17 @@ miniflow_equal_in_minimask(const struct miniflow *a, const struct miniflow *b, const struct minimask *mask) { const uint32_t *p; - int i; + uint64_t map; p = mask->masks.values; - for (i = 0; i < MINI_N_MAPS; i++) { - uint32_t map; - for (map = mask->masks.map[i]; map; map = zero_rightmost_1bit(map)) { - int ofs = raw_ctz(map) + i * 32; + for (map = mask->masks.map; map; map = zero_rightmost_1bit(map)) { + int ofs = raw_ctz(map); - if ((miniflow_get(a, ofs) ^ miniflow_get(b, ofs)) & *p) { - return false; - } - p++; + if ((miniflow_get(a, ofs) ^ miniflow_get(b, ofs)) & *p) { + return false; } + p++; } return true; @@ -1150,20 +1359,17 @@ miniflow_equal_flow_in_minimask(const struct miniflow *a, const struct flow *b, { const uint32_t *b_u32 = (const uint32_t *) b; const uint32_t *p; - int i; + uint64_t map; p = mask->masks.values; - for (i = 0; i < MINI_N_MAPS; i++) { - uint32_t map; - for (map = mask->masks.map[i]; map; map = zero_rightmost_1bit(map)) { - int ofs = raw_ctz(map) + i * 32; + for (map = mask->masks.map; map; map = zero_rightmost_1bit(map)) { + int ofs = raw_ctz(map); - if ((miniflow_get(a, ofs) ^ b_u32[ofs]) & *p) { - return false; - } - p++; + if ((miniflow_get(a, ofs) ^ b_u32[ofs]) & *p) { + return false; } + p++; } return true; @@ -1173,10 +1379,22 @@ miniflow_equal_flow_in_minimask(const struct miniflow *a, const struct flow *b, uint32_t miniflow_hash(const struct miniflow *flow, uint32_t basis) { - BUILD_ASSERT_DECL(MINI_N_MAPS == 2); - return hash_3words(flow->map[0], flow->map[1], - hash_words(flow->values, miniflow_n_values(flow), - basis)); + const uint32_t *p = flow->values; + uint32_t hash = basis; + uint64_t hash_map = 0; + uint64_t map; + + for (map = flow->map; map; map = zero_rightmost_1bit(map)) { + if (*p) { + hash = mhash_add(hash, *p); + hash_map |= rightmost_1bit(map); + } + p++; + } + hash = mhash_add(hash, hash_map); + hash = mhash_add(hash, hash_map >> 32); + + return mhash_finish(hash, p - flow->values); } /* Returns a hash value for the bits of 'flow' where there are 1-bits in @@ -1190,18 +1408,16 @@ miniflow_hash_in_minimask(const struct miniflow *flow, { const uint32_t *p = mask->masks.values; uint32_t hash; - int i; + uint64_t map; hash = basis; - for (i = 0; i < MINI_N_MAPS; i++) { - uint32_t map; - - for (map = mask->masks.map[i]; map; map = zero_rightmost_1bit(map)) { - int ofs = raw_ctz(map) + i * 32; + for (map = mask->masks.map; map; map = zero_rightmost_1bit(map)) { + if (*p) { + int ofs = raw_ctz(map); hash = mhash_add(hash, miniflow_get(flow, ofs) & *p); - p++; } + p++; } return mhash_finish(hash, (p - mask->masks.values) * 4); @@ -1216,25 +1432,48 @@ uint32_t flow_hash_in_minimask(const struct flow *flow, const struct minimask *mask, uint32_t basis) { - const uint32_t *flow_u32 = (const uint32_t *) flow; + const uint32_t *flow_u32 = (const uint32_t *)flow; const uint32_t *p = mask->masks.values; uint32_t hash; - int i; + uint64_t map; hash = basis; - for (i = 0; i < MINI_N_MAPS; i++) { - uint32_t map; + for (map = mask->masks.map; map; map = zero_rightmost_1bit(map)) { + if (*p) { + hash = mhash_add(hash, flow_u32[raw_ctz(map)] & *p); + } + p++; + } - for (map = mask->masks.map[i]; map; map = zero_rightmost_1bit(map)) { - int ofs = raw_ctz(map) + i * 32; + return mhash_finish(hash, (p - mask->masks.values) * 4); +} - hash = mhash_add(hash, flow_u32[ofs] & *p); - p++; +/* Returns a hash value for the bits of range [start, end) in 'flow', + * where there are 1-bits in 'mask', given 'hash'. + * + * The hash values returned by this function are the same as those returned by + * minimatch_hash_range(), only the form of the arguments differ. */ +uint32_t +flow_hash_in_minimask_range(const struct flow *flow, + const struct minimask *mask, + uint8_t start, uint8_t end, uint32_t *basis) +{ + const uint32_t *flow_u32 = (const uint32_t *)flow; + const uint32_t *p; + uint64_t map = miniflow_get_map_in_range(&mask->masks, start, end, &p); + uint32_t hash = *basis; + + for (; map; map = zero_rightmost_1bit(map)) { + if (*p) { + hash = mhash_add(hash, flow_u32[raw_ctz(map)] & *p); } + p++; } + *basis = hash; /* Allow continuation from the unfinished value. */ return mhash_finish(hash, (p - mask->masks.values) * 4); } + /* Initializes 'dst' as a copy of 'src'. The caller must eventually free 'dst' * with minimask_destroy(). */ @@ -1252,6 +1491,14 @@ minimask_clone(struct minimask *dst, const struct minimask *src) miniflow_clone(&dst->masks, &src->masks); } +/* Initializes 'dst' with the data in 'src', destroying 'src'. + * The caller must eventually free 'dst' with minimask_destroy(). */ +void +minimask_move(struct minimask *dst, struct minimask *src) +{ + miniflow_move(&dst->masks, &src->masks); +} + /* Initializes 'dst_' as the bit-wise "and" of 'a_' and 'b_'. * * The caller must provide room for FLOW_U32S "uint32_t"s in 'storage', for use @@ -1264,23 +1511,19 @@ minimask_combine(struct minimask *dst_, struct miniflow *dst = &dst_->masks; const struct miniflow *a = &a_->masks; const struct miniflow *b = &b_->masks; - int i, n; + uint64_t map; + int n = 0; - n = 0; dst->values = storage; - for (i = 0; i < MINI_N_MAPS; i++) { - uint32_t map; - - dst->map[i] = 0; - for (map = a->map[i] & b->map[i]; map; - map = zero_rightmost_1bit(map)) { - int ofs = raw_ctz(map) + i * 32; - uint32_t mask = miniflow_get(a, ofs) & miniflow_get(b, ofs); - - if (mask) { - dst->map[i] |= rightmost_1bit(map); - dst->values[n++] = mask; - } + + dst->map = 0; + for (map = a->map & b->map; map; map = zero_rightmost_1bit(map)) { + int ofs = raw_ctz(map); + uint32_t mask = miniflow_get(a, ofs) & miniflow_get(b, ofs); + + if (mask) { + dst->map |= rightmost_1bit(map); + dst->values[n++] = mask; } } } @@ -1337,20 +1580,15 @@ minimask_has_extra(const struct minimask *a_, const struct minimask *b_) { const struct miniflow *a = &a_->masks; const struct miniflow *b = &b_->masks; - int i; - - for (i = 0; i < MINI_N_MAPS; i++) { - uint32_t map; + uint64_t map; - for (map = a->map[i] | b->map[i]; map; - map = zero_rightmost_1bit(map)) { - int ofs = raw_ctz(map) + i * 32; - uint32_t a_u32 = miniflow_get(a, ofs); - uint32_t b_u32 = miniflow_get(b, ofs); + for (map = a->map | b->map; map; map = zero_rightmost_1bit(map)) { + int ofs = raw_ctz(map); + uint32_t a_u32 = miniflow_get(a, ofs); + uint32_t b_u32 = miniflow_get(b, ofs); - if ((a_u32 & b_u32) != b_u32) { - return true; - } + if ((a_u32 & b_u32) != b_u32) { + return true; } } @@ -1363,7 +1601,13 @@ bool minimask_is_catchall(const struct minimask *mask_) { const struct miniflow *mask = &mask_->masks; + const uint32_t *p = mask->values; + uint64_t map; - BUILD_ASSERT(MINI_N_MAPS == 2); - return !(mask->map[0] | mask->map[1]); + for (map = mask->map; map; map = zero_rightmost_1bit(map)) { + if (*p++) { + return false; + } + } + return true; }