X-Git-Url: http://git.onelab.eu/?a=blobdiff_plain;f=lib%2Fmultipath.c;h=e85829a0619ed114ff3b77330b728c912524fd7f;hb=refs%2Fheads%2Freview;hp=96845563b908ea55c03571dd34a9be85c703dfad;hpb=72c644fd6de23d69f66b755237e3f5c74b4d9af7;p=sliver-openvswitch.git diff --git a/lib/multipath.c b/lib/multipath.c index 96845563b..e85829a06 100644 --- a/lib/multipath.c +++ b/lib/multipath.c @@ -38,9 +38,11 @@ multipath_check(const struct nx_action_multipath *mp, const struct flow *flow) { uint32_t n_links = ntohs(mp->max_link) + 1; size_t min_n_bits = log_2_floor(n_links) + 1; + int ofs = nxm_decode_ofs(mp->ofs_nbits); + int n_bits = nxm_decode_n_bits(mp->ofs_nbits); int error; - error = nxm_dst_check(mp->dst, mp->ofs_nbits, min_n_bits, flow); + error = nxm_dst_check(mp->dst, ofs, n_bits, flow); if (error) { return error; } @@ -53,6 +55,9 @@ multipath_check(const struct nx_action_multipath *mp, const struct flow *flow) && mp->algorithm != htons(NX_MP_ALG_ITER_HASH)) { VLOG_WARN_RL(&rl, "unsupported algorithm %"PRIu16, ntohs(mp->algorithm)); + } else if (n_bits < min_n_bits) { + VLOG_WARN_RL(&rl, "multipath action requires at least %zu bits for " + "%"PRIu32" links", min_n_bits, n_links); } else { return 0; }