X-Git-Url: http://git.onelab.eu/?a=blobdiff_plain;f=lib%2Fofpbuf.c;h=29698dcd83beefdedb2ba985f4305e63a9eaa4d9;hb=6c0386119d614d5e26ca08cc3d8e527806b87ef9;hp=8191c87b7ef47b269df227e62ee0473b5f5dfc08;hpb=0dce369bdd8bf47895e59277bcbf77b74af20446;p=sliver-openvswitch.git diff --git a/lib/ofpbuf.c b/lib/ofpbuf.c index 8191c87b7..29698dcd8 100644 --- a/lib/ofpbuf.c +++ b/lib/ofpbuf.c @@ -1,5 +1,5 @@ /* - * Copyright (c) 2008, 2009, 2010 Nicira Networks. + * Copyright (c) 2008, 2009, 2010, 2011 Nicira Networks. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -47,9 +47,9 @@ ofpbuf_use(struct ofpbuf *b, void *base, size_t allocated) /* Initializes 'b' as an empty ofpbuf that contains the 'allocated' bytes of * memory starting at 'base'. 'base' should point to a buffer on the stack. - * If 'b' is resized, new memory will be allocated with malloc() and 'base' - * will not be freed. This is useful when a small stack-allocated buffer is - * normally appropriate but sometimes it must be expanded. + * + * An ofpbuf operation that requires reallocating data will assert-fail if this + * function was used to initialize it. * * 'base' should be appropriately aligned. Using an array of uint32_t or * uint64_t for the buffer is a reasonable way to ensure appropriate alignment @@ -74,7 +74,7 @@ ofpbuf_use_stack(struct ofpbuf *b, void *base, size_t allocated) void ofpbuf_use_const(struct ofpbuf *b, const void *data, size_t size) { - ofpbuf_use__(b, (void *) data, size, OFPBUF_CONST); + ofpbuf_use__(b, (void *) data, size, OFPBUF_STACK); b->size = size; } @@ -123,10 +123,13 @@ ofpbuf_new_with_headroom(size_t size, size_t headroom) return b; } +/* Creates and returns a new ofpbuf that initially contains a copy of the + * 'buffer->size' bytes of data starting at 'buffer->data' with no headroom or + * tailroom. */ struct ofpbuf * ofpbuf_clone(const struct ofpbuf *buffer) { - return ofpbuf_clone_data(buffer->data, buffer->size); + return ofpbuf_clone_with_headroom(buffer, 0); } /* Creates and returns a new ofpbuf whose data are copied from 'buffer'. The @@ -134,15 +137,44 @@ ofpbuf_clone(const struct ofpbuf *buffer) struct ofpbuf * ofpbuf_clone_with_headroom(const struct ofpbuf *buffer, size_t headroom) { - struct ofpbuf *b = ofpbuf_new_with_headroom(buffer->size, headroom); - ofpbuf_put(b, buffer->data, buffer->size); - return b; + struct ofpbuf *new_buffer; + uintptr_t data_delta; + + new_buffer = ofpbuf_clone_data_with_headroom(buffer->data, buffer->size, + headroom); + data_delta = (char *) new_buffer->data - (char *) buffer->data; + + if (buffer->l2) { + new_buffer->l2 = (char *) buffer->l2 + data_delta; + } + if (buffer->l3) { + new_buffer->l3 = (char *) buffer->l3 + data_delta; + } + if (buffer->l4) { + new_buffer->l4 = (char *) buffer->l4 + data_delta; + } + if (buffer->l7) { + new_buffer->l7 = (char *) buffer->l7 + data_delta; + } + + return new_buffer; } +/* Creates and returns a new ofpbuf that initially contains a copy of the + * 'size' bytes of data starting at 'data' with no headroom or tailroom. */ struct ofpbuf * ofpbuf_clone_data(const void *data, size_t size) { - struct ofpbuf *b = ofpbuf_new(size); + return ofpbuf_clone_data_with_headroom(data, size, 0); +} + +/* Creates and returns a new ofpbuf that initially contains 'headroom' bytes of + * headroom followed by a copy of the 'size' bytes of data starting at + * 'data'. */ +struct ofpbuf * +ofpbuf_clone_data_with_headroom(const void *data, size_t size, size_t headroom) +{ + struct ofpbuf *b = ofpbuf_new_with_headroom(size, headroom); ofpbuf_put(b, data, size); return b; } @@ -212,12 +244,6 @@ ofpbuf_resize__(struct ofpbuf *b, size_t new_headroom, size_t new_tailroom) break; case OFPBUF_STACK: - new_base = xmalloc(new_allocated); - ofpbuf_copy__(b, new_base, new_headroom, new_tailroom); - b->source = OFPBUF_MALLOC; - break; - - case OFPBUF_CONST: NOT_REACHED(); default: @@ -282,6 +308,16 @@ ofpbuf_trim(struct ofpbuf *b) } } +/* If 'b' is shorter than 'length' bytes, pads its tail out with zeros to that + * length. */ +void +ofpbuf_padto(struct ofpbuf *b, size_t length) +{ + if (b->size < length) { + ofpbuf_put_zeros(b, length - b->size); + } +} + /* Appends 'size' bytes of data to the tail end of 'b', reallocating and * copying its data if necessary. Returns a pointer to the first byte of the * new data, which is left uninitialized. */ @@ -449,6 +485,25 @@ ofpbuf_try_pull(struct ofpbuf *b, size_t size) return b->size >= size ? ofpbuf_pull(b, size) : NULL; } +/* Returns the data in 'b' as a block of malloc()'d memory and frees the buffer + * within 'b'. (If 'b' itself was dynamically allocated, e.g. with + * ofpbuf_new(), then it should still be freed with, e.g., ofpbuf_delete().) */ +void * +ofpbuf_steal_data(struct ofpbuf *b) +{ + void *p; + if (b->source == OFPBUF_MALLOC && b->data == b->base) { + p = b->data; + } else { + p = xmemdup(b->data, b->size); + if (b->source == OFPBUF_MALLOC) { + free(b->base); + } + } + b->base = b->data = NULL; + return p; +} + /* Returns a string that describes some of 'b''s metadata plus a hex dump of up * to 'maxbytes' from the start of the buffer. */ char *