X-Git-Url: http://git.onelab.eu/?a=blobdiff_plain;f=lxcsu;h=3ee60357ef57ee5f67e8adb9fae7957d0e0a71a4;hb=3d59d52c4a2b3247b2fe8498c79cd4d51829df69;hp=4c4bc04ec6873a31e78443724c985ed01e9d43f6;hpb=c2b9fa70310e6fd5e55f70d69868254ee1881c9c;p=lxc-userspace.git diff --git a/lxcsu b/lxcsu index 4c4bc04..3ee6035 100755 --- a/lxcsu +++ b/lxcsu @@ -1,17 +1,18 @@ -#!/usr/bin/python +#!/usr/bin/python3 import sys import os import setns -import pdb +import pwd from argparse import ArgumentParser # can set to True here, but also use the -d option debug = False -def getarch(f): - output = os.popen('readelf -h %s 2>&1'%f).readlines() +def getarch(pid): + exe_filename='/proc/%s/exe'%pid + output = os.popen('readelf -h %s 2>&1'%exe_filename).readlines() classlines = [x for x in output if ('Class' in x.split(':')[0])] line = classlines[0] c = line.split(':')[1] @@ -20,24 +21,24 @@ def getarch(f): elif ('ELF32' in c): return 'i686' else: - raise Exception('Could not determine architecture') + raise Exception('Could not determine architecture for pid %s'%pid) def get_cgroup_subdirs_for_pid(pid): cgroup_info_file = '/proc/%s/cgroup'%pid cgroup_lines = open(cgroup_info_file).read().splitlines() - + subdirs = {} for line in cgroup_lines: try: _, cgroup_name, subdir = line.split(':') subdirs[cgroup_name] = subdir - except Exception, e: - print "Error reading cgroup info: %s"%str(e) + except Exception as e: + print("Error reading cgroup info: %s"%str(e)) pass - + return subdirs - - + + def umount(fs_dir, opts=''): output = os.popen('/bin/umount %s %s 2>&1'%(opts, fs_dir)).read() return ('device is busy' not in output) @@ -79,6 +80,24 @@ def main (): args = parser.parse_args() slice_name=args.slice_name + # support for either setting debug at the top of this file, or on the command-line + if args.debug: + global debug + debug=True + + # somehow some older nodes won't be able to find the login name in /etc/passwd + # when this is done down the road, so compute slice_uid while in a safe env + # even though we don't use the slice_uid any more, this is still + # checked later on as a means to ensure existence of the slice account + try: + slice_uid = pwd.getpwnam(slice_name).pw_uid + except Exception as e: + if debug: + import traceback + print('error while computing slice_uid',e) + traceback.print_exc() + slice_uid=None + # unless we run the symlink 'lxcsu-internal', or we specify the -i option, prepend '--' '-c' if sys.argv[0].find('internal')>=0: args.internal=True @@ -93,11 +112,6 @@ def main (): if not args.command_to_run: args.command_to_run=['/bin/sh'] args.command_to_run = [ '-c' ] + [" ".join(args.command_to_run)] - # support for either setting debug at the top of this file, or on the command-line - if args.debug: - global debug - debug=True - try: cmd = '/usr/bin/virsh --connect lxc:/// domid %s'%slice_name # convert to int as a minimal raincheck @@ -105,22 +119,22 @@ def main (): # locate the pid for the - expected - single child, that would be the init for that VM #init_pid = int(open("/proc/%s/task/%s/children"%(driver_pid,driver_pid)).read().strip()) init_pid = int(os.popen('pgrep -P %s'%driver_pid).readlines()[0].strip()) - # Thierry: I am changing the code below to use child_pid instead of driver_pid + # Thierry: I am changing the code below to use init_pid instead of driver_pid # for the namespace handling features, that I was able to check # I've left the other ones as they were, i.e. using driver_pid, but I suspect - # they chould be changed as well + # some should be changed as well except: - print "Domain %s not found"%slice_name + print("Domain %s not found"%slice_name) exit(1) if not driver_pid or not init_pid: - print "Domain %s not started"%slice_name + print("Domain %s not started"%slice_name) exit(1) - if debug: print "Found driver_pid",driver_pid,'and init_pid=',init_pid - # xxx probably init_pid here too - arch = getarch('/proc/%s/exe'%driver_pid) + if debug: print("Found driver_pid",driver_pid,'and init_pid=',init_pid) + # driver_pid is always x86_64, we need to look at the VM's init process here + arch = getarch(init_pid) # Set sysctls specific to slice sysctls = [] @@ -136,7 +150,7 @@ def main (): sysctls.append((sysctl_file, sysctl_name, sysctl_val)) # xxx probably init_pid here too - subdirs = get_cgroup_subdirs_for_pid(driver_pid) + subdirs = get_cgroup_subdirs_for_pid(driver_pid) sysfs_root = '/sys/fs/cgroup' # If the slice is frozen, then we'll get an EBUSY when trying to write to the task @@ -157,12 +171,12 @@ def main (): subsystem_comps.reverse() subsystem_alt = ','.join(subsystem_comps) tasks_path_alt = [sysfs_root, subsystem_alt, subdirs[subsystem], 'tasks'] - except Exception,e: + except Exception as e: pass - + tasks_path = [sysfs_root,subsystem,subdirs[subsystem],'tasks'] tasks_path_str = '/'.join(tasks_path) - + try: f = open(tasks_path_str, 'w') except: @@ -173,19 +187,19 @@ def main (): if (subsystem=='freezer'): f.close() - except Exception,e: - if (not subdirs.has_key(subsystem)): + except Exception as e: + if (subsystem not in subdirs): pass else: - if debug: print e - print "Error assigning cgroup %s (pid=%s) for slice %s"%(current_cgroup,driver_pid, slice_name) + if debug: print(e) + print("Error assigning cgroup %s (pid=%s) for slice %s"%(current_cgroup,driver_pid, slice_name)) exit(1) def chcontext (path): retcod = setns.chcontext (path) if retcod != 0: - print 'WARNING - setns(%s)=>%s (ignored)'%(path,retcod) + print('WARNING - setns(%s)=>%s (ignored)'%(path,retcod)) return retcod # Use init_pid and not driver_pid to locate reference namespaces @@ -193,7 +207,7 @@ def main (): if True: chcontext(ref_ns+'uts') if True: chcontext(ref_ns+'ipc') - + if (not args.no_pidns): chcontext(ref_ns+'pid') if (not args.no_netns): chcontext(ref_ns+'net') if (not args.no_mntns): chcontext(ref_ns+'mnt') @@ -209,7 +223,7 @@ def main (): os.system('%s -w %s=%s >/dev/null 2>&1'%(fn, sysctl_name,sysctl_val)) break else: - print "Error: image does not have a sysctl binary" + print("Error: image does not have a sysctl binary") # cgroups is not yet LXC-safe, so we need to use the coarse grained access control # strategy of unmounting the filesystem @@ -218,37 +232,27 @@ def main (): for subsystem in ['cpuset','cpu,cpuacct','memory','devices','freezer','net_cls','blkio','perf_event','systemd']: fs_path = '/sys/fs/cgroup/%s'%subsystem if (not umount(fs_path,'-l')): - print 'WARNING - umount failed (ignored) with path=',fs_path + print('WARNING - umount failed (ignored) with path=',fs_path) pass # Leaving these comments for historical reference #print "Error disabling cgroup access" #exit(1) - Don't need this because failure here implies failure in the call to umount /sys/fs/cgroup if (not umount('/sys/fs/cgroup')): - print "Error disabling cgroup access" + print("Error disabling cgroup access") exit(1) fork_pid = os.fork() - def getuid (slicename): - import pwd - try: - return pwd.getpwnam(slicename).pw_uid - except: - return - if (fork_pid == 0): if (not args.root): - setns.drop_caps() + setns.drop_caps() if (args.nosliceuid): # we still want to drop capabilities, but don't want to switch UIDs exec_args = [arch,'/bin/sh','--login',]+args.command_to_run else: - # let's keep this check even though we don't use the uid - # as a way of checking the existence of the slice account - uid = getuid (slice_name) - if not uid: - print "lxcsu could not spot %s in /etc/passwd - exiting"%slice_name + if not slice_uid: + print("lxcsu could not spot %s in /etc/passwd - exiting"%slice_name) exit(1) exec_args = [arch,'/usr/bin/sudo','-u',slice_name,'/bin/sh','--login',]+args.command_to_run # once we can drop f12, it would be nicer to instead go for @@ -262,7 +266,7 @@ def main (): if not args.noslicehome: os.environ['HOME'] = '/home/%s'%slice_name os.chdir("/home/%s"%(slice_name)) - if debug: print 'lxcsu:execv:','/usr/bin/setarch',exec_args + if debug: print('lxcsu:execv:','/usr/bin/setarch',exec_args) os.execv('/usr/bin/setarch',exec_args) else: setns.proc_umount()