X-Git-Url: http://git.onelab.eu/?a=blobdiff_plain;f=lxcsu;h=bf69e50af434ed5144a989163d436106b846fc7c;hb=b73e9b3242e8769e9e40b6263edaba2387bc98d6;hp=dc24ec157a61103c7a20175ed1a11e50025d5d9c;hpb=a79258e2347fd3368b52e8a4b14601e58fe6cbb3;p=lxc-userspace.git

diff --git a/lxcsu b/lxcsu
old mode 100755
new mode 100644
index dc24ec1..bf69e50
--- a/lxcsu
+++ b/lxcsu
@@ -7,7 +7,12 @@ import sys
 
 #from optparse import OptionParser
 
-drop_capabilities='cap_sys_admin,cap_sys_boot,cap_sys_module'.split(',')
+drop_capabilities='cap_sys_admin,cap_sys_boot,cap_sys_module'
+
+def umount(fs_dir):
+    output = os.popen('/bin/umount %s 2>&1'%fs_dir).read()
+    return ('device is busy' not in fs_dir)
+
 
 """
 parser = OptionParser()
@@ -96,12 +101,27 @@ r3 = setns.chcontext('/proc/%s/ns/net'%pid)
 open('/proc/lxcsu','w').write(pid)
 open('/proc/pidsu','w').write(pid)
 
+# cgroups is not yet LXC-safe, so we need to use the course grained access control
+# strategy of unmounting the filesystem
+
+umount_result = True
+for subsystem in ['cpuset','cpu,cpuacct','memory','devices','freezer','net_cls','blkio','perf_event']:
+    fs_path = '/sys/fs/cgroup/%s'%subsystem
+    if (not umount(fs_path)):
+        print "Error disabling cgroup access"
+        exit(1)
+
+if (not umount('/sys/fs/cgroup')):
+    print "Error disabling cgroup access"
+    exit(1)
+
 pid = os.fork()
 
-cap_args = map(lambda c:'--drop='+c, drop_capabilities)
-    
 if (pid == 0):
+    cap_arg = '--drop='+drop_capabilities
+    exec_args = ['/usr/sbin/capsh',cap_arg,'--','--login']+args[1:]
+
     os.environ['SHELL'] = '/bin/sh'
-    os.execv('/usr/sbin/capsh',cap_args+['--','--login']+args[1:])
+    os.execv('/usr/sbin/capsh',exec_args)
 else:
     os.waitpid(pid,0)