X-Git-Url: http://git.onelab.eu/?a=blobdiff_plain;f=manifold%2Fmanifoldapi.py;h=9361b6eb7e304e0764ab08a5acacc11dd2879df2;hb=c0c7175e6883ad9bc746692e7c71202e64ec2351;hp=6a0e1d2308b00d0ba6429cbb4b161dc02a038f79;hpb=ec4be8cfef3ed6b3dc1742a95efd014da8f01893;p=myslice.git

diff --git a/manifold/manifoldapi.py b/manifold/manifoldapi.py
index 6a0e1d23..9361b6eb 100644
--- a/manifold/manifoldapi.py
+++ b/manifold/manifoldapi.py
@@ -3,13 +3,12 @@ import xmlrpclib
 
 from myslice.config import Config
 
-debug=True
+from django.contrib import messages
+from manifoldresult import ManifoldResult, ManifoldCode, ManifoldException
+from manifold.core.result_value import ResultValue
 
-class SessionExpired (Exception):
-    def __init__ (self,message):
-        self.message=message
-    def __repr__ (self): 
-        return "<SessionExpired: %s>"%self.message
+debug=False
+debug=True
 
 class ManifoldAPI:
 
@@ -25,36 +24,40 @@ class ManifoldAPI:
         self.url = config.manifold_url
         self.server = xmlrpclib.Server(self.url, verbose=False, allow_none=True)
 
+    def __repr__ (self): return "ManifoldAPI[%s]"%self.url
+
+    # a one-liner to give a hint of what the return value looks like
+    def _print_result (self, result):
+        if not result:                        print "[no/empty result]"
+        elif isinstance (result,str):         print "result is '%s'"%result
+        elif isinstance (result,list):        print "result is a %d-elts list"%len(result)
+        else:                                 print "[dont know how to display result]"
+
+    # xxx temporary code for scaffolding a ManifolResult on top of an API that does not expose error info
+    # as of march 2013 we work with an API that essentially either returns the value, or raises 
+    # an xmlrpclib.Fault exception with always the same 8002 code
+    # since most of the time we're getting this kind of issues for expired sessions
+    # (looks like sessions are rather short-lived), for now the choice is to map these errors on 
+    # a SESSION_EXPIRED code
     def __getattr__(self, methodName):
         def func(*args, **kwds):
             try:
+                if debug: print "====> ManifoldAPI.%s"%methodName,"auth",self.auth,"args",args,"kwds",kwds
                 result=getattr(self.server, methodName)(self.auth, *args, **kwds)
                 if debug:
-                    print '===> backend call',methodName, self.auth, self.url,'->',
-                    if not result:                        print "no/empty result"
-                    elif isinstance (result,str):         print "result is '%s'"%result
-                    elif isinstance (result,list):        print "result is a %d-elts list"%len(result)
-                    else:                                 print "dont know how to display result"
-                return result
-            except xmlrpclib.Fault, error:
-                ### xxx this is very rough for now
-                # until we have some agreement about how the API calls should return error conditions
-                # in some less unpolite way than this anoanymous exception, we assume it's a problem with the session
-                # that needs to be refreshed
-                if error.faultCode == 8002:
-                    reason="most likely your session has expired"
-                    reason += " (the manifold API has no unambiguous error reporting mechanism yet)"
-                    raise SessionExpired(reason)
+                    print '<==== backend call %s(*%s,**%s) returned'%(methodName,args,kwds),
+                    print '.ctd. Authmethod=',self.auth['AuthMethod'], self.url,'->',
+                    self._print_result(result)
+
+                return ResultValue(**result)
+
             except Exception,error:
-                print "ManifoldAPI: unexpected exception",error
-                raise
+                # XXX Connection refused for example
+                print "** API ERROR **"
+                import traceback
+                traceback.print_exc()
+                if debug: print "KO (unexpected exception)",error
+                raise ManifoldException ( ManifoldResult (code=ManifoldCode.UNKNOWN_ERROR, output="%s"%error) )
+
         return func
 
-    def send_manifold_query (self, manifold_query):
-        (action,subject)= (manifold_query.action,manifold_query.subject)
-        if action=='get':
-            # use self.Get rather than self.server.Get so we catch exceptions as per __getattr__
-            return self.Get(self.auth, subject, manifold_query.filters, {}, manifold_query.fields)
-        # xxx...
-        else:
-            print "WARNING: ManifoldAPI.send_manifold_query: only 'get' implemented for now"