X-Git-Url: http://git.onelab.eu/?a=blobdiff_plain;f=net%2Fappletalk%2Fddp.c;h=4170de1a078ed7b0a069f03143bbe0dea4824af0;hb=1be35e94e1da3669db492995cd2c8b1a37016b11;hp=4185d7b8ed0244d6f7df5ad5357bd92e3e628ffa;hpb=a91482bdcc2e0f6035702e46f1b99043a0893346;p=linux-2.6.git

diff --git a/net/appletalk/ddp.c b/net/appletalk/ddp.c
index 4185d7b8e..4170de1a0 100644
--- a/net/appletalk/ddp.c
+++ b/net/appletalk/ddp.c
@@ -908,12 +908,12 @@ static int atrtr_ioctl(unsigned int cmd, void __user *arg)
 
 		case SIOCADDRT: {
 			struct net_device *dev = NULL;
+			/*
+			 * FIXME: the name of the device is still in user
+			 * space, isn't it?
+			 */
 			if (rt.rt_dev) {
-				char name[IFNAMSIZ];
-				if (copy_from_user(name, rt.rt_dev, IFNAMSIZ-1))
-					return -EFAULT;
-				name[IFNAMSIZ-1] = '\0';
-				dev = __dev_get_by_name(name);
+				dev = __dev_get_by_name(rt.rt_dev);
 				if (!dev)
 					return -ENODEV;
 			}