X-Git-Url: http://git.onelab.eu/?a=blobdiff_plain;f=ofproto%2Ffail-open.c;h=2c0a8f33d534faafc628949e6dce808499c2cade;hb=7aaeab4df24b7e9460705b1dad1010eef0354c50;hp=f3a99c131f6328ecfa92b46e3e55f8d81948e247;hpb=38f7147c3e7310ab3ea87420e120e2b1f2268975;p=sliver-openvswitch.git diff --git a/ofproto/fail-open.c b/ofproto/fail-open.c index f3a99c131..2c0a8f33d 100644 --- a/ofproto/fail-open.c +++ b/ofproto/fail-open.c @@ -23,6 +23,7 @@ #include "flow.h" #include "mac-learning.h" #include "odp-util.h" +#include "ofp-actions.h" #include "ofp-util.h" #include "ofpbuf.h" #include "ofproto.h" @@ -121,7 +122,7 @@ send_bogus_packet_ins(struct fail_open *fo) ofpbuf_init(&b, 128); eth_addr_nicira_random(mac); - compose_benign_packet(&b, mac); + compose_rarp(&b, mac); memset(&pin, 0, sizeof pin); pin.packet = b.data; @@ -190,14 +191,14 @@ fail_open_maybe_recover(struct fail_open *fo) static void fail_open_recover(struct fail_open *fo) { - struct cls_rule rule; + struct match match; VLOG_WARN("No longer in fail-open mode"); fo->last_disconn_secs = 0; fo->next_bogus_packet_in = LLONG_MAX; - cls_rule_init_catchall(&rule, FAIL_OPEN_PRIORITY); - ofproto_delete_flow(fo->ofproto, &rule); + match_init_catchall(&match); + ofproto_delete_flow(fo->ofproto, &match, FAIL_OPEN_PRIORITY); } void @@ -214,18 +215,20 @@ fail_open_flushed(struct fail_open *fo) int disconn_secs = connmgr_failure_duration(fo->connmgr); bool open = disconn_secs >= trigger_duration(fo); if (open) { - union ofp_action action; - struct cls_rule rule; + struct ofpbuf ofpacts; + struct match match; /* Set up a flow that matches every packet and directs them to * OFPP_NORMAL. */ - memset(&action, 0, sizeof action); - action.type = htons(OFPAT10_OUTPUT); - action.output.len = htons(sizeof action); - action.output.port = htons(OFPP_NORMAL); + ofpbuf_init(&ofpacts, OFPACT_OUTPUT_SIZE); + ofpact_put_OUTPUT(&ofpacts)->port = OFPP_NORMAL; + ofpact_pad(&ofpacts); - cls_rule_init_catchall(&rule, FAIL_OPEN_PRIORITY); - ofproto_add_flow(fo->ofproto, &rule, &action, 1); + match_init_catchall(&match); + ofproto_add_flow(fo->ofproto, &match, FAIL_OPEN_PRIORITY, + ofpacts.data, ofpacts.size); + + ofpbuf_uninit(&ofpacts); } }