X-Git-Url: http://git.onelab.eu/?a=blobdiff_plain;f=ovsdb%2Fovsdb-server.c;h=530568aec37d343cd24bcb55cbac8ab3810fe184;hb=4be00e48e29f84e9b08e590ac2e3adbc9d99273f;hp=14f0fbfb757c9d71944ac02941e4e550463f13fb;hpb=bf8f2167fd3107f5513d487a69a6568cf51afd68;p=sliver-openvswitch.git diff --git a/ovsdb/ovsdb-server.c b/ovsdb/ovsdb-server.c index 14f0fbfb7..530568aec 100644 --- a/ovsdb/ovsdb-server.c +++ b/ovsdb/ovsdb-server.c @@ -15,8 +15,7 @@ #include -#include "ovsdb.h" - +#include #include #include #include @@ -25,12 +24,15 @@ #include "column.h" #include "command-line.h" #include "daemon.h" +#include "dirs.h" #include "file.h" +#include "hash.h" #include "json.h" #include "jsonrpc.h" #include "jsonrpc-server.h" #include "leak-checker.h" #include "list.h" +#include "ovsdb.h" #include "ovsdb-data.h" #include "ovsdb-types.h" #include "ovsdb-error.h" @@ -105,6 +107,7 @@ main(int argc, char *argv[]) if (error) { ovs_fatal(0, "%s", ovsdb_error_to_string(error)); } + free(file_name); jsonrpc = ovsdb_jsonrpc_server_create(db); reconfigure_from_db(jsonrpc, db, &remotes); @@ -132,11 +135,11 @@ main(int argc, char *argv[]) daemonize_complete(); - unixctl_command_register("exit", ovsdb_server_exit, &exiting); - unixctl_command_register("ovsdb-server/compact", ovsdb_server_compact, - file); - unixctl_command_register("ovsdb-server/reconnect", ovsdb_server_reconnect, - jsonrpc); + unixctl_command_register("exit", "", ovsdb_server_exit, &exiting); + unixctl_command_register("ovsdb-server/compact", "", + ovsdb_server_compact, file); + unixctl_command_register("ovsdb-server/reconnect", "", + ovsdb_server_reconnect, jsonrpc); exiting = false; while (!exiting) { @@ -344,7 +347,7 @@ read_string_column(const struct ovsdb_row *row, const char *column_name, const union ovsdb_atom *atom; atom = read_column(row, column_name, OVSDB_TYPE_STRING); - *stringp = atom ? atom->string : 0; + *stringp = atom ? atom->string : NULL; return atom != NULL; } @@ -461,12 +464,12 @@ query_db_remotes(const char *name, const struct ovsdb *db, static void update_remote_row(const struct ovsdb_row *row, struct ovsdb_txn *txn, - const struct shash *statuses) + const struct ovsdb_jsonrpc_server *jsonrpc) { + struct ovsdb_jsonrpc_remote_status status; struct ovsdb_row *rw_row; const char *target; - const struct ovsdb_jsonrpc_remote_status *status; - char *keys[4], *values[4]; + char *keys[8], *values[8]; size_t n = 0; /* Get the "target" (protocol/host/port) spec. */ @@ -474,43 +477,54 @@ update_remote_row(const struct ovsdb_row *row, struct ovsdb_txn *txn, /* Bad remote spec or incorrect schema. */ return; } - - /* Prepare to modify this row. */ rw_row = ovsdb_txn_row_modify(txn, row); - - /* Find status information for this target. */ - status = shash_find_data(statuses, target); - if (!status) { - /* Should never happen, but just in case... */ - return; - } + ovsdb_jsonrpc_server_get_remote_status(jsonrpc, target, &status); /* Update status information columns. */ + write_bool_column(rw_row, "is_connected", status.is_connected); - write_bool_column(rw_row, "is_connected", - status->is_connected); - - keys[n] = xstrdup("state"); - values[n++] = xstrdup(status->state); - if (status->sec_since_connect != UINT_MAX) { + if (status.state) { + keys[n] = xstrdup("state"); + values[n++] = xstrdup(status.state); + } + if (status.sec_since_connect != UINT_MAX) { keys[n] = xstrdup("sec_since_connect"); - values[n++] = xasprintf("%u", status->sec_since_connect); + values[n++] = xasprintf("%u", status.sec_since_connect); } - if (status->sec_since_disconnect != UINT_MAX) { + if (status.sec_since_disconnect != UINT_MAX) { keys[n] = xstrdup("sec_since_disconnect"); - values[n++] = xasprintf("%u", status->sec_since_disconnect); + values[n++] = xasprintf("%u", status.sec_since_disconnect); } - if (status->last_error) { + if (status.last_error) { keys[n] = xstrdup("last_error"); values[n++] = - xstrdup(ovs_retval_to_string(status->last_error)); + xstrdup(ovs_retval_to_string(status.last_error)); + } + if (status.locks_held && status.locks_held[0]) { + keys[n] = xstrdup("locks_held"); + values[n++] = xstrdup(status.locks_held); + } + if (status.locks_waiting && status.locks_waiting[0]) { + keys[n] = xstrdup("locks_waiting"); + values[n++] = xstrdup(status.locks_waiting); + } + if (status.locks_lost && status.locks_lost[0]) { + keys[n] = xstrdup("locks_lost"); + values[n++] = xstrdup(status.locks_lost); + } + if (status.n_connections > 1) { + keys[n] = xstrdup("n_connections"); + values[n++] = xasprintf("%d", status.n_connections); } write_string_string_column(rw_row, "status", keys, values, n); + + ovsdb_jsonrpc_server_free_remote_status(&status); } static void update_remote_rows(const struct ovsdb *db, struct ovsdb_txn *txn, - const char *remote_name, const struct shash *statuses) + const char *remote_name, + const struct ovsdb_jsonrpc_server *jsonrpc) { const struct ovsdb_table *table, *ref_table; const struct ovsdb_column *column; @@ -540,7 +554,7 @@ update_remote_rows(const struct ovsdb *db, struct ovsdb_txn *txn, ref_row = ovsdb_table_get_row(ref_table, &datum->keys[i].uuid); if (ref_row) { - update_remote_row(ref_row, txn, statuses); + update_remote_row(ref_row, txn, jsonrpc); } } } @@ -551,20 +565,16 @@ update_remote_status(const struct ovsdb_jsonrpc_server *jsonrpc, const struct sset *remotes, struct ovsdb *db) { static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 1); - struct shash statuses; struct ovsdb_txn *txn; const bool durable_txn = false; struct ovsdb_error *error; const char *remote; - /* Get status of current connections. */ - ovsdb_jsonrpc_server_get_remote_status(jsonrpc, &statuses); - txn = ovsdb_txn_create(db); /* Iterate over --remote arguments given on command line. */ SSET_FOR_EACH (remote, remotes) { - update_remote_rows(db, txn, remote, &statuses); + update_remote_rows(db, txn, remote, jsonrpc); } error = ovsdb_txn_commit(txn, durable_txn); @@ -572,8 +582,6 @@ update_remote_status(const struct ovsdb_jsonrpc_server *jsonrpc, VLOG_ERR_RL(&rl, "Failed to update remote status: %s", ovsdb_error_to_string(error)); } - - shash_destroy_free_data(&statuses); } /* Reconfigures ovsdb-server based on information in the database. */ @@ -659,19 +667,19 @@ parse_options(int argc, char *argv[], char **file_namep, DAEMON_OPTION_ENUMS }; static struct option long_options[] = { - {"remote", required_argument, 0, OPT_REMOTE}, - {"unixctl", required_argument, 0, OPT_UNIXCTL}, - {"run", required_argument, 0, OPT_RUN}, - {"help", no_argument, 0, 'h'}, - {"version", no_argument, 0, 'V'}, + {"remote", required_argument, NULL, OPT_REMOTE}, + {"unixctl", required_argument, NULL, OPT_UNIXCTL}, + {"run", required_argument, NULL, OPT_RUN}, + {"help", no_argument, NULL, 'h'}, + {"version", no_argument, NULL, 'V'}, DAEMON_LONG_OPTIONS, VLOG_LONG_OPTIONS, LEAK_CHECKER_LONG_OPTIONS, - {"bootstrap-ca-cert", required_argument, 0, OPT_BOOTSTRAP_CA_CERT}, - {"private-key", required_argument, 0, 'p'}, - {"certificate", required_argument, 0, 'c'}, - {"ca-cert", required_argument, 0, 'C'}, - {0, 0, 0, 0}, + {"bootstrap-ca-cert", required_argument, NULL, OPT_BOOTSTRAP_CA_CERT}, + {"private-key", required_argument, NULL, 'p'}, + {"certificate", required_argument, NULL, 'c'}, + {"ca-cert", required_argument, NULL, 'C'}, + {NULL, 0, NULL, 0}, }; char *short_options = long_options_to_short_options(long_options); @@ -701,7 +709,7 @@ parse_options(int argc, char *argv[], char **file_namep, usage(); case 'V': - OVS_PRINT_VERSION(0, 0); + ovs_print_version(0, 0); exit(EXIT_SUCCESS); VLOG_OPTION_HANDLERS @@ -738,14 +746,19 @@ parse_options(int argc, char *argv[], char **file_namep, argc -= optind; argv += optind; - if (argc > 1) { + switch (argc) { + case 0: + *file_namep = xasprintf("%s/openvswitch/conf.db", ovs_sysconfdir()); + break; + + case 1: + *file_namep = xstrdup(argv[0]); + break; + + default: ovs_fatal(0, "database file is only non-option argument; " "use --help for usage"); - } else if (argc < 1) { - ovs_fatal(0, "missing database file argument; use --help for usage"); } - - *file_namep = argv[0]; } static void