X-Git-Url: http://git.onelab.eu/?a=blobdiff_plain;f=planetstack%2Fcore%2Fadmin.py;h=a2c76e288222ee6a430e9104c109dfdd6fc8523c;hb=25f36240782d59077e97af0730748cdfb1be305a;hp=dcee1b7db6757a946ebe1eb8248b3f5531ef23f6;hpb=b27b62c9f1dd8a48a19d84b67d327602e1ff436f;p=plstackapi.git diff --git a/planetstack/core/admin.py b/planetstack/core/admin.py index dcee1b7..a2c76e2 100644 --- a/planetstack/core/admin.py +++ b/planetstack/core/admin.py @@ -8,7 +8,7 @@ from django import forms from django.utils.safestring import mark_safe from django.contrib.auth.admin import UserAdmin from django.contrib.admin.widgets import FilteredSelectMultiple -from django.contrib.auth.forms import ReadOnlyPasswordHashField +from django.contrib.auth.forms import ReadOnlyPasswordHashField, AdminPasswordChangeForm from django.contrib.auth.signals import user_logged_in from django.utils import timezone from django.contrib.contenttypes import generic @@ -16,25 +16,84 @@ from suit.widgets import LinkedSelect from django.core.exceptions import PermissionDenied from django.core.urlresolvers import reverse, NoReverseMatch -import django_evolution +import django_evolution +import threading -class ReadOnlyAwareAdmin(admin.ModelAdmin): +# thread locals necessary to work around a django-suit issue +_thread_locals = threading.local() + +def backend_icon(obj): # backend_status, enacted, updated): + #return "%s %s %s" % (str(obj.updated), str(obj.enacted), str(obj.backend_status)) + if (obj.enacted is not None) and obj.enacted >= obj.updated: + return '' + else: + if obj.backend_status == "Provisioning in progress" or obj.backend_status=="": + return '' % obj.backend_status + else: + return '' % obj.backend_status + +def backend_text(obj): + icon = backend_icon(obj) + if (obj.enacted is not None) and obj.enacted >= obj.updated: + return "%s %s" % (icon, "successfully enacted") # enacted on %s" % str(obj.enacted)) + else: + return "%s %s" % (icon, obj.backend_status) + +class PlainTextWidget(forms.HiddenInput): + input_type = 'hidden' + + def render(self, name, value, attrs=None): + if value is None: + value = '' + return mark_safe(str(value) + super(PlainTextWidget, self).render(name, value, attrs)) + +class PermissionCheckingAdminMixin(object): + # call save_by_user and delete_by_user instead of save and delete def has_add_permission(self, request, obj=None): return (not self.__user_is_readonly(request)) - + def has_delete_permission(self, request, obj=None): return (not self.__user_is_readonly(request)) def save_model(self, request, obj, form, change): if self.__user_is_readonly(request): + # this 'if' might be redundant if save_by_user is implemented right raise PermissionDenied - #pass - else: - return super(ReadOnlyAwareAdmin, self).save_model(request, obj, form, change) + + obj.caller = request.user + # update openstack connection to use this site/tenant + obj.save_by_user(request.user) + + def delete_model(self, request, obj): + obj.delete_by_user(request.user) + + def save_formset(self, request, form, formset, change): + instances = formset.save(commit=False) + for instance in instances: + instance.save_by_user(request.user) + + # BUG in django 1.7? Objects are not deleted by formset.save if + # commit is False. So let's delete them ourselves. + # + # code from forms/models.py save_existing_objects() + try: + forms_to_delete = formset.deleted_forms + except AttributeError: + forms_to_delete = [] + if formset.initial_forms: + for form in formset.initial_forms: + obj = form.instance + if form in forms_to_delete: + if obj.pk is None: + continue + formset.deleted_objects.append(obj) + obj.delete() + + formset.save_m2m() def get_actions(self,request): - actions = super(ReadOnlyAwareAdmin,self).get_actions(request) + actions = super(PermissionCheckingAdminMixin,self).get_actions(request) if self.__user_is_readonly(request): if 'delete_selected' in actions: @@ -60,17 +119,33 @@ class ReadOnlyAwareAdmin(admin.ModelAdmin): self.inlines = self.inlines_save try: - return super(ReadOnlyAwareAdmin, self).change_view(request, object_id, extra_context=extra_context) + return super(PermissionCheckingAdminMixin, self).change_view(request, object_id, extra_context=extra_context) except PermissionDenied: pass if request.method == 'POST': raise PermissionDenied request.readonly = True - return super(ReadOnlyAwareAdmin, self).change_view(request, object_id, extra_context=extra_context) + return super(PermissionCheckingAdminMixin, self).change_view(request, object_id, extra_context=extra_context) def __user_is_readonly(self, request): return request.user.isReadOnlyUser() + def backend_status_text(self, obj): + return mark_safe(backend_text(obj)) + + def backend_status_icon(self, obj): + return mark_safe(backend_icon(obj)) + backend_status_icon.short_description = "" + +class ReadOnlyAwareAdmin(PermissionCheckingAdminMixin, admin.ModelAdmin): + # Note: Make sure PermissionCheckingAdminMixin is listed before + # admin.ModelAdmin in the class declaration. + + pass + +class PlanetStackBaseAdmin(ReadOnlyAwareAdmin): + save_on_top = False + class SingletonAdmin (ReadOnlyAwareAdmin): def has_add_permission(self, request): if not super(SingletonAdmin, self).has_add_permission(request): @@ -82,7 +157,6 @@ class SingletonAdmin (ReadOnlyAwareAdmin): else: return True - class PlStackTabularInline(admin.TabularInline): def __init__(self, *args, **kwargs): super(PlStackTabularInline, self).__init__(*args, **kwargs) @@ -161,6 +235,10 @@ class PlStackTabularInline(admin.TabularInline): readonly_fields.append(field) return readonly_fields + def backend_status_icon(self, obj): + return mark_safe(backend_icon(obj)) + backend_status_icon.short_description = "" + class PlStackGenericTabularInline(generic.GenericTabularInline): def has_add_permission(self, request): return not request.user.isReadOnlyUser() @@ -173,11 +251,15 @@ class PlStackGenericTabularInline(generic.GenericTabularInline): readonly_fields.append(field) return readonly_fields + def backend_status_icon(self, obj): + return mark_safe(backend_icon(obj)) + backend_status_icon.short_description = "" + class ReservationInline(PlStackTabularInline): model = Reservation extra = 0 suit_classes = 'suit-tab suit-tab-reservations' - + def queryset(self, request): return Reservation.select_by_user(request.user) @@ -225,9 +307,9 @@ class NetworkLookerUpper: class SliverInline(PlStackTabularInline): model = Sliver - fields = ['all_ips_string', 'instance_name', 'slice', 'numberCores', 'deploymentNetwork', 'image', 'node'] + fields = ['backend_status_icon', 'all_ips_string', 'instance_name', 'slice', 'deploymentNetwork', 'flavor', 'image', 'node'] extra = 0 - readonly_fields = ['all_ips_string', 'instance_name'] + readonly_fields = ['backend_status_icon', 'all_ips_string', 'instance_name'] suit_classes = 'suit-tab suit-tab-slivers' def queryset(self, request): @@ -236,53 +318,14 @@ class SliverInline(PlStackTabularInline): def formfield_for_foreignkey(self, db_field, request=None, **kwargs): if db_field.name == 'deploymentNetwork': kwargs['queryset'] = Deployment.select_by_acl(request.user) - # the inscrutable jquery selector below says: - # find the closest parent "tr" to the current element - # then find the child with class "field-node" - # then find the child with that is a select - # then return its id - kwargs['widget'] = forms.Select(attrs={'onChange': "update_nodes(this, $($(this).closest('tr')[0]).find('.field-node select')[0].id)"}) - #kwargs['widget'] = forms.Select(attrs={'onChange': "console.log($($($(this).closest('tr')[0]).children('.field-node')[0]).children('select')[0].id);"}) + kwargs['widget'] = forms.Select(attrs={'onChange': "sliver_deployment_changed(this);"}) + elif db_field.name == 'flavor': + kwargs['widget'] = forms.Select(attrs={'onChange': "sliver_flavor_changed(this);"}) field = super(SliverInline, self).formfield_for_foreignkey(db_field, request, **kwargs) return field -""" - SMBAKER: This is the old code that implemented each network type as a - separate column in the sliver table. - - def _declared_fieldsets(self): - # Return None so django will call get_fieldsets and we can insert our - # dynamic fields - return None - - def get_readonly_fields(self, request, obj=None): - readonly_fields = list(super(SliverInline, self).get_readonly_fields(request, obj)) - - # Lookup the networks that are bound to the slivers, and add those - # network names to the list of readonly fields. - - for sliver in obj.slivers.all(): - for nbs in sliver.networksliver_set.all(): - if nbs.ip: - network_name = nbs.network.name - if network_name not in [str(x) for x in readonly_fields]: - readonly_fields.append(NetworkLookerUpper.get(network_name)) - - return readonly_fields - - def get_fieldsets(self, request, obj=None): - form = self.get_formset(request, obj).form - # fields = the read/write files + the read-only fields - fields = list(self.fields) - for fieldName in self.get_readonly_fields(request,obj): - if not fieldName in fields: - fields.append(fieldName) - - return [(None, {'fields': fields})] -""" - class SiteInline(PlStackTabularInline): model = Site extra = 0 @@ -293,7 +336,8 @@ class SiteInline(PlStackTabularInline): class UserInline(PlStackTabularInline): model = User - fields = ['email', 'firstname', 'lastname'] + fields = ['backend_status_icon', 'email', 'firstname', 'lastname'] + readonly_fields = ('backend_status_icon', ) extra = 0 suit_classes = 'suit-tab suit-tab-users' @@ -302,7 +346,8 @@ class UserInline(PlStackTabularInline): class SliceInline(PlStackTabularInline): model = Slice - fields = ['name','site', 'serviceClass', 'service'] + fields = ['backend_status_icon', 'name', 'site', 'serviceClass', 'service'] + readonly_fields = ('backend_status_icon', ) extra = 0 suit_classes = 'suit-tab suit-tab-slices' @@ -313,13 +358,15 @@ class NodeInline(PlStackTabularInline): model = Node extra = 0 suit_classes = 'suit-tab suit-tab-nodes' - fields = ['name','deployment','site'] + fields = ['backend_status_icon', 'name','deployment','site'] + readonly_fields = ('backend_status_icon', ) class DeploymentPrivilegeInline(PlStackTabularInline): model = DeploymentPrivilege extra = 0 suit_classes = 'suit-tab suit-tab-deploymentprivileges' - fields = ['user','role','deployment'] + fields = ['backend_status_icon', 'user','role','deployment'] + readonly_fields = ('backend_status_icon', ) def queryset(self, request): return DeploymentPrivilege.select_by_user(request.user) @@ -328,7 +375,8 @@ class SitePrivilegeInline(PlStackTabularInline): model = SitePrivilege extra = 0 suit_classes = 'suit-tab suit-tab-siteprivileges' - fields = ['user','site', 'role'] + fields = ['backend_status_icon', 'user','site', 'role'] + readonly_fields = ('backend_status_icon', ) def formfield_for_foreignkey(self, db_field, request, **kwargs): if db_field.name == 'site': @@ -343,10 +391,10 @@ class SitePrivilegeInline(PlStackTabularInline): class SiteDeploymentInline(PlStackTabularInline): model = SiteDeployments - #model = Site.deployments.through extra = 0 suit_classes = 'suit-tab suit-tab-deployments' - fields = ['deployment','site'] + fields = ['backend_status_icon', 'deployment','site'] + readonly_fields = ('backend_status_icon', ) def formfield_for_foreignkey(self, db_field, request, **kwargs): if db_field.name == 'site': @@ -364,13 +412,14 @@ class SlicePrivilegeInline(PlStackTabularInline): model = SlicePrivilege suit_classes = 'suit-tab suit-tab-sliceprivileges' extra = 0 - fields = ('user', 'slice','role') + fields = ('backend_status_icon', 'user', 'slice', 'role') + readonly_fields = ('backend_status_icon', ) def formfield_for_foreignkey(self, db_field, request, **kwargs): if db_field.name == 'slice': - kwargs['queryset'] = Slice.select_by_user(request.user) + kwargs['queryset'] = Slice.select_by_user(request.user) if db_field.name == 'user': - kwargs['queryset'] = User.select_by_user(request.user) + kwargs['queryset'] = User.select_by_user(request.user) return super(SlicePrivilegeInline, self).formfield_for_foreignkey(db_field, request, **kwargs) @@ -384,7 +433,8 @@ class SliceNetworkInline(PlStackTabularInline): verbose_name = "Network Connection" verbose_name_plural = "Network Connections" suit_classes = 'suit-tab suit-tab-slicenetworks' - fields = ['network'] + fields = ['backend_status_icon', 'network'] + readonly_fields = ('backend_status_icon', ) class ImageDeploymentsInline(PlStackTabularInline): model = ImageDeployments @@ -392,33 +442,8 @@ class ImageDeploymentsInline(PlStackTabularInline): verbose_name = "Image Deployments" verbose_name_plural = "Image Deployments" suit_classes = 'suit-tab suit-tab-imagedeployments' - fields = ['image', 'deployment', 'glance_image_id'] - readonly_fields = ['glance_image_id'] - -class PlainTextWidget(forms.HiddenInput): - input_type = 'hidden' - - def render(self, name, value, attrs=None): - if value is None: - value = '' - return mark_safe(str(value) + super(PlainTextWidget, self).render(name, value, attrs)) - -class PlanetStackBaseAdmin(ReadOnlyAwareAdmin): - save_on_top = False - - def save_model(self, request, obj, form, change): - obj.caller = request.user - # update openstack connection to use this site/tenant - obj.save_by_user(request.user) - - def delete_model(self, request, obj): - obj.delete_by_user(request.user) - - def save_formset(self, request, form, formset, change): - instances = formset.save(commit=False) - for instance in instances: - instance.save_by_user(request.user) - formset.save_m2m() + fields = ['backend_status_icon', 'image', 'deployment', 'glance_image_id'] + readonly_fields = ['backend_status_icon', 'glance_image_id'] class SliceRoleAdmin(PlanetStackBaseAdmin): model = SliceRole @@ -445,8 +470,17 @@ class DeploymentAdminForm(forms.ModelForm): verbose_name=('Images'), is_stacked=False ) ) + flavors = forms.ModelMultipleChoiceField( + queryset=Flavor.objects.all(), + required=False, + help_text="Select which flavors should be usable on this deployment", + widget=FilteredSelectMultiple( + verbose_name=('Flavors'), is_stacked=False + ) + ) class Meta: model = Deployment + many_to_many = ["flavors",] def __init__(self, *args, **kwargs): request = kwargs.pop('request', None) @@ -457,6 +491,7 @@ class DeploymentAdminForm(forms.ModelForm): if self.instance and self.instance.pk: self.fields['sites'].initial = [x.site for x in self.instance.sitedeployments_set.all()] self.fields['images'].initial = [x.image for x in self.instance.imagedeployments_set.all()] + self.fields['flavors'].initial = self.instance.flavors.all() def manipulate_m2m_objs(self, this_obj, selected_objs, all_relations, relation_class, local_attrname, foreign_attrname): """ helper function for handling m2m relations from the MultipleChoiceField @@ -498,6 +533,8 @@ class DeploymentAdminForm(forms.ModelForm): if commit: deployment.save() + # this has to be done after save() if/when a deployment is first created + deployment.flavors = self.cleaned_data['flavors'] if deployment.pk: # save_m2m() doesn't seem to work with 'through' relations. So we @@ -507,7 +544,7 @@ class DeploymentAdminForm(forms.ModelForm): self.manipulate_m2m_objs(deployment, self.cleaned_data['sites'], deployment.sitedeployments_set.all(), SiteDeployments, "deployment", "site") self.manipulate_m2m_objs(deployment, self.cleaned_data['images'], deployment.imagedeployments_set.all(), ImageDeployments, "deployment", "image") - self.save_m2m() + self.save_m2m() return deployment @@ -522,9 +559,12 @@ class SiteAssocInline(PlStackTabularInline): class DeploymentAdmin(PlanetStackBaseAdmin): model = Deployment - fieldList = ['name','sites', 'images', 'accessControl'] + fieldList = ['backend_status_text', 'name', 'availability_zone', 'sites', 'images', 'flavors', 'accessControl'] fieldsets = [(None, {'fields': fieldList, 'classes':['suit-tab suit-tab-sites']})] inlines = [DeploymentPrivilegeInline,NodeInline,TagInline] # ,ImageDeploymentsInline] + list_display = ['backend_status_icon', 'name'] + list_display_links = ('backend_status_icon', 'name', ) + readonly_fields = ('backend_status_text', ) user_readonly_fields = ['name'] @@ -553,10 +593,12 @@ class ServiceAttrAsTabInline(PlStackTabularInline): suit_classes = 'suit-tab suit-tab-serviceattrs' class ServiceAdmin(PlanetStackBaseAdmin): - list_display = ("name","description","versionNumber","enabled","published") - fieldList = ["name","description","versionNumber","enabled","published"] + list_display = ("backend_status_icon","name","description","versionNumber","enabled","published") + list_display_links = ('backend_status_icon', 'name', ) + fieldList = ["backend_status_text","name","description","versionNumber","enabled","published"] fieldsets = [(None, {'fields': fieldList, 'classes':['suit-tab suit-tab-general']})] inlines = [ServiceAttrAsTabInline,SliceInline] + readonly_fields = ('backend_status_text', ) user_readonly_fields = fieldList @@ -566,7 +608,7 @@ class ServiceAdmin(PlanetStackBaseAdmin): ) class SiteAdmin(PlanetStackBaseAdmin): - fieldList = ['name', 'site_url', 'enabled', 'is_public', 'login_base', 'accountLink','location'] + fieldList = ['backend_status_text', 'name', 'site_url', 'enabled', 'is_public', 'login_base', 'accountLink','location'] fieldsets = [ (None, {'fields': fieldList, 'classes':['suit-tab suit-tab-general']}), #('Deployment Networks', {'fields': ['deployments'], 'classes':['suit-tab suit-tab-deployments']}), @@ -576,14 +618,15 @@ class SiteAdmin(PlanetStackBaseAdmin): ('siteprivileges','Privileges'), ('deployments','Deployments'), ('slices','Slices'), - ('nodes','Nodes'), + ('nodes','Nodes'), ('tags','Tags'), ) - readonly_fields = ['accountLink'] + readonly_fields = ['backend_status_text', 'accountLink'] user_readonly_fields = ['name', 'deployments','site_url', 'enabled', 'is_public', 'login_base', 'accountLink'] - list_display = ('name', 'login_base','site_url', 'enabled') + list_display = ('backend_status_icon', 'name', 'login_base','site_url', 'enabled') + list_display_links = ('backend_status_icon', 'name', ) filter_horizontal = ('deployments',) inlines = [SliceInline,UserInline,TagInline, NodeInline, SitePrivilegeInline, SiteDeploymentInline] search_fields = ['name'] @@ -629,11 +672,13 @@ class SiteAdmin(PlanetStackBaseAdmin): class SitePrivilegeAdmin(PlanetStackBaseAdmin): - fieldList = ['user', 'site', 'role'] + fieldList = ['backend_status_text', 'user', 'site', 'role'] fieldsets = [ (None, {'fields': fieldList, 'classes':['collapse']}) ] - list_display = ('user', 'site', 'role') + readonly_fields = ('backend_status_text', ) + list_display = ('backend_status_icon', 'user', 'site', 'role') + list_display_links = list_display user_readonly_fields = fieldList user_readonly_inlines = [] @@ -676,14 +721,25 @@ class SliceForm(forms.ModelForm): class Meta: model = Slice widgets = { - 'service': LinkedSelect + 'service': LinkedSelect } + def clean(self): + cleaned_data = super(SliceForm, self).clean() + name = cleaned_data.get('name') + site_id = cleaned_data.get('site') + site = Slice.objects.get(id=site_id) + if not name.startswith(site.login_base): + raise forms.ValidationError('slice name must begin with %s' % site.login_base) + return cleaned_data + class SliceAdmin(PlanetStackBaseAdmin): form = SliceForm - fieldList = ['name', 'site', 'serviceClass', 'enabled','description', 'service', 'slice_url', 'max_slivers'] + fieldList = ['backend_status_text', 'site', 'name', 'serviceClass', 'enabled','description', 'service', 'slice_url', 'max_slivers'] fieldsets = [('Slice Details', {'fields': fieldList, 'classes':['suit-tab suit-tab-general']}),] - list_display = ('name', 'site','serviceClass', 'slice_url', 'max_slivers') + readonly_fields = ('backend_status_text', ) + list_display = ('backend_status_icon', 'name', 'site','serviceClass', 'slice_url', 'max_slivers') + list_display_links = ('backend_status_icon', 'name', ) inlines = [SlicePrivilegeInline,SliverInline, TagInline, ReservationInline,SliceNetworkInline] user_readonly_fields = fieldList @@ -697,22 +753,35 @@ class SliceAdmin(PlanetStackBaseAdmin): ) def render_change_form(self, request, context, add=False, change=False, form_url='', obj=None): - #deployment_nodes = {} - #for node in Node.objects.all(): - # deployment_nodes[node.deployment.id] = get(deployment_nodes, node.deployment.id, []).append( (node.id, node.name) ) - deployment_nodes = [] for node in Node.objects.all(): deployment_nodes.append( (node.deployment.id, node.id, node.name) ) - context["deployment_nodes"] = deployment_nodes + deployment_flavors = [] + for flavor in Flavor.objects.all(): + for deployment in flavor.deployments.all(): + deployment_flavors.append( (deployment.id, flavor.id, flavor.name) ) + + deployment_images = [] + for image in Image.objects.all(): + for imageDeployment in image.imagedeployments_set.all(): + deployment_images.append( (imageDeployment.deployment.id, image.id, image.name) ) + + site_login_bases = [] + for site in Site.objects.all(): + site_login_bases.append((site.id, site.login_base)) + context["deployment_nodes"] = deployment_nodes + context["deployment_flavors"] = deployment_flavors + context["deployment_images"] = deployment_images + context["site_login_bases"] = site_login_bases return super(SliceAdmin, self).render_change_form(request, context, add, change, form_url, obj) def formfield_for_foreignkey(self, db_field, request, **kwargs): if db_field.name == 'site': kwargs['queryset'] = Site.select_by_user(request.user) - + kwargs['widget'] = forms.Select(attrs={'onChange': "update_slice_prefix(this, $($(this).closest('fieldset')[0]).find('.field-name input')[0].id)"}) + return super(SliceAdmin, self).formfield_for_foreignkey(db_field, request, **kwargs) def queryset(self, request): @@ -731,9 +800,11 @@ class SliceAdmin(PlanetStackBaseAdmin): class SlicePrivilegeAdmin(PlanetStackBaseAdmin): fieldsets = [ - (None, {'fields': ['user', 'slice', 'role']}) + (None, {'fields': ['backend_status_text', 'user', 'slice', 'role']}) ] - list_display = ('user', 'slice', 'role') + readonly_fields = ('backend_status_text', ) + list_display = ('backend_status_icon', 'user', 'slice', 'role') + list_display_links = list_display user_readonly_fields = ['user', 'slice', 'role'] user_readonly_inlines = [] @@ -769,10 +840,11 @@ class SlicePrivilegeAdmin(PlanetStackBaseAdmin): class ImageAdmin(PlanetStackBaseAdmin): - fieldsets = [('Image Details', - {'fields': ['name', 'disk_format', 'container_format'], + fieldsets = [('Image Details', + {'fields': ['backend_status_text', 'name', 'disk_format', 'container_format'], 'classes': ['suit-tab suit-tab-general']}) ] + readonly_fields = ('backend_status_text', ) suit_form_tabs =(('general','Image Details'),('slivers','Slivers'),('imagedeployments','Deployments')) @@ -780,6 +852,9 @@ class ImageAdmin(PlanetStackBaseAdmin): user_readonly_fields = ['name', 'disk_format', 'container_format'] + list_display = ['backend_status_icon', 'name'] + list_display_links = ('backend_status_icon', 'name', ) + class NodeForm(forms.ModelForm): class Meta: widgets = { @@ -789,11 +864,13 @@ class NodeForm(forms.ModelForm): class NodeAdmin(PlanetStackBaseAdmin): form = NodeForm - list_display = ('name', 'site', 'deployment') + list_display = ('backend_status_icon', 'name', 'site', 'deployment') + list_display_links = ('backend_status_icon', 'name', ) list_filter = ('deployment',) inlines = [TagInline,SliverInline] - fieldsets = [('Node Details', {'fields': ['name','site','deployment'], 'classes':['suit-tab suit-tab-details']})] + fieldsets = [('Node Details', {'fields': ['backend_status_text', 'name','site','deployment'], 'classes':['suit-tab suit-tab-details']})] + readonly_fields = ('backend_status_text', ) user_readonly_fields = ['name','site','deployment'] user_readonly_inlines = [TagInline,SliverInline] @@ -816,16 +893,19 @@ class SliverForm(forms.ModelForm): } class TagAdmin(PlanetStackBaseAdmin): - list_display = ['service', 'name', 'value', 'content_type', 'content_object',] + list_display = ['backend_status_icon', 'service', 'name', 'value', 'content_type', 'content_object',] + list_display_links = list_display user_readonly_fields = ['service', 'name', 'value', 'content_type', 'content_object',] user_readonly_inlines = [] class SliverAdmin(PlanetStackBaseAdmin): form = SliverForm fieldsets = [ - ('Sliver Details', {'fields': ['slice', 'deploymentNetwork', 'node', 'ip', 'instance_name', 'numberCores', 'image', ], 'classes': ['suit-tab suit-tab-general'], }) + ('Sliver Details', {'fields': ['backend_status_text', 'slice', 'deploymentNetwork', 'node', 'ip', 'instance_name', 'flavor', 'image', ], 'classes': ['suit-tab suit-tab-general'], }) ] - list_display = ['ip', 'instance_name', 'slice', 'numberCores', 'image', 'node', 'deploymentNetwork'] + readonly_fields = ('backend_status_text', ) + list_display = ['backend_status_icon', 'ip', 'instance_name', 'slice', 'flavor', 'image', 'node', 'deploymentNetwork'] + list_display_links = ('backend_status_icon', 'ip',) suit_form_tabs =(('general', 'Sliver Details'), ('tags','Tags'), @@ -833,7 +913,7 @@ class SliverAdmin(PlanetStackBaseAdmin): inlines = [TagInline] - user_readonly_fields = ['slice', 'deploymentNetwork', 'node', 'ip', 'instance_name', 'numberCores', 'image'] + user_readonly_fields = ['slice', 'deploymentNetwork', 'node', 'ip', 'instance_name', 'flavor', 'image'] def formfield_for_foreignkey(self, db_field, request, **kwargs): if db_field.name == 'slice': @@ -842,7 +922,7 @@ class SliverAdmin(PlanetStackBaseAdmin): return super(SliverAdmin, self).formfield_for_foreignkey(db_field, request, **kwargs) def queryset(self, request): - # admins can see all slivers. Users can only see slivers of + # admins can see all slivers. Users can only see slivers of # the slices they belong to. return Sliver.select_by_user(request.user) @@ -850,11 +930,11 @@ class SliverAdmin(PlanetStackBaseAdmin): def get_formsets(self, request, obj=None): # make some fields read only if we are updating an existing record if obj == None: - #self.readonly_fields = ('ip', 'instance_name') - self.readonly_fields = () + #self.readonly_fields = ('ip', 'instance_name') + self.readonly_fields = ('backend_status_text') else: - self.readonly_fields = () - #self.readonly_fields = ('ip', 'instance_name', 'slice', 'image', 'key') + self.readonly_fields = ('backend_status_text') + #self.readonly_fields = ('ip', 'instance_name', 'slice', 'image', 'key') for inline in self.get_inline_instances(request, obj): # hide MyInline in the add view @@ -930,7 +1010,10 @@ class UserDashboardViewInline(PlStackTabularInline): suit_classes = 'suit-tab suit-tab-dashboards' fields = ['user', 'dashboardView', 'order'] -class UserAdmin(UserAdmin): +class UserAdmin(PermissionCheckingAdminMixin, UserAdmin): + # Note: Make sure PermissionCheckingAdminMixin is listed before + # admin.ModelAdmin in the class declaration. + class Meta: app_label = "core" @@ -945,11 +1028,11 @@ class UserAdmin(UserAdmin): list_filter = ('site',) inlines = [SlicePrivilegeInline,SitePrivilegeInline,DeploymentPrivilegeInline,UserDashboardViewInline] - fieldListLoginDetails = ['email','site','password','is_active','is_readonly','is_admin','public_key'] + fieldListLoginDetails = ['backend_status_text', 'email','site','password','is_active','is_readonly','is_admin','public_key'] fieldListContactInfo = ['firstname','lastname','phone','timezone'] fieldsets = ( - ('Login Details', {'fields': ['email', 'site','password', 'is_active', 'is_readonly', 'is_admin', 'public_key'], 'classes':['suit-tab suit-tab-general']}), + ('Login Details', {'fields': ['backend_status_text', 'email', 'site','password', 'is_active', 'is_readonly', 'is_admin', 'public_key'], 'classes':['suit-tab suit-tab-general']}), ('Contact Information', {'fields': ('firstname','lastname','phone', 'timezone'), 'classes':['suit-tab suit-tab-contact']}), #('Dashboard Views', {'fields': ('dashboards',), 'classes':['suit-tab suit-tab-dashboards']}), #('Important dates', {'fields': ('last_login',)}), @@ -957,21 +1040,34 @@ class UserAdmin(UserAdmin): add_fieldsets = ( (None, { 'classes': ('wide',), - 'fields': ('email', 'firstname', 'lastname', 'is_readonly', 'phone', 'public_key','password1', 'password2')} + 'fields': ('email', 'firstname', 'lastname', 'is_readonly', 'phone', 'public_key','password1', 'password2')}, ), ) + readonly_fields = ('backend_status_text', ) search_fields = ('email',) ordering = ('email',) filter_horizontal = () user_readonly_fields = fieldListLoginDetails + fieldListContactInfo - suit_form_tabs =(('general','Login Details'), - ('contact','Contact Information'), - ('sliceprivileges','Slice Privileges'), - ('siteprivileges','Site Privileges'), - ('deploymentprivileges','Deployment Privileges'), - ('dashboards','Dashboard Views')) + def get_form(self, request, obj=None): + # Save obj in thread-local storage, so suit_form_tabs can use it to + # determine whether we're in edit or add mode. + _thread_locals.request = request + _thread_locals.obj = obj + return super(UserAdmin, self).get_form(request, obj) + + @property + def suit_form_tabs(self): + if getattr(_thread_locals, "obj", None) is None: + return [] + else: + return (('general','Login Details'), + ('contact','Contact Information'), + ('sliceprivileges','Slice Privileges'), + ('siteprivileges','Site Privileges'), + ('deploymentprivileges','Deployment Privileges'), + ('dashboards','Dashboard Views')) def formfield_for_foreignkey(self, db_field, request, **kwargs): if db_field.name == 'site': @@ -979,60 +1075,15 @@ class UserAdmin(UserAdmin): return super(UserAdmin, self).formfield_for_foreignkey(db_field, request, **kwargs) - def has_add_permission(self, request, obj=None): - return (not self.__user_is_readonly(request)) - - def has_delete_permission(self, request, obj=None): - return (not self.__user_is_readonly(request)) - - def get_actions(self,request): - actions = super(UserAdmin,self).get_actions(request) - - if self.__user_is_readonly(request): - if 'delete_selected' in actions: - del actions['delete_selected'] - - return actions - - def change_view(self,request,object_id, extra_context=None): - - if self.__user_is_readonly(request): - if not hasattr(self, "readonly_save"): - # save the original readonly fields - self.readonly_save = self.readonly_fields - self.inlines_save = self.inlines - if hasattr(self, "user_readonly_fields"): - self.readonly_fields=self.user_readonly_fields - if hasattr(self, "user_readonly_inlines"): - self.inlines = self.user_readonly_inlines - else: - if hasattr(self, "readonly_save"): - # restore the original readonly fields - self.readonly_fields = self.readonly_save - self.inlines = self.inlines_save - - try: - return super(UserAdmin, self).change_view(request, object_id, extra_context=extra_context) - except PermissionDenied: - pass - if request.method == 'POST': - raise PermissionDenied - request.readonly = True - return super(UserAdmin, self).change_view(request, object_id, extra_context=extra_context) - - def __user_is_readonly(self, request): - #groups = [x.name for x in request.user.groups.all() ] - #return "readonly" in groups - return request.user.isReadOnlyUser() - def queryset(self, request): return User.select_by_user(request.user) class DashboardViewAdmin(PlanetStackBaseAdmin): fieldsets = [('Dashboard View Details', - {'fields': ['name', 'url'], + {'fields': ['backend_status_text', 'name', 'url'], 'classes': ['suit-tab suit-tab-general']}) ] + readonly_fields = ('backend_status_text', ) suit_form_tabs =(('general','Dashboard View Details'),) @@ -1041,7 +1092,8 @@ class ServiceResourceInline(PlStackTabularInline): extra = 0 class ServiceClassAdmin(PlanetStackBaseAdmin): - list_display = ('name', 'commitment', 'membershipFee') + list_display = ('backend_status_icon', 'name', 'commitment', 'membershipFee') + list_display_links = ('backend_status_icon', 'name', ) inlines = [ServiceResourceInline] user_readonly_fields = ['name', 'commitment', 'membershipFee'] @@ -1127,8 +1179,9 @@ class ReservationAddRefreshForm(ReservationAddForm): return False class ReservationAdmin(PlanetStackBaseAdmin): - fieldList = ['slice', 'startTime', 'duration'] + fieldList = ['backend_status_text', 'slice', 'startTime', 'duration'] fieldsets = [('Reservation Details', {'fields': fieldList, 'classes': ['suit-tab suit-tab-general']})] + readonly_fields = ('backend_status_text', ) list_display = ('startTime', 'duration') form = ReservationAddForm @@ -1187,12 +1240,14 @@ class ReservationAdmin(PlanetStackBaseAdmin): return Reservation.select_by_user(request.user) class NetworkParameterTypeAdmin(PlanetStackBaseAdmin): - list_display = ("name", ) + list_display = ("backend_status_icon", "name", ) + list_display_links = ('backend_status_icon', 'name', ) user_readonly_fields = ['name'] user_readonly_inlines = [] class RouterAdmin(PlanetStackBaseAdmin): - list_display = ("name", ) + list_display = ("backend_status_icon", "name", ) + list_display_links = ('backend_status_icon', 'name', ) user_readonly_fields = ['name'] user_readonly_inlines = [] @@ -1209,11 +1264,12 @@ class NetworkParameterInline(PlStackGenericTabularInline): verbose_name_plural = "Parameters" verbose_name = "Parameter" suit_classes = 'suit-tab suit-tab-netparams' - fields = ['parameter', 'value'] + fields = ['backend_status_icon', 'parameter', 'value'] + readonly_fields = ('backend_status_icon', ) class NetworkSliversInline(PlStackTabularInline): - fields = ['network','sliver','ip'] - readonly_fields = ("ip", ) + fields = ['backend_status_icon', 'network','sliver','ip'] + readonly_fields = ("backend_status_icon", "ip", ) model = NetworkSliver selflink_fieldname = "sliver" extra = 0 @@ -1228,17 +1284,20 @@ class NetworkSlicesInline(PlStackTabularInline): verbose_name_plural = "Slices" verbose_name = "Slice" suit_classes = 'suit-tab suit-tab-networkslices' - fields = ['network','slice'] + fields = ['backend_status_icon', 'network','slice'] + readonly_fields = ('backend_status_icon', ) class NetworkAdmin(PlanetStackBaseAdmin): - list_display = ("name", "subnet", "ports", "labels") + list_display = ("backend_status_icon", "name", "subnet", "ports", "labels") + list_display_links = ('backend_status_icon', 'name', ) readonly_fields = ("subnet", ) inlines = [NetworkParameterInline, NetworkSliversInline, NetworkSlicesInline, RouterInline] fieldsets = [ - (None, {'fields': ['name','template','ports','labels','owner','guaranteedBandwidth', 'permitAllSlices','permittedSlices','network_id','router_id','subnet_id','subnet'], 'classes':['suit-tab suit-tab-general']}),] + (None, {'fields': ['backend_status_text', 'name','template','ports','labels','owner','guaranteedBandwidth', 'permitAllSlices','permittedSlices','network_id','router_id','subnet_id','subnet'], 'classes':['suit-tab suit-tab-general']}),] + readonly_fields = ('backend_status_text', ) user_readonly_fields = ['name','template','ports','labels','owner','guaranteedBandwidth', 'permitAllSlices','permittedSlices','network_id','router_id','subnet_id','subnet'] suit_form_tabs =( @@ -1249,10 +1308,17 @@ class NetworkAdmin(PlanetStackBaseAdmin): ('routers','Routers'), ) class NetworkTemplateAdmin(PlanetStackBaseAdmin): - list_display = ("name", "guaranteedBandwidth", "visibility") + list_display = ("backend_status_icon", "name", "guaranteedBandwidth", "visibility") + list_display_links = ('backend_status_icon', 'name', ) user_readonly_fields = ["name", "guaranteedBandwidth", "visibility"] user_readonly_inlines = [] +class FlavorAdmin(PlanetStackBaseAdmin): + list_display = ("backend_status_icon", "name", "flavor", "order", "default") + list_display_links = ("backend_status_icon", "name") + user_readonly_fields = ("name", "flavor") + fields = ("name", "description", "flavor", "order", "default") + # register a signal that caches the user's credentials when they log in def cache_credentials(sender, user, request, **kwds): auth = {'username': request.POST['username'], @@ -1371,7 +1437,6 @@ class AccountAdmin(admin.ModelAdmin): dollar_total_invoices = dollar_field("total_invoices", "Total Invoices") dollar_total_payments = dollar_field("total_payments", "Total Payments") - # Now register the new UserAdmin... admin.site.register(User, UserAdmin) # ... and, since we're not using Django's builtin permissions, @@ -1414,4 +1479,5 @@ if True: admin.site.register(Sliver, SliverAdmin) admin.site.register(Image, ImageAdmin) admin.site.register(DashboardView, DashboardViewAdmin) + admin.site.register(Flavor, FlavorAdmin)