X-Git-Url: http://git.onelab.eu/?a=blobdiff_plain;f=plugins%2Frawdisk.py;h=616d2c605ea1e84d7f407b47717c154e6f025423;hb=1b4f53e648b13f7629970787b6ec03387e2d966a;hp=6d6e0f05e2b579eff585655280654c844747f152;hpb=6f3c475c348307db846d9b9675cefabf95416856;p=nodemanager.git diff --git a/plugins/rawdisk.py b/plugins/rawdisk.py index 6d6e0f0..616d2c6 100644 --- a/plugins/rawdisk.py +++ b/plugins/rawdisk.py @@ -1,9 +1,6 @@ #!/usr/bin/python -tt # vim:set ts=4 sw=4 expandtab: # -# $Id$ -# $URL$ -# # NodeManager plugin to support mapping unused raw disks into a slice # that has the rawdisk sliver tag @@ -36,19 +33,19 @@ def get_unused_devices(): in_vg.extend(map(lambda x: x.replace("!", "/"), os.listdir("/sys/block/%s/slaves" % i))) # Read the list of partitions - partitions = file("/proc/partitions", "r") - pat = re.compile("\s+") - while True: - buf = partitions.readline() - if buf == "": - break - buf = buf.strip() - fields = re.split(pat, buf) - dev = fields[-1] - if (not dev.startswith("dm-") and dev not in in_vg and - os.path.exists("/dev/%s" % dev) and - (os.minor(os.stat("/dev/%s" % dev).st_rdev) % 2) != 0): - devices.append("/dev/%s" % dev) + with open("/proc/partitions") as partitions: + pat = re.compile("\s+") + while True: + buf = partitions.readline() + if buf == "": + break + buf = buf.strip() + fields = re.split(pat, buf) + dev = fields[-1] + if (not dev.startswith("dm-") and dev not in in_vg and + os.path.exists("/dev/%s" % dev) and + (os.minor(os.stat("/dev/%s" % dev).st_rdev) % 2) != 0): + devices.append("/dev/%s" % dev) partitions.close() return devices