X-Git-Url: http://git.onelab.eu/?a=blobdiff_plain;f=plugins%2Frawdisk.py;h=9f80c157efcaa9c6d01d2640f54d3de5febfad92;hb=HEAD;hp=f64affec3f8b2ee619993b94750abd9fa2c65778;hpb=55afbcaa2f8e9646bec3962e406f150f5d31b47b;p=nodemanager.git

diff --git a/plugins/rawdisk.py b/plugins/rawdisk.py
index f64affe..9f80c15 100644
--- a/plugins/rawdisk.py
+++ b/plugins/rawdisk.py
@@ -1,4 +1,4 @@
-#!/usr/bin/python -tt
+#!/usr/bin/python3 -tt
 # vim:set ts=4 sw=4 expandtab:
 #
 # NodeManager plugin to support mapping unused raw disks into a slice
@@ -30,34 +30,33 @@ def get_unused_devices():
     for i in os.listdir("/sys/block"):
         if not i.startswith("dm-"):
             continue
-        in_vg.extend(map(lambda x: x.replace("!", "/"),
-                         os.listdir("/sys/block/%s/slaves" % i)))
+        in_vg.extend([x.replace("!", "/") for x in os.listdir("/sys/block/%s/slaves" % i)])
     # Read the list of partitions
-    partitions = file("/proc/partitions", "r")
-    pat = re.compile("\s+")
-    while True:
-        buf = partitions.readline()
-        if buf == "":
-            break
-        buf = buf.strip()
-        fields = re.split(pat, buf)
-        dev = fields[-1]
-        if (not dev.startswith("dm-") and dev not in in_vg and
-            os.path.exists("/dev/%s" % dev) and
-            (os.minor(os.stat("/dev/%s" % dev).st_rdev) % 2) != 0):
-            devices.append("/dev/%s" % dev)
+    with open("/proc/partitions") as partitions:
+        pat = re.compile("\s+")
+        while True:
+            buf = partitions.readline()
+            if buf == "":
+                break
+            buf = buf.strip()
+            fields = re.split(pat, buf)
+            dev = fields[-1]
+            if (not dev.startswith("dm-") and dev not in in_vg and
+                os.path.exists("/dev/%s" % dev) and
+                (os.minor(os.stat("/dev/%s" % dev).st_rdev) % 2) != 0):
+                devices.append("/dev/%s" % dev)
     partitions.close()
     return devices
 
 def GetSlivers(data, config=None, plc=None):
     if 'slivers' not in data:
-        logger.log_missing_data("rawdisk.GetSlivers",'slivers')
+        logger.log_missing_data("rawdisk.GetSlivers", 'slivers')
         return
 
     devices = get_unused_devices()
     for sliver in data['slivers']:
         for attribute in sliver['attributes']:
-            name = attribute.get('tagname',attribute.get('name',''))
+            name = attribute.get('tagname', attribute.get('name', ''))
             if name == 'rawdisk':
                 for i in devices:
                     st = os.stat(i)
@@ -73,7 +72,7 @@ def GetSlivers(data, config=None, plc=None):
                     except:
                         pass
                     try:
-                        os.makedirs(os.path.dirname(path), 0755)
+                        os.makedirs(os.path.dirname(path), 0o755)
                     except:
                         pass
                     os.mknod(path, st.st_mode, st.st_rdev)