X-Git-Url: http://git.onelab.eu/?a=blobdiff_plain;f=plugins%2Fsliverauth.py;h=07986500cfe9360de78480602f19da4d2fdf5153;hb=605b4ac989b43eba6768cf7dc285ffc19a47e7f1;hp=9e872c528944e55b98ee6eb9a71e74a39c438320;hpb=19cafbf5fcf1b1275b6184b9e076412f5fc1d035;p=nodemanager.git

diff --git a/plugins/sliverauth.py b/plugins/sliverauth.py
index 9e872c5..0798650 100644
--- a/plugins/sliverauth.py
+++ b/plugins/sliverauth.py
@@ -1,14 +1,13 @@
 #!/usr/bin/python -tt
 # vim:set ts=4 sw=4 expandtab:
 #
-# $Id$
-# $URL$
-#
 # NodeManager plugin for creating credentials in slivers
 # (*) empower slivers to make API calls throught hmac
 # (*) also create a ssh key - used by the OMF resource controller 
 #     for authenticating itself with its Experiment Controller
-# xxx todo : a config option for turning these 2 things on or off ?
+# in order to avoid spamming the DB with huge amounts of such tags,
+# (*) slices need to have the 'enable_hmac' tag set
+# (*) or the 'omf_control' tag set, respectively
 
 """
 Sliver authentication support for NodeManager.
@@ -46,10 +45,17 @@ def GetSlivers(data, config, plc):
                 logger.log("sliverauth: plc-instantiated slice %s does not yet exist. IGNORING!" % sliver['name'])
             continue
 
+        system_slice = False
+        for chunk in sliver['attributes']:
+            if chunk['tagname'] == "system":
+                if chunk['value'] in (True, 1, '1') or chunk['value'].lower() == "true":
+                    system_slice = True
+
         for chunk in sliver['attributes']:
-            if chunk['tagname']=='enable_hmac':
+            if chunk['tagname']=='enable_hmac' and not system_slice:
                 manage_hmac (plc, sliver)
-            elif chunk['tagname']=='omf_control':
+
+            if chunk['tagname']=='omf_control':
                 manage_sshkey (plc, sliver)