X-Git-Url: http://git.onelab.eu/?a=blobdiff_plain;f=python%2Fvserverimpl.c;h=931357b71b18b3203c8140352b1058cf4d644a21;hb=322d0b4dbdc5b5621e2deb7e4188a64fce95e5aa;hp=9d4a50373367316df77e9aaa9b1ec0d4362f2be3;hpb=5eaf3d83ac6661e3ac227849e997f7c20b948bf1;p=util-vserver-pl.git diff --git a/python/vserverimpl.c b/python/vserverimpl.c index 9d4a503..931357b 100644 --- a/python/vserverimpl.c +++ b/python/vserverimpl.c @@ -59,6 +59,8 @@ static inline PyObject *inc_and_ret_none(void) #define NONE inc_and_ret_none() +#define PL_INSECURE_BCAPS (vc_get_insecurebcaps() | (1 << VC_CAP_NET_BIND_SERVICE)) + /* * context create */ @@ -71,7 +73,7 @@ vserver_chcontext(PyObject *self, PyObject *args) if (!PyArg_ParseTuple(args, "I|K", &ctx, &bcaps)) return NULL; - bcaps |= ~(vc_get_insecurebcaps() | (1 << VC_CAP_NET_BIND_SERVICE)); + bcaps |= ~PL_INSECURE_BCAPS; if ((ctx_is_new = pl_chcontext(ctx, bcaps, 0)) < 0) return PyErr_SetFromErrno(PyExc_OSError); @@ -301,7 +303,7 @@ vserver_set_bcaps(PyObject *self, PyObject *args) if (!PyArg_ParseTuple(args, "IK", &ctx, &caps.bcaps)) return NULL; - caps.bmask = vc_get_insecurebcaps(); + caps.bmask = PL_INSECURE_BCAPS; caps.cmask = caps.ccaps = 0; if (vc_set_ccaps(ctx, &caps) == -1 && errno != ESRCH) return PyErr_SetFromErrno(PyExc_OSError); @@ -341,7 +343,7 @@ vserver_get_bcaps(PyObject *self, PyObject *args) caps.bcaps = 0; } - return Py_BuildValue("K", caps.bcaps & vc_get_insecurebcaps()); + return Py_BuildValue("K", caps.bcaps & PL_INSECURE_BCAPS); } static PyObject * @@ -450,24 +452,35 @@ get_mask(struct vc_net_addr *addr) static PyObject * vserver_net_add(PyObject *self, PyObject *args) { - struct vc_net_addr addr; + struct vc_net_addr addr = { .vna_type = 0 }; nid_t nid; const char *ip; if (!PyArg_ParseTuple(args, "Is", &nid, &ip)) return NULL; - if (convert_address(ip, &addr) == -1) - return PyErr_Format(PyExc_ValueError, "%s is not a valid IP address", ip); + /* Optimize standard case, which also needs to be handled differently */ + if (strcmp(ip, "0.0.0.0") == 0) { + addr.vna_type = VC_NXA_TYPE_MASK | VC_NXA_TYPE_IPV4; + addr.vna_flags = 0; + addr.vna_prefix = 0; + addr.vna_parent = 0; + addr.vna_v4_mask.s_addr = 0; + addr.vna_v4_ip.s_addr = 0; + } + else { + if (convert_address(ip, &addr) == -1) + return PyErr_Format(PyExc_ValueError, "%s is not a valid IP address", ip); - switch (get_mask(&addr)) { - case -1: - return PyErr_SetFromErrno(PyExc_OSError); - case 0: - /* XXX error here? */ - break; + switch (get_mask(&addr)) { + case -1: + return PyErr_SetFromErrno(PyExc_OSError); + case 0: + /* XXX error here? */ + break; + } + addr.vna_type |= VC_NXA_TYPE_ADDR; } - addr.vna_type |= VC_NXA_TYPE_ADDR; if (vc_net_add(nid, &addr) == -1 && errno != ESRCH) return PyErr_SetFromErrno(PyExc_OSError); @@ -599,7 +612,7 @@ vserver_mount(PyObject *self, PyObject *args) if (secure_chdir(&dirs, guest, target) == -1) goto out; - if (mount(source, ".", type, flags, data) == -1) + if (mount(source, ".", type, flags, data) == -1 && errno != EBUSY) goto out; restore_dirs(&dirs); @@ -653,6 +666,43 @@ vserver_set_runlevel(PyObject *self, PyObject *args) return NONE; } +static PyObject * +vserver_set_name(PyObject *self, PyObject *args) +{ + xid_t ctx, slice_id; + char buf[sizeof(long int)*3+2]; + PyObject *ret; + + if (!PyArg_ParseTuple(args, "II", &ctx, &slice_id)) + return NULL; + + snprintf(buf, sizeof(buf), "%d", slice_id); + + if (vc_set_vhi_name(ctx, vcVHI_CONTEXT, buf, sizeof(buf)) != 0) { + return PyErr_SetFromErrno(PyExc_OSError); + } else { + return NONE; + } +} + +static PyObject * +vserver_get_name(PyObject *self, PyObject *args) +{ + xid_t ctx; + char buf[sizeof(long int)*3+2]; + PyObject *ret; + + if (!PyArg_ParseTuple(args, "I", &ctx)) + return NULL; + + if (vc_get_vhi_name(ctx, vcVHI_CONTEXT, buf, sizeof(buf)) !=0 ) { + ret = PyErr_SetFromErrno(PyExc_OSError); + } else { + ret = Py_BuildValue("i", atoi(buf)); + } + return ret; +} + static PyMethodDef methods[] = { { "chcontext", vserver_chcontext, METH_VARARGS, "chcontext to vserver with provided flags" }, @@ -692,6 +742,10 @@ static PyMethodDef methods[] = { "Perform the umount2() system call" }, { "setrunlevel", vserver_set_runlevel, METH_VARARGS, "Set the runlevel in utmp" }, + { "setname", vserver_set_name, METH_VARARGS, + "Set the vcVHI_CONTEXT for a xid." }, + { "getname", vserver_get_name, METH_VARARGS, + "Get the vcVHI_CONTEXT for a xid." }, { NULL, NULL, 0, NULL } };