X-Git-Url: http://git.onelab.eu/?a=blobdiff_plain;f=python%2Fvserverimpl.c;h=b9a06aac0fc33d3fe069db1a006821110f29fa36;hb=b3b13854c590539cd50196c3b671f1b5315f84c9;hp=9d4a50373367316df77e9aaa9b1ec0d4362f2be3;hpb=5eaf3d83ac6661e3ac227849e997f7c20b948bf1;p=util-vserver-pl.git diff --git a/python/vserverimpl.c b/python/vserverimpl.c index 9d4a503..b9a06aa 100644 --- a/python/vserverimpl.c +++ b/python/vserverimpl.c @@ -59,6 +59,9 @@ static inline PyObject *inc_and_ret_none(void) #define NONE inc_and_ret_none() +#define PL_INSECURE_BCAPS (vc_get_insecurebcaps() | (1 << VC_CAP_NET_BIND_SERVICE)) +#define PL_INSECURE_CCAPS vc_get_insecureccaps() + /* * context create */ @@ -71,7 +74,7 @@ vserver_chcontext(PyObject *self, PyObject *args) if (!PyArg_ParseTuple(args, "I|K", &ctx, &bcaps)) return NULL; - bcaps |= ~(vc_get_insecurebcaps() | (1 << VC_CAP_NET_BIND_SERVICE)); + bcaps |= ~PL_INSECURE_BCAPS; if ((ctx_is_new = pl_chcontext(ctx, bcaps, 0)) < 0) return PyErr_SetFromErrno(PyExc_OSError); @@ -301,7 +304,7 @@ vserver_set_bcaps(PyObject *self, PyObject *args) if (!PyArg_ParseTuple(args, "IK", &ctx, &caps.bcaps)) return NULL; - caps.bmask = vc_get_insecurebcaps(); + caps.bmask = PL_INSECURE_BCAPS; caps.cmask = caps.ccaps = 0; if (vc_set_ccaps(ctx, &caps) == -1 && errno != ESRCH) return PyErr_SetFromErrno(PyExc_OSError); @@ -335,13 +338,13 @@ vserver_get_bcaps(PyObject *self, PyObject *args) return NULL; if (vc_get_ccaps(ctx, &caps) == -1) { - if (errno != -ESRCH) + if (errno != ESRCH) return PyErr_SetFromErrno(PyExc_OSError); else caps.bcaps = 0; } - return Py_BuildValue("K", caps.bcaps & vc_get_insecurebcaps()); + return Py_BuildValue("K", caps.bcaps & PL_INSECURE_BCAPS); } static PyObject * @@ -367,6 +370,81 @@ vserver_bcaps2text(PyObject *self, PyObject *args) return list; } +static PyObject * +vserver_set_ccaps(PyObject *self, PyObject *args) +{ + xid_t ctx; + struct vc_ctx_caps caps; + + if (!PyArg_ParseTuple(args, "IK", &ctx, &caps.ccaps)) + return NULL; + + caps.cmask = PL_INSECURE_CCAPS; + caps.bmask = caps.bcaps = 0; + if (vc_set_ccaps(ctx, &caps) == -1 && errno != ESRCH) + return PyErr_SetFromErrno(PyExc_OSError); + + return NONE; +} + +static PyObject * +vserver_text2ccaps(PyObject *self, PyObject *args) +{ + struct vc_ctx_caps caps = { .ccaps = 0 }; + const char *list; + int len; + struct vc_err_listparser err; + + if (!PyArg_ParseTuple(args, "s#", &list, &len)) + return NULL; + + vc_list2ccap(list, len, &err, &caps); + + return Py_BuildValue("K", caps.ccaps); +} + +static PyObject * +vserver_get_ccaps(PyObject *self, PyObject *args) +{ + xid_t ctx; + struct vc_ctx_caps caps; + + if (!PyArg_ParseTuple(args, "I", &ctx)) + return NULL; + + if (vc_get_ccaps(ctx, &caps) == -1) { + if (errno != ESRCH) + return PyErr_SetFromErrno(PyExc_OSError); + else + caps.ccaps = 0; + } + + return Py_BuildValue("K", caps.ccaps & PL_INSECURE_CCAPS); +} + +static PyObject * +vserver_ccaps2text(PyObject *self, PyObject *args) +{ + struct vc_ctx_caps caps = { .ccaps = 0 }; + PyObject *list; + const char *cap; + + if (!PyArg_ParseTuple(args, "K", &caps.ccaps)) + return NULL; + + list = PyString_FromString(""); + + while ((cap = vc_loccap2text(&caps.ccaps)) != NULL) { + if (list == NULL) + break; + PyString_ConcatAndDel(&list, PyString_FromFormat( + (PyString_Size(list) > 0 ? ",%s" : "%s" ), + cap)); + } + + return list; +} + static inline int convert_address(const char *str, struct vc_net_addr *addr) { @@ -450,24 +528,35 @@ get_mask(struct vc_net_addr *addr) static PyObject * vserver_net_add(PyObject *self, PyObject *args) { - struct vc_net_addr addr; + struct vc_net_addr addr = { .vna_type = 0 }; nid_t nid; const char *ip; if (!PyArg_ParseTuple(args, "Is", &nid, &ip)) return NULL; - if (convert_address(ip, &addr) == -1) - return PyErr_Format(PyExc_ValueError, "%s is not a valid IP address", ip); + /* Optimize standard case, which also needs to be handled differently */ + if (strcmp(ip, "0.0.0.0") == 0) { + addr.vna_type = VC_NXA_TYPE_MASK | VC_NXA_TYPE_IPV4; + addr.vna_flags = 0; + addr.vna_prefix = 0; + addr.vna_parent = 0; + addr.vna_v4_mask.s_addr = 0; + addr.vna_v4_ip.s_addr = 0; + } + else { + if (convert_address(ip, &addr) == -1) + return PyErr_Format(PyExc_ValueError, "%s is not a valid IP address", ip); - switch (get_mask(&addr)) { - case -1: - return PyErr_SetFromErrno(PyExc_OSError); - case 0: - /* XXX error here? */ - break; + switch (get_mask(&addr)) { + case -1: + return PyErr_SetFromErrno(PyExc_OSError); + case 0: + /* XXX error here? */ + break; + } + addr.vna_type |= VC_NXA_TYPE_ADDR; } - addr.vna_type |= VC_NXA_TYPE_ADDR; if (vc_net_add(nid, &addr) == -1 && errno != ESRCH) return PyErr_SetFromErrno(PyExc_OSError); @@ -599,7 +688,7 @@ vserver_mount(PyObject *self, PyObject *args) if (secure_chdir(&dirs, guest, target) == -1) goto out; - if (mount(source, ".", type, flags, data) == -1) + if (mount(source, ".", type, flags, data) == -1 && errno != EBUSY) goto out; restore_dirs(&dirs); @@ -653,6 +742,39 @@ vserver_set_runlevel(PyObject *self, PyObject *args) return NONE; } +static PyObject * +vserver_set_name(PyObject *self, PyObject *args) +{ + xid_t ctx, slice_id; + PyObject *ret; + + if (!PyArg_ParseTuple(args, "II", &ctx, &slice_id)) + return NULL; + + if (vc_set_vhi_name(ctx, vcVHI_CONTEXT, (char *)&slice_id, sizeof(slice_id)) != 0 && errno != ESRCH) { + return PyErr_SetFromErrno(PyExc_OSError); + } else { + return NONE; + } +} + +static PyObject * +vserver_get_name(PyObject *self, PyObject *args) +{ + xid_t ctx, slice_id; + PyObject *ret; + + if (!PyArg_ParseTuple(args, "I", &ctx)) + return NULL; + + if (vc_get_vhi_name(ctx, vcVHI_CONTEXT, (char *)&slice_id, sizeof(slice_id)) != 0) { + ret = PyErr_SetFromErrno(PyExc_OSError); + } else { + ret = Py_BuildValue("i", slice_id); + } + return ret; +} + static PyMethodDef methods[] = { { "chcontext", vserver_chcontext, METH_VARARGS, "chcontext to vserver with provided flags" }, @@ -682,6 +804,14 @@ static PyMethodDef methods[] = { "Translate a string of capabilities to a bitmap" }, { "bcaps2text", vserver_bcaps2text, METH_VARARGS, "Translate a capability-bitmap into a string" }, + { "setccaps", vserver_set_ccaps, METH_VARARGS, + "Set context capabilities of a vserver context" }, + { "getccaps", vserver_get_ccaps, METH_VARARGS, + "Get context capabilities of a vserver context" }, + { "text2ccaps", vserver_text2ccaps, METH_VARARGS, + "Translate a string of context capabilities to a bitmap" }, + { "ccaps2text", vserver_ccaps2text, METH_VARARGS, + "Translate a context-capability-bitmap into a string" }, { "netadd", vserver_net_add, METH_VARARGS, "Assign an IP address to a context" }, { "netremove", vserver_net_remove, METH_VARARGS, @@ -692,6 +822,10 @@ static PyMethodDef methods[] = { "Perform the umount2() system call" }, { "setrunlevel", vserver_set_runlevel, METH_VARARGS, "Set the runlevel in utmp" }, + { "setname", vserver_set_name, METH_VARARGS, + "Set the vcVHI_CONTEXT for a xid." }, + { "getname", vserver_get_name, METH_VARARGS, + "Get the vcVHI_CONTEXT for a xid." }, { NULL, NULL, 0, NULL } };