X-Git-Url: http://git.onelab.eu/?a=blobdiff_plain;f=safexmlrpc.py;h=2392c0dffecd785fbd975c192a355de921bd5dca;hb=e57432c1dfdfeaa52cc32799e2abbc34b7704ce9;hp=7961a7570cd096bbfce4cba572aea5ae1b38ef5f;hpb=906866e3163a156c4e64ae871b08f599168c33f3;p=nodemanager.git

diff --git a/safexmlrpc.py b/safexmlrpc.py
index 7961a75..2392c0d 100644
--- a/safexmlrpc.py
+++ b/safexmlrpc.py
@@ -1,10 +1,12 @@
 """Leverage curl to make XMLRPC requests that check the server's credentials."""
 
-import curlwrapper
 import xmlrpclib
 
+import curlwrapper
+
+
+class CertificateCheckingSafeTransport (xmlrpclib.Transport):
 
-class CertificateCheckingSafeTransport(xmlrpclib.Transport):
     def __init__(self, cacert, timeout):
         self.cacert = cacert
         self.timeout = timeout
@@ -12,18 +14,15 @@ class CertificateCheckingSafeTransport(xmlrpclib.Transport):
     def request(self, host, handler, request_body, verbose=0):
         self.verbose = verbose
         url='https://%s%s' % (host, handler)
-        try:
-            contents = curlwrapper.retrieve(url,
-                                            cacert = self.cacert,
-                                            postdata = request_body,
-                                            timeout = self.timeout)
-            return xmlrpclib.loads(contents)[0]
-        except curlwrapper.CurlException, e:
-            # when this triggers, the error sometimes doesn't get printed
-            print 'CertificateCheckingSafeTransport.request: Catching curlwrapper.CurlException with error <%s>'%str(e)
-            raise xmlrpclib.ProtocolError(url, -1, str(e), request_body)
+        # this might raise an xmlrpclib.Protocolerror exception
+        contents = curlwrapper.retrieve(url,
+                                        cacert = self.cacert,
+                                        postdata = request_body,
+                                        timeout = self.timeout)
+        return xmlrpclib.loads(contents)[0]
 
 class ServerProxy(xmlrpclib.ServerProxy):
+
     def __init__(self, uri, cacert, timeout = 300, **kwds):
         xmlrpclib.ServerProxy.__init__(self, uri,
                                        CertificateCheckingSafeTransport(cacert, timeout),