X-Git-Url: http://git.onelab.eu/?a=blobdiff_plain;f=sfa%2Fmethods%2FRenewSliver.py;h=a380d992b76bc6e7ebe1e78e8d15072150622c83;hb=cf630d87d633f3861e3ac8a50433fa29ca46a74e;hp=3b965ff68188de5640f5bdd8b631b4231b85e304;hpb=1d89a61f9d8e6147459c13c134e30decffa270f7;p=sfa.git

diff --git a/sfa/methods/RenewSliver.py b/sfa/methods/RenewSliver.py
index 3b965ff6..a380d992 100644
--- a/sfa/methods/RenewSliver.py
+++ b/sfa/methods/RenewSliver.py
@@ -1,9 +1,14 @@
-from sfa.util.faults import *
-from sfa.util.namespace import *
+import datetime
+
+from sfa.util.faults import InsufficientRights
+from sfa.util.xrn import urn_to_hrn
 from sfa.util.method import Method
-from sfa.util.parameter import Parameter
+from sfa.util.sfatime import utcparse
+
 from sfa.trust.credential import Credential
 
+from sfa.storage.parameter import Parameter
+
 class RenewSliver(Method):
     """
     Renews the resources in a sliver, extending the lifetime of the slice.    
@@ -16,12 +21,14 @@ class RenewSliver(Method):
     accepts = [
         Parameter(str, "Slice URN"),
         Parameter(type([str]), "List of credentials"),
-        Parameter(str, "Expiration time in RFC 3339 format")
+        Parameter(str, "Expiration time in RFC 3339 format"),
+        Parameter(dict, "Options"),
         ]
     returns = Parameter(bool, "Success or Failure")
 
-    def call(self, slice_xrn, creds, expiration_time):
-        hrn, type = urn_to_hrn(slice_xrn)
+    def call(self, slice_xrn, creds, expiration_time, options={}):
+
+        (hrn, type) = urn_to_hrn(slice_xrn)
 
         self.api.logger.info("interface: %s\ttarget-hrn: %s\tcaller-creds: %s\tmethod-name: %s"%(self.api.interface, hrn, creds, self.name))
 
@@ -29,12 +36,11 @@ class RenewSliver(Method):
         valid_creds = self.api.auth.checkCredentials(creds, 'renewsliver', hrn)
 
         # Validate that the time does not go beyond the credential's expiration time
-        requested_time = parse(expiration_time)
+        requested_time = utcparse(expiration_time)
+        max_renew_days = int(self.api.config.SFA_MAX_SLICE_RENEW)
         if requested_time > Credential(string=valid_creds[0]).get_expiration():
-            raise InsufficientRights('SliverStatus: Credential expires before requested expiration time')
-       
-        manager = self.api.get_interface_manager()
-        manager.renew_slice(self.api, slice_xrn, valid_creds, expiration_time)    
- 
-        return 1
+            raise InsufficientRights('Renewsliver: Credential expires before requested expiration time')
+        if requested_time > datetime.datetime.utcnow() + datetime.timedelta(days=max_renew_days):
+            raise Exception('Cannot renew > %s days from now' % max_renew_days)
+        return self.api.manager.RenewSliver(self.api, slice_xrn, valid_creds, expiration_time, options)