X-Git-Url: http://git.onelab.eu/?a=blobdiff_plain;f=sfa%2Fopenstack%2Fsecurity_group.py;h=70e191e5f09bd7811e76d06563a83632dd234f61;hb=cc8495078fb3e681cf38b47393255eb33b199f4c;hp=32f86fb1d1579c67a2d87b3831cb9ff95b69a335;hpb=e8b16b96a23e1ab54e780587cc7cc0345a1ddf0e;p=sfa.git

diff --git a/sfa/openstack/security_group.py b/sfa/openstack/security_group.py
index 32f86fb1..70e191e5 100644
--- a/sfa/openstack/security_group.py
+++ b/sfa/openstack/security_group.py
@@ -8,13 +8,15 @@ class SecurityGroup:
         
     def create_security_group(self, name):
         try:
-            self.client.security_groups.create(name=name, description="")
+            self.client.security_groups.create(name=name, description=name)
         except Exception, ex:
             logger.log_exc("Failed to add security group")
+            raise
 
     def delete_security_group(self, name):
         try:
-            self.client.security_groups(name=name)
+            security_group = self.client.security_groups.find(name=name)
+            self.client.security_groups.delete(security_group.id)
         except Exception, ex:
             logger.log_exc("Failed to delete security group")
 
@@ -54,13 +56,8 @@ class SecurityGroup:
                 from_port, to_port = icmp_type[0], icmp_type[1]
 
             group = self.client.security_groups.find(name=group_name)
-            self.client.security_group_rules.create(
-                    group_id=group.id,    
-                    ip_protocol=protocol,
-                    from_port=from_port,
-                    to_port=to_port,
-                    cidr_ip=cidr_ip,
-                    )
+            self.client.security_group_rules.create(group.id, \
+                                protocol, from_port, to_port,cidr_ip)
         except Exception, ex:
             logger.log_exc("Failed to add rule to group %s" % group_name)
 
@@ -78,7 +75,7 @@ class SecurityGroup:
                 'id': group.id,   
                 'from_port': from_port,
                 'to_port': to_port,
-                'cird_ip': ip,
+                'cidr_ip': ip,
                 'ip_protocol':protocol,
             }
             rule = self.client.security_group_rules.find(**filter)