X-Git-Url: http://git.onelab.eu/?a=blobdiff_plain;f=sfa%2Frspecs%2Felements%2Felement.py;h=5789a9cca12460bed6bedd2f43ec49bf1424f625;hb=a46a2219f92cb2d54b95b411901f64138486e6cd;hp=6f15d6014bc493a61bf3dd66ccce2595912c2caa;hpb=63d07d77906821d39a62d4583bb5259a5c5283ce;p=sfa.git

diff --git a/sfa/rspecs/elements/element.py b/sfa/rspecs/elements/element.py
index 6f15d601..5789a9cc 100644
--- a/sfa/rspecs/elements/element.py
+++ b/sfa/rspecs/elements/element.py
@@ -20,9 +20,8 @@ class Element(dict):
         """
         if not element_class:
             element_class = Element
-# xxx this obviously is wrong...
-#        if not fields and hasattr(element_class, fields):
-#           fields = element_class.fields
+        if not fields and hasattr(element_class, 'fields'):
+           fields = element_class.fields
         elems = xml.xpath(xpath)
         objs = []
         for elem in elems:
@@ -34,11 +33,8 @@ class Element(dict):
                     if field in elem.attrib:
                         obj[field] = elem.attrib[field]    
             objs.append(obj)
-# xxx seems unused
-        generic_elems = [element_class(elem.attrib, elem) for elem in elems]
         return objs
 
-
     @staticmethod
     def add_elements(xml, name, objs, fields=None):
         """