X-Git-Url: http://git.onelab.eu/?a=blobdiff_plain;f=sfa%2Frspecs%2Fpg_rspec_converter.py;h=c0eaad75af6c78fbcddf3c84e90db03f7123cb1a;hb=4a9e6751f9f396f463932133b9d62fc925a99ef6;hp=5cccf9725413e9f0e2733c6ed898985a1e3b1c46;hpb=080e7f90e2c66067aea94c96c4de68fc998e009b;p=sfa.git

diff --git a/sfa/rspecs/pg_rspec_converter.py b/sfa/rspecs/pg_rspec_converter.py
index 5cccf972..c0eaad75 100755
--- a/sfa/rspecs/pg_rspec_converter.py
+++ b/sfa/rspecs/pg_rspec_converter.py
@@ -1,11 +1,14 @@
-#!/usr/bin/python 
+#!/usr/bin/env python3
+
+
 from lxml import etree
-from StringIO import StringIO
 from sfa.util.xrn import Xrn, urn_to_hrn
 from sfa.rspecs.rspec import RSpec
 from sfa.rspecs.version_manager import VersionManager
 
-xslt='''<xsl:stylesheet version="1.0" xmlns:xsl="http://www.w3.org/1999/XSL/Transform">
+from sfa.util.py23 import StringIO
+
+xslt = '''<xsl:stylesheet version="1.0" xmlns:xsl="http://www.w3.org/1999/XSL/Transform">
 <xsl:output method="xml" indent="no"/>
 
 <xsl:template match="/|comment()|processing-instruction()">
@@ -28,60 +31,70 @@ xslt='''<xsl:stylesheet version="1.0" xmlns:xsl="http://www.w3.org/1999/XSL/Tran
 </xsl:stylesheet>
 '''
 
-xslt_doc=etree.parse(StringIO(xslt))
-transform=etree.XSLT(xslt_doc)
+xslt_doc = etree.parse(StringIO(xslt))
+transform = etree.XSLT(xslt_doc)
+
 
 class PGRSpecConverter:
 
     @staticmethod
-    def to_sfa_rspec(rspec, content_type = None):
+    def to_sfa_rspec(rspec, content_type=None):
         if not isinstance(rspec, RSpec):
             pg_rspec = RSpec(rspec)
         else:
             pg_rspec = rspec
-        
+
         version_manager = VersionManager()
-        sfa_version = version_manager._get_version('sfa', '1')    
+        sfa_version = version_manager._get_version('sfa', '1')
         sfa_rspec = RSpec(version=sfa_version)
 
         #nodes = pg_rspec.version.get_nodes()
-        #sfa_rspec.version.add_nodes(nodes())
-        #sfa_rspec.version.add_links(pg_rspec.version.get_links())
-        #return sfa_rspec.toxml() 
+        # sfa_rspec.version.add_nodes(nodes())
+        # sfa_rspec.version.add_links(pg_rspec.version.get_links())
+        # return sfa_rspec.toxml()
 
         # get network
         networks = pg_rspec.version.get_networks()
-        network_hrn = networks[0]
-        network_element = sfa_rspec.xml.add_element('network', name=network_hrn, id=network_hrn)
-        
+        network_hrn = networks[0]["name"]
+        network_element = sfa_rspec.xml.add_element(
+            'network', name=network_hrn, id=network_hrn)
+
         # get nodes
-        pg_nodes_elements = pg_rspec.version.get_node_elements()
+        pg_nodes_elements = pg_rspec.version.get_nodes()
         nodes_with_slivers = pg_rspec.version.get_nodes_with_slivers()
         i = 1
-        for pg_node_element in pg_nodes_elements:
-            attribs = dict(pg_node_element.attrib.items()) 
-            attribs['id'] = 'n'+str(i)
-            
+        for pg_node in pg_nodes_elements:
+            attribs = dict(list(pg_node.items()))
+            attribs['id'] = 'n' + str(i)
+
             node_element = network_element.add_element('node')
             for attrib in attribs:
-                node_element.set(attrib, attribs[attrib])
-            urn = pg_node_element.xpath('@component_id', namespaces=pg_rspec.namespaces)
+                if type(attribs[attrib]) == str:
+                    node_element.set(attrib, attribs[attrib])
+            urn = pg_node["component_id"]
             if urn:
-                urn = urn[0]
+                if type(urn) == list:
+                    # legacy code, not sure if urn is ever a list...
+                    urn = urn[0]
                 hostname = Xrn.urn_split(urn)[-1]
                 hostname_element = node_element.add_element('hostname')
                 hostname_element.set_text(hostname)
                 if hostname in nodes_with_slivers:
-                    node_element.add_element('sliver')  
-                     
-            # just copy over remaining child elements  
-            for child in pg_node_element.getchildren():
-                node_element.append(transform(child).getroot())
-            i = i+1
- 
+                    node_element.add_element('sliver')
+
+            for hardware_type in pg_node["hardware_types"]:
+                if "name" in hardware_type:
+                    node_element.add_element(
+                        "hardware_type", name=hardware_type["name"])
+
+            # just copy over remaining child elements
+            # for child in pg_node_element.getchildren():
+            #    node_element.append(transform(child).getroot())
+            i = i + 1
+
         return sfa_rspec.toxml()
-         
+
 if __name__ == '__main__':
     import sys
-    if len(sys.argv) > 1:        
-        print PGRSpecConverter.to_sfa_rspec(sys.argv[1])  
+    if len(sys.argv) > 1:
+        print(PGRSpecConverter.to_sfa_rspec(sys.argv[1]))