X-Git-Url: http://git.onelab.eu/?a=blobdiff_plain;f=sliver_lxc.py;h=7db1a78c1b95b4a7e4511d3fee8ec1805e1f8eb4;hb=f4e23a36bf09db433870ce196d73bbe66f8c749c;hp=37055986dd34ad82073f6e2542b46dd2bddbb86f;hpb=ceae8bc56f3f46d5913ca8988b701337a35135cf;p=nodemanager.git diff --git a/sliver_lxc.py b/sliver_lxc.py index 3705598..7db1a78 100644 --- a/sliver_lxc.py +++ b/sliver_lxc.py @@ -10,6 +10,13 @@ import grp from pwd import getpwnam from string import Template +# vsys probably should not be a plugin +# the thing is, the right way to handle stuff would be that +# if slivers get created by doing a,b,c +# then they sohuld be delted by doing c,b,a +# the current ordering model for vsys plugins completely fails to capture that +from plugins.vsys import removeSliverFromVsys + import libvirt import logger @@ -83,7 +90,7 @@ class Sliver_LXC(Sliver_Libvirt, Initscript): vref = rec['vref'] if vref is None: - vref = "lxc-f14-x86_64" + vref = "lxc-f18-x86_64" logger.log("sliver_libvirt: %s: WARNING - no vref attached, using hard-wired default %s" % (name,vref)) refImgDir = os.path.join(Sliver_LXC.REF_IMG_BASE_DIR, vref) @@ -263,7 +270,7 @@ unset pathmunge dom = conn.lookupByName(name) except: dom = conn.defineXML(xml) - logger.verbose('lxc_create: %s -> %s'%(name, Sliver_Libvirt.debuginfo(dom))) + logger.verbose('lxc_create: %s -> %s'%(name, Sliver_Libvirt.dom_details(dom))) @staticmethod @@ -295,13 +302,10 @@ unset pathmunge command = ['/usr/sbin/userdel', '-f', '-r', name] logger.log_call(command, timeout=15*60) - if os.path.exists(os.path.join(containerDir,"vsys")): - # Slivers with vsys running will fail the subvolume delete. - # A more permanent solution may be to ensure that the vsys module - # is called before the sliver is destroyed. - logger.log("destroying vsys directory and restarting vsys") - logger.log_call(["rm", "-fR", os.path.join(containerDir, "vsys")]) - logger.log_call(["/etc/init.d/vsys", "restart", ]) + # Slivers with vsys running will fail the subvolume delete. + # A more permanent solution may be to ensure that the vsys module + # is called before the sliver is destroyed. + removeSliverFromVsys (name) # Remove rootfs of destroyed domain command = ['btrfs', 'subvolume', 'delete', containerDir]