X-Git-Url: http://git.onelab.eu/?a=blobdiff_plain;f=sliver_lxc.py;h=96b757fe126349e49295ccb40ade0ee7f1185861;hb=a91c5b1c1aa81d18a9e8397288e7e9ccbcd8abd2;hp=d4335c4a831ee06754c2ef6c3f0dc53af466527b;hpb=6ea3876af57fbc4f533de28941dc19a90b3a7be2;p=nodemanager.git diff --git a/sliver_lxc.py b/sliver_lxc.py index d4335c4..96b757f 100644 --- a/sliver_lxc.py +++ b/sliver_lxc.py @@ -4,6 +4,7 @@ import subprocess import sys +import time import os, os.path import grp from pwd import getpwnam @@ -86,7 +87,7 @@ class Sliver_LXC(Sliver_Libvirt, Initscript): # subvolume) command = ['btrfs', 'subvolume', 'snapshot', refImgDir, containerDir] if not logger.log_call(command, timeout=15*60): - logger.log('sliver_lxc: ERROR Could not create BTRFS snapshot at', containDir) + logger.log('sliver_lxc: ERROR Could not create BTRFS snapshot at', containerDir) return command = ['chmod', '755', containerDir] logger.log_call(command, timeout=15*60) @@ -157,10 +158,21 @@ class Sliver_LXC(Sliver_Libvirt, Initscript): logger.log("uid is %d" % uid) command = ['mkdir', '%s/home/%s' % (containerDir, name)] logger.log_call(command, timeout=10) + command = ['chown', name, '%s/home/%s' % (containerDir, name)] + logger.log_call(command, timeout=10) etcpasswd = os.path.join(containerDir, 'etc/passwd') if os.path.exists(etcpasswd): logger.log("adding user %s id %d to %s" % (name, uid, etcpasswd)) - file(etcpasswd,'a').write("%s:x:%d:%d::/home/%s:/bin/bash\n" % (name, uid, uid, name)) + try: + file(etcpasswd,'a').write("%s:x:%d:%d::/home/%s:/bin/bash\n" % (name, uid, uid, name)) + except: + logger.log_exc("exception while updating etc/passwd") + sudoers = os.path.join(containerDir, 'etc/sudoers') + if os.path.exists(sudoers): + try: + file(sudoers,'a').write("%s ALL=(ALL) NOPASSWD: ALL\n" % name) + except: + logger.log_exc("exception while updating /etc/sudoers") # Lookup for xid and create template after the user is created so we # can get the correct xid based on the name of the slice @@ -221,9 +233,21 @@ class Sliver_LXC(Sliver_Libvirt, Initscript): command = ['/usr/sbin/userdel', '-f', '-r', name] logger.log_call(command, timeout=15*60) + if os.path.exists(os.path.join(containerDir,"vsys")): + # Slivers with vsys running will fail the subvolume delete. + # A more permanent solution may be to ensure that the vsys module + # is called before the sliver is destroyed. + logger.log("destroying vsys directory and restarting vsys") + logger.log_call(["rm", "-fR", os.path.join(containerDir, "vsys")]) + logger.log_call(["/etc/init.d/vsys", "restart", ]) + # Remove rootfs of destroyed domain command = ['btrfs', 'subvolume', 'delete', containerDir] logger.log_call(command, timeout=60) + if os.path.exists(containerDir): + # oh no, it's still here... + logger.log("WARNING: failed to destroy container %s" % containerDir) + logger.verbose('sliver_libvirt: %s destroyed.'%name)