X-Git-Url: http://git.onelab.eu/?a=blobdiff_plain;f=sliver_lxc.py;h=a9988fecf62a2720be16f2e47188d93ebc94469e;hb=0a3ad704b062bbad72dbbc1e0c753da56da45e84;hp=97374977ca687f15d83dc74184df5b1b38c0365e;hpb=83a563b8ca292a68f490c91224605e758649d3a6;p=nodemanager.git diff --git a/sliver_lxc.py b/sliver_lxc.py index 9737497..a9988fe 100644 --- a/sliver_lxc.py +++ b/sliver_lxc.py @@ -92,7 +92,7 @@ class Sliver_LXC(Sliver_Libvirt, Initscript): vref = rec['vref'] if vref is None: - vref = "lxc-f18-x86_64" + vref = "lxc-f24-x86_64" logger.log("sliver_libvirt: {}: WARNING - no vref attached, using hard-wired default {}" .format(name, vref)) @@ -127,7 +127,9 @@ class Sliver_LXC(Sliver_Libvirt, Initscript): logger.log('sliver_lxc: {}: ERROR Expected reference image in {}'.format(name, refImgDir)) return -# this hopefully should be fixed now +# during some time this fragment had been commented out +# but we're seeing cases where this code might actually be useful, so.. +# this hopefully should be fixed now # # in fedora20 we have some difficulty in properly cleaning up /vservers/ # # also note that running e.g. btrfs subvolume create /vservers/.lvref/image /vservers/foo # # behaves differently, whether /vservers/foo exists or not: @@ -135,15 +137,15 @@ class Sliver_LXC(Sliver_Libvirt, Initscript): # # but if it does exist, then it creates /vservers/foo/image !! # # so we need to check the expected container rootfs does not exist yet # # this hopefully could be removed in a future release -# if os.path.exists (containerDir): -# logger.log("sliver_lxc: {}: WARNING cleaning up pre-existing {}".format(name, containerDir)) -# command = ['btrfs', 'subvolume', 'delete', containerDir] -# logger.log_call(command, BTRFS_TIMEOUT) -# # re-check -# if os.path.exists (containerDir): -# logger.log('sliver_lxc: {}: ERROR Could not create sliver - could not clean up empty {}' -# .format(name, containerDir)) -# return + if os.path.exists (containerDir): + logger.log("sliver_lxc: {}: WARNING cleaning up pre-existing {}".format(name, containerDir)) + command = ['btrfs', 'subvolume', 'delete', containerDir] + logger.log_call(command, BTRFS_TIMEOUT) + # re-check + if os.path.exists (containerDir): + logger.log('sliver_lxc: {}: ERROR Could not create sliver - could not clean up empty {}' + .format(name, containerDir)) + return # Snapshot the reference image fs # this assumes the reference image is in its own subvolume