X-Git-Url: http://git.onelab.eu/?a=blobdiff_plain;f=sound%2Fpci%2Fatiixp_modem.c;h=bec2052ab337405ff9c8b57201d70edd952c37d7;hb=9e1bf581d67d87a1d7fc0ea500729e3a03643a26;hp=e1ed2e3a87fbabf9f4beec24b7a6b71eb2275e0c;hpb=8d40237c730b8be87c1b80a5d96b9c603fefa829;p=linux-2.6.git diff --git a/sound/pci/atiixp_modem.c b/sound/pci/atiixp_modem.c index e1ed2e3a8..bec2052ab 100644 --- a/sound/pci/atiixp_modem.c +++ b/sound/pci/atiixp_modem.c @@ -43,14 +43,15 @@ static int index[SNDRV_CARDS] = SNDRV_DEFAULT_IDX; /* Index 0-MAX */ static char *id[SNDRV_CARDS] = SNDRV_DEFAULT_STR; /* ID for this card */ static int enable[SNDRV_CARDS] = SNDRV_DEFAULT_ENABLE_PNP; /* Enable this card */ static int ac97_clock[SNDRV_CARDS] = {[0 ... (SNDRV_CARDS - 1)] = 48000}; +static int boot_devs; -module_param_array(index, int, NULL, 0444); +module_param_array(index, int, boot_devs, 0444); MODULE_PARM_DESC(index, "Index value for ATI IXP controller."); -module_param_array(id, charp, NULL, 0444); +module_param_array(id, charp, boot_devs, 0444); MODULE_PARM_DESC(id, "ID string for ATI IXP controller."); -module_param_array(enable, bool, NULL, 0444); +module_param_array(enable, bool, boot_devs, 0444); MODULE_PARM_DESC(enable, "Enable audio part of ATI IXP controller."); -module_param_array(ac97_clock, int, NULL, 0444); +module_param_array(ac97_clock, int, boot_devs, 0444); MODULE_PARM_DESC(ac97_clock, "AC'97 codec clock (default 48000Hz)."); @@ -1142,7 +1143,6 @@ static int snd_atiixp_resume(snd_card_t *card, unsigned int state) pci_enable_device(chip->pci); pci_set_power_state(chip->pci, 0); - pci_set_master(chip->pci); snd_atiixp_aclink_reset(chip); snd_atiixp_chip_start(chip); @@ -1196,7 +1196,6 @@ static int snd_atiixp_free(atiixp_t *chip) if (chip->remap_addr) iounmap(chip->remap_addr); pci_release_regions(chip->pci); - pci_disable_device(chip->pci); kfree(chip); return 0; } @@ -1224,10 +1223,8 @@ static int __devinit snd_atiixp_create(snd_card_t *card, return err; chip = kcalloc(1, sizeof(*chip), GFP_KERNEL); - if (chip == NULL) { - pci_disable_device(pci); + if (chip == NULL) return -ENOMEM; - } spin_lock_init(&chip->reg_lock); spin_lock_init(&chip->ac97_lock); @@ -1237,12 +1234,11 @@ static int __devinit snd_atiixp_create(snd_card_t *card, chip->irq = -1; if ((err = pci_request_regions(pci, "ATI IXP MC97")) < 0) { kfree(chip); - pci_disable_device(pci); return err; } chip->addr = pci_resource_start(pci, 0); chip->remap_addr = ioremap_nocache(chip->addr, pci_resource_len(pci, 0)); - if (chip->remap_addr == NULL) { + if (chip->remap_addr == 0) { snd_printk(KERN_ERR "AC'97 space ioremap problem\n"); snd_atiixp_free(chip); return -EIO;