X-Git-Url: http://git.onelab.eu/?a=blobdiff_plain;f=tools.py;h=a0fbe56516bd25d9e0178e71f61861cfde47e5a5;hb=854fdfe526baa82adf31f14cac8a62223b310050;hp=b6a189ad0f1fa68039bb89f559599eeea5ffe6f2;hpb=91077a5b37a3a3eec3c05e1d67b6a68efa75063a;p=nodemanager.git

diff --git a/tools.py b/tools.py
index b6a189a..a0fbe56 100644
--- a/tools.py
+++ b/tools.py
@@ -1,9 +1,6 @@
-# $Id$
-# $URL$
-
 """A few things that didn't seem to fit anywhere else."""
 
-import os
+import os, os.path
 import pwd
 import tempfile
 import fcntl
@@ -60,7 +57,7 @@ def daemon():
     os.setsid()
     if os.fork() != 0: os._exit(0)
     os.chdir('/')
-    os.umask(0)
+    os.umask(0022)
     devnull = os.open(os.devnull, os.O_RDWR)
     os.dup2(devnull, 0)
     # xxx fixme - this is just to make sure that nothing gets stupidly lost - should use devnull
@@ -123,8 +120,11 @@ def write_temp_file(do_write, mode=None, uidgid=None):
     return temporary_filename
 
 # replace a target file with a new contents - checks for changes
-# return True if a change occurred, in which case
-# chown/chmod settings should be taken care of
+# can handle chmod if requested
+# can also remove resulting file if contents are void, if requested
+# performs atomically:
+#    writes in a tmp file, which is then renamed (from sliverauth originally)
+# returns True if a change occurred, or the file is deleted
 def replace_file_with_string (target, new_contents, chmod=None, remove_if_empty=False):
     try:
         current=file(target).read()
@@ -138,16 +138,17 @@ def replace_file_with_string (target, new_contents, chmod=None, remove_if_empty=
             try: os.unlink(target)
             finally: return True
         return False
-    # overwrite target file
-    f=file(target,'w')
-    f.write(new_contents)
-    f.close()
+    # overwrite target file: create a temp in the same directory
+    path=os.path.dirname(target) or '.'
+    fd, name = tempfile.mkstemp('','repl',path)
+    os.write(fd,new_contents)
+    os.close(fd)
+    if os.path.exists(target):
+        os.unlink(target)
+    os.rename(name,target)
     if chmod: os.chmod(target,chmod)
     return True
 
-# not needed yet - should that unlink the new file ?
-#def replace_file_with_file (target, new):
-#    return replace_file_with_string (target, file(new).read())
 
 ####################
 # utilities functions to get (cached) information from the node