git://git.onelab.eu / sliver-openvswitch.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: b0ef055) | patch
ofproto: Avoid passing indeterminate value to rule_insert().
authorBen Pfaff <blp@nicira.com>
Wed, 10 Feb 2010 19:18:48 +0000 (11:18 -0800)
committerBen Pfaff <blp@nicira.com>
Thu, 11 Feb 2010 18:35:28 +0000 (10:35 -0800)
commit212fe71c79ecb40059d01cbe6f218a5e57144c82
tree92dbeddc511fd793bb96c51e8d3fde8e4eb90cfbtree | snapshot
parentb0ef0551167affac2c406fcdeb2b4130e359f32ccommit | diff
ofproto: Avoid passing indeterminate value to rule_insert().

The 'in_port' argument to rule_insert() is only used if its 'packet'
argument is nonnull, so this is not, strictly speaking, a bug, but it
seems much cleaner.

The default -1 value of in_port matches what pktbuf_retrieve() stores
there on failure.

Found by Clang (http://clang-analyzer.llvm.org).
ofproto/ofproto.c diff | blob | history
sliver-openvswitch