ofproto-dpif-upcall: Remove the flow_dumper thread.
authorEthan Jackson <ethan@nicira.com>
Thu, 10 Apr 2014 07:14:08 +0000 (07:14 +0000)
committerJoe Stringer <joestringer@nicira.com>
Thu, 24 Apr 2014 04:31:01 +0000 (16:31 +1200)
commit7d1700980b5dcf98003fdceb821d7967fad99786
treea59d828f7fb571299837b525720f0479a64edc6e
parent96be8de5951502c4d23f80529f4b8785aaf94f04
ofproto-dpif-upcall: Remove the flow_dumper thread.

Previously, we had a separate flow_dumper thread that fetched flows from
the datapath to distribute to revalidator threads. This patch takes the
logic for dumping and pushes it into the revalidator threads, resulting
in simpler code with similar performance to the current code.

One thread, the "leader", is responsible for beginning and ending each
flow dump, maintaining the flow_limit, and checking whether the
revalidator threads need to exit. All revalidator threads dump,
revalidate, delete datapath flows and garbage collect ukeys.

Co-authored-by: Joe Stringer <joestringer@nicira.com>
Signed-off-by: Joe Stringer <joestringer@nicira.com>
Acked-by: Ben Pfaff <blp@nicira.com>
ofproto/ofproto-dpif-upcall.c
tests/ofproto-dpif.at