git://git.onelab.eu
/
sliver-openvswitch.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
8b7f5fb
)
learn: Initialize cookie_mask in constructed flow_mod.
author
Ben Pfaff
<blp@nicira.com>
Tue, 20 Mar 2012 18:32:08 +0000
(11:32 -0700)
committer
Ben Pfaff
<blp@nicira.com>
Wed, 21 Mar 2012 16:09:40 +0000
(09:09 -0700)
Otherwise the "learn" action may not correctly set the cookie in flows that
it creates.
Found by valgrind.
Signed-off-by: Ben Pfaff <blp@nicira.com>
lib/learn.c
patch
|
blob
|
history
diff --git
a/lib/learn.c
b/lib/learn.c
index
9d97cb3
..
284a6cd
100644
(file)
--- a/
lib/learn.c
+++ b/
lib/learn.c
@@
-190,6
+190,7
@@
learn_execute(const struct nx_action_learn *learn, const struct flow *flow,
cls_rule_init_catchall(&fm->cr, ntohs(learn->priority));
fm->cookie = learn->cookie;
+ fm->cookie_mask = htonll(UINT64_MAX);
fm->table_id = learn->table_id;
fm->command = OFPFC_MODIFY_STRICT;
fm->idle_timeout = ntohs(learn->idle_timeout);