git://git.onelab.eu
/
sliver-openvswitch.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
|
inline
| side by side (parent:
811da49
)
ovsdb-idl: Remove deadcode related to "reply" in ovsdb_idl_run().
author
Justin Pettit
<jpettit@nicira.com>
Wed, 23 Feb 2011 18:38:59 +0000
(10:38 -0800)
committer
Justin Pettit
<jpettit@nicira.com>
Wed, 23 Feb 2011 19:08:20 +0000
(11:08 -0800)
Coverity #10705
lib/ovsdb-idl.c
patch
|
blob
|
history
diff --git
a/lib/ovsdb-idl.c
b/lib/ovsdb-idl.c
index
df5aff5
..
e7f19e4
100644
(file)
--- a/
lib/ovsdb-idl.c
+++ b/
lib/ovsdb-idl.c
@@
-282,7
+282,7
@@
ovsdb_idl_run(struct ovsdb_idl *idl)
assert(!idl->txn);
jsonrpc_session_run(idl->session);
for (i = 0; jsonrpc_session_is_connected(idl->session) && i < 50; i++) {
assert(!idl->txn);
jsonrpc_session_run(idl->session);
for (i = 0; jsonrpc_session_is_connected(idl->session) && i < 50; i++) {
- struct jsonrpc_msg *msg
, *reply
;
+ struct jsonrpc_msg *msg;
unsigned int seqno;
seqno = jsonrpc_session_get_seqno(idl->session);
unsigned int seqno;
seqno = jsonrpc_session_get_seqno(idl->session);
@@
-298,7
+298,6
@@
ovsdb_idl_run(struct ovsdb_idl *idl)
break;
}
break;
}
- reply = NULL;
if (msg->type == JSONRPC_NOTIFY
&& !strcmp(msg->method, "update")
&& msg->params->type == JSON_ARRAY
if (msg->type == JSONRPC_NOTIFY
&& !strcmp(msg->method, "update")
&& msg->params->type == JSON_ARRAY
@@
-329,9
+328,6
@@
ovsdb_idl_run(struct ovsdb_idl *idl)
jsonrpc_session_get_name(idl->session),
jsonrpc_msg_type_to_string(msg->type));
}
jsonrpc_session_get_name(idl->session),
jsonrpc_msg_type_to_string(msg->type));
}
- if (reply) {
- jsonrpc_session_send(idl->session, reply);
- }
jsonrpc_msg_destroy(msg);
}
jsonrpc_msg_destroy(msg);
}