This is proper kernel style.
Kernel style also encourages using a type name instead of an expression as
sizeof's operand, but this patch doesn't make any of those changes.
Signed-off-by: Ben Pfaff <blp@nicira.com>
Acked-by: Jesse Gross <jesse@nicira.com>
- * Copyright (c) 2009, 2010 Nicira Networks.
+ * Copyright (c) 2009, 2010, 2011 Nicira Networks.
* Distributed under the terms of the GNU GPL version 2.
*
* Significant portions of this file may be copied from parts of the Linux
* Distributed under the terms of the GNU GPL version 2.
*
* Significant portions of this file may be copied from parts of the Linux
- if (e->namelen >= sizeof name) {
+ if (e->namelen >= sizeof(name)) {
/* Can't happen: we prevent adding names this long by
* limiting the BRC_GENL_A_PROC_NAME string to
* BRC_NAME_LEN_MAX bytes. */
/* Can't happen: we prevent adding names this long by
* limiting the BRC_GENL_A_PROC_NAME string to
* BRC_NAME_LEN_MAX bytes. */
- snprintf(devname, sizeof devname, "of%d", dp_idx);
+ snprintf(devname, sizeof(devname), "of%d", dp_idx);
goto err_put_module;
err = -ENOMEM;
goto err_put_module;
err = -ENOMEM;
- dp = kzalloc(sizeof *dp, GFP_KERNEL);
+ dp = kzalloc(sizeof(*dp), GFP_KERNEL);
if (dp == NULL)
goto err_put_module;
INIT_LIST_HEAD(&dp->port_list);
if (dp == NULL)
goto err_put_module;
INIT_LIST_HEAD(&dp->port_list);
- if (copy_from_user(&port, portp, sizeof port))
+ if (copy_from_user(&port, portp, sizeof(port)))
goto out;
port.devname[IFNAMSIZ - 1] = '\0';
port.type[VPORT_TYPE_SIZE - 1] = '\0';
goto out;
port.devname[IFNAMSIZ - 1] = '\0';
port.type[VPORT_TYPE_SIZE - 1] = '\0';
nskb = skb->next;
skb->next = NULL;
nskb = skb->next;
skb->next = NULL;
- err = skb_cow(skb, sizeof *header);
+ err = skb_cow(skb, sizeof(*header));
if (err)
goto err_kfree_skbs;
if (err)
goto err_kfree_skbs;
- header = (struct odp_msg*)__skb_push(skb, sizeof *header);
+ header = (struct odp_msg*)__skb_push(skb, sizeof(*header));
header->type = queue_no;
header->length = skb->len;
header->port = port_no;
header->type = queue_no;
header->length = skb->len;
header->port = port_no;
struct odp_flow uf;
int error;
struct odp_flow uf;
int error;
- if (copy_from_user(&uf, ufp, sizeof uf))
+ if (copy_from_user(&uf, ufp, sizeof(uf)))
return -EFAULT;
flow = do_del_flow(dp, &uf.key);
return -EFAULT;
flow = do_del_flow(dp, &uf.key);
struct tbl_node *flow_node;
int error;
struct tbl_node *flow_node;
int error;
- if (copy_from_user(&uf, ufp, sizeof uf))
+ if (copy_from_user(&uf, ufp, sizeof(uf)))
return -EFAULT;
flow_node = tbl_lookup(table, &uf.key, flow_hash(&uf.key), flow_cmp);
return -EFAULT;
flow_node = tbl_lookup(table, &uf.key, flow_hash(&uf.key), flow_cmp);
struct odp_flow __user *ufp = &cbdata->uflows[cbdata->listed_flows++];
int error;
struct odp_flow __user *ufp = &cbdata->uflows[cbdata->listed_flows++];
int error;
- if (copy_to_user(&ufp->key, &flow->key, sizeof flow->key))
+ if (copy_to_user(&ufp->key, &flow->key, sizeof(flow->key)))
return -EFAULT;
error = answer_query(cbdata->dp, flow, 0, ufp);
if (error)
return -EFAULT;
error = answer_query(cbdata->dp, flow, 0, ufp);
if (error)
int retval;
uflowvec = (struct odp_flowvec __user *)argp;
int retval;
uflowvec = (struct odp_flowvec __user *)argp;
- if (copy_from_user(&flowvec, uflowvec, sizeof flowvec))
+ if (copy_from_user(&flowvec, uflowvec, sizeof(flowvec)))
return -EFAULT;
if (flowvec.n_flows > INT_MAX / sizeof(struct odp_flow))
return -EFAULT;
if (flowvec.n_flows > INT_MAX / sizeof(struct odp_flow))
{
struct odp_execute execute;
{
struct odp_execute execute;
- if (copy_from_user(&execute, executep, sizeof execute))
+ if (copy_from_user(&execute, executep, sizeof(execute)))
return -EFAULT;
return do_execute(dp, &execute);
return -EFAULT;
return do_execute(dp, &execute);
}
stats.max_miss_queue = DP_MAX_QUEUE_LEN;
stats.max_action_queue = DP_MAX_QUEUE_LEN;
}
stats.max_miss_queue = DP_MAX_QUEUE_LEN;
stats.max_action_queue = DP_MAX_QUEUE_LEN;
- return copy_to_user(statsp, &stats, sizeof stats) ? -EFAULT : 0;
+ return copy_to_user(statsp, &stats, sizeof(stats)) ? -EFAULT : 0;
}
/* MTU of the dp pseudo-device: ETH_DATA_LEN or the minimum of the ports */
}
/* MTU of the dp pseudo-device: ETH_DATA_LEN or the minimum of the ports */
- memset(&op, 0, sizeof op);
+ memset(&op, 0, sizeof(op));
- strncpy(op.devname, vport_get_name(p), sizeof op.devname);
- strncpy(op.type, vport_get_type(p), sizeof op.type);
+ strncpy(op.devname, vport_get_name(p), sizeof(op.devname));
+ strncpy(op.type, vport_get_type(p), sizeof(op.type));
vport_get_config(p, op.config);
rcu_read_unlock();
op.port = p->port_no;
vport_get_config(p, op.config);
rcu_read_unlock();
op.port = p->port_no;
- return copy_to_user(uop, &op, sizeof op) ? -EFAULT : 0;
+ return copy_to_user(uop, &op, sizeof(op)) ? -EFAULT : 0;
}
static int query_port(struct datapath *dp, struct odp_port __user *uport)
}
static int query_port(struct datapath *dp, struct odp_port __user *uport)
struct odp_port port;
struct vport *vport;
struct odp_port port;
struct vport *vport;
- if (copy_from_user(&port, uport, sizeof port))
+ if (copy_from_user(&port, uport, sizeof(port)))
return -EFAULT;
if (port.devname[0]) {
return -EFAULT;
if (port.devname[0]) {
struct odp_portvec pv;
int retval;
struct odp_portvec pv;
int retval;
- if (copy_from_user(&pv, upv, sizeof pv))
+ if (copy_from_user(&pv, upv, sizeof(pv)))
return -EFAULT;
retval = do_list_ports(dp, (struct odp_port __user __force *)pv.ports,
return -EFAULT;
retval = do_list_ports(dp, (struct odp_port __user __force *)pv.ports,
struct compat_odp_portvec pv;
int retval;
struct compat_odp_portvec pv;
int retval;
- if (copy_from_user(&pv, upv, sizeof pv))
+ if (copy_from_user(&pv, upv, sizeof(pv)))
return -EFAULT;
retval = do_list_ports(dp, compat_ptr(pv.ports), pv.n_ports);
return -EFAULT;
retval = do_list_ports(dp, compat_ptr(pv.ports), pv.n_ports);
struct compat_odp_flow __user *ufp = &cbdata->uflows[cbdata->listed_flows++];
int error;
struct compat_odp_flow __user *ufp = &cbdata->uflows[cbdata->listed_flows++];
int error;
- if (copy_to_user(&ufp->key, &flow->key, sizeof flow->key))
+ if (copy_to_user(&ufp->key, &flow->key, sizeof(flow->key)))
return -EFAULT;
error = compat_answer_query(cbdata->dp, flow, 0, ufp);
if (error)
return -EFAULT;
error = compat_answer_query(cbdata->dp, flow, 0, ufp);
if (error)
int retval;
uflowvec = compat_ptr(argp);
int retval;
uflowvec = compat_ptr(argp);
- if (!access_ok(VERIFY_WRITE, uflowvec, sizeof *uflowvec) ||
- copy_from_user(&flowvec, uflowvec, sizeof flowvec))
+ if (!access_ok(VERIFY_WRITE, uflowvec, sizeof(*uflowvec)) ||
+ copy_from_user(&flowvec, uflowvec, sizeof(flowvec)))
return -EFAULT;
if (flowvec.n_flows > INT_MAX / sizeof(struct compat_odp_flow))
return -EFAULT;
if (flowvec.n_flows > INT_MAX / sizeof(struct compat_odp_flow))
if (actions_len > 2 * DP_MAX_PORTS * nla_total_size(4))
return ERR_PTR(-EINVAL);
if (actions_len > 2 * DP_MAX_PORTS * nla_total_size(4))
return ERR_PTR(-EINVAL);
- sfa = kmalloc(sizeof *sfa + actions_len, GFP_KERNEL);
+ sfa = kmalloc(sizeof(*sfa) + actions_len, GFP_KERNEL);
if (!sfa)
return ERR_PTR(-ENOMEM);
if (!sfa)
return ERR_PTR(-ENOMEM);
- memset(key, 0, sizeof *key);
+ memset(key, 0, sizeof(*key));
key->tun_id = OVS_CB(skb)->tun_id;
key->in_port = in_port;
*is_frag = false;
key->tun_id = OVS_CB(skb)->tun_id;
key->in_port = in_port;
*is_frag = false;
u32 flow_hash(const struct odp_flow_key *key)
{
u32 flow_hash(const struct odp_flow_key *key)
{
- return jhash2((u32*)key, sizeof *key / sizeof(u32), hash_seed);
+ return jhash2((u32*)key, sizeof(*key) / sizeof(u32), hash_seed);
}
int flow_cmp(const struct tbl_node *node, void *key2_)
}
int flow_cmp(const struct tbl_node *node, void *key2_)
if (flow_cache == NULL)
return -ENOMEM;
if (flow_cache == NULL)
return -ENOMEM;
- get_random_bytes(&hash_seed, sizeof hash_seed);
+ get_random_bytes(&hash_seed, sizeof(hash_seed));
- * Copyright (c) 2009, 2010 Nicira Networks.
+ * Copyright (c) 2009, 2010, 2011 Nicira Networks.
* Distributed under the terms of the GNU GPL version 2.
*
* Significant portions of this file may be copied from parts of the Linux
* Distributed under the terms of the GNU GPL version 2.
*
* Significant portions of this file may be copied from parts of the Linux
- table = kzalloc(sizeof *table, GFP_KERNEL);
+ table = kzalloc(sizeof(*table), GFP_KERNEL);