Previously, there was no way to induce coverage information to be
displayed; it would only print when the system noticed unusual delays
between polling intervals. Now, production of coverage logs can be
forced with "coverage/log" command in ovs-appctl. Coverage counters may
be reset with "coverage/clear".
#include "coverage-counters.h"
#include "dynamic-string.h"
#include "hash.h"
#include "coverage-counters.h"
#include "dynamic-string.h"
#include "hash.h"
#include "util.h"
#define THIS_MODULE VLM_coverage
#include "util.h"
#define THIS_MODULE VLM_coverage
static unsigned int epoch;
static unsigned int epoch;
+static void
+coverage_unixctl_log(struct unixctl_conn *conn, const char *args UNUSED)
+{
+ coverage_log(VLL_WARN, false);
+ unixctl_command_reply(conn, 200, NULL);
+}
+
+static void
+coverage_unixctl_clear(struct unixctl_conn *conn, const char *args UNUSED)
+{
+ coverage_clear();
+ unixctl_command_reply(conn, 200, NULL);
+}
+
+void
+coverage_init(void)
+{
+ unixctl_command_register("coverage/log", coverage_unixctl_log);
+ unixctl_command_register("coverage/clear", coverage_unixctl_clear);
+}
+
/* Sorts coverage counters in descending order by count, within equal counts
* alphabetically by name. */
static int
/* Sorts coverage counters in descending order by count, within equal counts
* alphabetically by name. */
static int
VLOG(level, "%-24s %5u / %9llu", c->name, c->count, c->count + c->total);
}
VLOG(level, "%-24s %5u / %9llu", c->name, c->count, c->count + c->total);
}
-/* Logs the coverage counters at the given vlog 'level'. */
+/* Logs the coverage counters at the given vlog 'level'. If
+ * 'suppress_dups' is true, then duplicate events are not displayed. */
-coverage_log(enum vlog_level level)
+coverage_log(enum vlog_level level, bool suppress_dups)
{
size_t n_never_hit;
uint32_t hash;
{
size_t n_never_hit;
uint32_t hash;
- hash = coverage_hash();
- if (coverage_hit(hash)) {
- VLOG(level, "Skipping details of duplicate event coverage for "
- "hash=%08"PRIx32" in epoch %u", hash, epoch);
- return;
+ if (suppress_dups) {
+ hash = coverage_hash();
+ if (coverage_hit(hash)) {
+ VLOG(level, "Skipping details of duplicate event coverage for "
+ "hash=%08"PRIx32" in epoch %u", hash, epoch);
+ return;
+ }
NAME##_count.count += AMOUNT; \
} while (0)
NAME##_count.count += AMOUNT; \
} while (0)
-void coverage_log(enum vlog_level);
+void coverage_init(void);
+void coverage_log(enum vlog_level, bool suppress_dups);
void coverage_clear(void);
#endif /* coverage.h */
void coverage_clear(void);
#endif /* coverage.h */
inited = true;
gettimeofday(&now, NULL);
tick = false;
inited = true;
gettimeofday(&now, NULL);
tick = false;
rusage.ru_nvcsw - last_rusage->ru_nvcsw,
rusage.ru_nivcsw - last_rusage->ru_nivcsw);
}
rusage.ru_nvcsw - last_rusage->ru_nvcsw,
rusage.ru_nivcsw - last_rusage->ru_nivcsw);
}
- coverage_log(VLL_WARN);
+ coverage_log(VLL_WARN, true);
}
/* Update exponentially weighted moving average. With these parameters, a
}
/* Update exponentially weighted moving average. With these parameters, a