vswitchd: Fix bug in Ethernet address selection for bridge.
authorBen Pfaff <blp@nicira.com>
Wed, 26 Aug 2009 19:51:39 +0000 (12:51 -0700)
committerBen Pfaff <blp@nicira.com>
Wed, 26 Aug 2009 19:51:39 +0000 (12:51 -0700)
This bug was introduced in the merge from the citrix branch in commit
8fef8c71 "Merge citrix into master."

Thanks to Reid for characterizing the problem.

Bug #1907.

vswitchd/bridge.c

index 25df8d4..869d717 100644 (file)
@@ -741,6 +741,7 @@ bridge_pick_local_hw_addr(struct bridge *br, uint8_t ea[ETH_ADDR_LEN],
             !eth_addr_is_zero(iface_ea) &&
             memcmp(iface_ea, ea, ETH_ADDR_LEN) < 0)
         {
+            memcpy(ea, iface_ea, ETH_ADDR_LEN);
             *hw_addr_iface = iface;
         }
     }