Fix test for fcntl return value.

POSIX only says that -1 is an error; other return values have unspecified
meanings.

diff --git a/lib/daemon.c b/lib/daemon.c
index b597717..58581b7 100644 (file)
--- a/lib/daemon.c
+++ b/lib/daemon.c
@@ -103,7 +103,7 @@ make_pidfile(void)
             lck.l_whence = SEEK_SET;
             lck.l_start = 0;
             lck.l_len = 0;
-            if (fcntl(fd, F_SETLK, &lck) >= 0) {
+            if (fcntl(fd, F_SETLK, &lck) != -1) {
                 char *text = xasprintf("%ld\n", pid);
                 if (write(fd, text, strlen(text)) == strlen(text)) {
                     fatal_signal_add_file_to_unlink(pidfile);