git://git.onelab.eu
/
sliver-openvswitch.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
7b9bbb8
)
ofproto: Fix memory leak in wx_port_free().
author
Ben Pfaff
<blp@nicira.com>
Wed, 25 Aug 2010 20:09:35 +0000
(13:09 -0700)
committer
Ben Pfaff
<blp@nicira.com>
Wed, 25 Aug 2010 20:09:35 +0000
(13:09 -0700)
wdp_port->devname should be freed, but this code wasn't doing that. Fix
it by using the existing wdp_port_free() function, which does free the
devname.
Reported-by: Tsvi Slonim <tsvi@toroki.com>
ofproto/wdp-xflow.c
patch
|
blob
|
history
diff --git
a/ofproto/wdp-xflow.c
b/ofproto/wdp-xflow.c
index
4a86d7e
..
32eace3
100644
(file)
--- a/
ofproto/wdp-xflow.c
+++ b/
ofproto/wdp-xflow.c
@@
-2306,10
+2306,8
@@
wx_port_remove(struct wx *wx, struct wdp_port *wdp_port)
static void
wx_port_free(struct wdp_port *wdp_port)
{
- if (wdp_port) {
- netdev_close(wdp_port->netdev);
- free(wdp_port);
- }
+ wdp_port_free(wdp_port);
+ free(wdp_port);
}
static void