docs

diff --git a/NEWS.md b/NEWS.md
index 727ec34..16e5f34 100644 (file)
--- a/NEWS.md
+++ b/NEWS.md
@@ -59,6 +59,9 @@
 
 * fixed: receiving integers which use the '<EX:I8>' xml tag
 
+* fixed: setting values to deprecated Response property `cookies` would trigger a PHP notice (introduced in 4.6.0), ex:
+  `$response->_cookies['name'] = ['value' => 'something'];`
+
 * new: method `PhpXmlRpc::useInteropFaults()` can be used to make the library change the error codes it generates to
   match the spec described at https://xmlrpc-epi.sourceforge.net/specs/rfc.fault_codes.php
 

diff --git a/src/Client.php b/src/Client.php
index 82c32e5..396e0eb 100644 (file)
--- a/src/Client.php
+++ b/src/Client.php
@@ -682,6 +682,10 @@ class Client
      */
     public function send($req, $timeout = 0, $method = '')
     {
+        //if ($method !== '' || $timeout !== 0) {
+        //    trigger_error("Using non-default values for arguments 'method' and 'timeout' when calling method " . __METHOD__ . ' is deprecated', E_USER_DEPRECATED);
+        //}
+
         // if user does not specify http protocol, use native method of this client
         // (i.e. method set during call to constructor)
         if ($method == '') {

diff --git a/src/Wrapper.php b/src/Wrapper.php
index 04a0a83..c80490a 100644 (file)
--- a/src/Wrapper.php
+++ b/src/Wrapper.php
@@ -667,6 +667,9 @@ class Wrapper
      * @param string $classMethod
      * @param array $extraOptions
      * @return string
+     *
+     * @todo php allows many more characters in identifiers than the xml-rpc spec does. We should make sure to
+     *       replace those (while trying to make sure we are not running in collisions)
      */
     protected function generateMethodNameForClassMethod($className, $classMethod, $extraOptions = array())
     {